Skip to content

Commit 320800a

Browse files
authored
fix(postgres): Fixed a problem with array dimensions disappearing when using "ALTER TABLE ADD COLUMN" (#2572)
* fix(postgres): Fixed a problem with array dimensions disappearing when using "ALTER TABLE ADD COLUMN". close #2571 * test: update endtoend
1 parent 2c5fbdd commit 320800a

File tree

7 files changed

+16
-9
lines changed

7 files changed

+16
-9
lines changed

internal/endtoend/testdata/ddl_alter_table_add_column/postgresql/pgx/v4/go/models.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
CREATE TABLE foo (bar text NOT NULL);
22
ALTER TABLE foo ADD COLUMN baz int;
33
ALTER TABLE foo ADD bio int;
4+
ALTER TABLE foo ADD COLUMN foobar int[];

internal/endtoend/testdata/ddl_alter_table_add_column/postgresql/pgx/v5/go/models.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
CREATE TABLE foo (bar text NOT NULL);
22
ALTER TABLE foo ADD COLUMN baz int;
33
ALTER TABLE foo ADD bio int;
4+
ALTER TABLE foo ADD COLUMN foobar int[];

internal/endtoend/testdata/ddl_alter_table_add_column/postgresql/stdlib/go/models.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
CREATE TABLE foo (bar text NOT NULL);
22
ALTER TABLE foo ADD COLUMN baz int;
33
ALTER TABLE foo ADD bio int;
4+
ALTER TABLE foo ADD COLUMN foobar int[];

internal/sql/catalog/table.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ func (table *Table) addColumn(cmd *ast.AlterTableCmd) error {
5757
IsNotNull: cmd.Def.IsNotNull,
5858
IsUnsigned: cmd.Def.IsUnsigned,
5959
IsArray: cmd.Def.IsArray,
60+
ArrayDims: cmd.Def.ArrayDims,
6061
Length: cmd.Def.Length,
6162
})
6263
return nil

0 commit comments

Comments
 (0)