test(analyzer): Add more database analyzer test cases (#2854)

* Fix #1322

* Fix #1425

* Prevent panics

* Fix #1515

Author: kyleconroy

internal/compiler/output_columns.go

@@ -608,6 +608,9 @@ func (c *Compiler) sourceTables(qc *QueryCatalog, node ast.Node) ([]*Table, erro
 			if err != nil {
 				return nil, err
 			}
+			if qc == nil {
+				return nil, fmt.Errorf("query catalog is empty")
+			}
 			table, cerr := qc.GetTable(fqn)
 			if cerr != nil {
 				// TODO: Update error location

internal/compiler/resolve.go

@@ -63,7 +63,10 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 		}
 		table, err := c.GetTable(fqn)
 		if err != nil {
-			// If the table name doesn't exist, fisrt check if it's a CTE
+			if qc == nil {
+				continue
+			}
+			// If the table name doesn't exist, first check if it's a CTE
 			if _, qcerr := qc.GetTable(fqn); qcerr != nil {
 				return nil, err
 			}

internal/endtoend/testdata/cte_update/issue.md

@@ -0,0 +1 @@
+https://github.com/sqlc-dev/sqlc/issues/1515

internal/endtoend/testdata/cte_update/postgresql/pgx/exec.json

@@ -0,0 +1,3 @@
+{
+  "contexts": ["managed-db"]
+}

internal/endtoend/testdata/cte_update/postgresql/pgx/go/db.go

@@ -0,0 +1,9 @@
+-- name: UpdateAttribute :one
+with updated_attribute as (UPDATE attribute_value
+    SET
+        val = CASE WHEN @filter_value::bool THEN @value ELSE val END
+    WHERE attribute_value.id = @id
+    RETURNING id,attribute,val)
+select updated_attribute.id, val, name
+from updated_attribute
+         left join attribute on updated_attribute.attribute = attribute.id;

internal/endtoend/testdata/cte_update/postgresql/pgx/go/models.go

@@ -0,0 +1,12 @@
+create table attribute_value
+(
+    id              bigserial not null,
+    val             text      not null,
+    attribute       bigint    not null
+);
+
+create table attribute
+(
+    id              bigserial      not null,
+    name            text           not null
+);

internal/endtoend/testdata/cte_update/postgresql/pgx/go/query.sql.go

@@ -0,0 +1,10 @@
+version: "2"
+sql:
+  - engine: "postgresql"
+    schema: "schema.sql"
+    queries: "query.sql"
+    gen:
+      go:
+        package: "querytest"
+        out: "go"
+        sql_package: "pgx/v5"

internal/endtoend/testdata/cte_update/postgresql/pgx/query.sql

@@ -0,0 +1 @@
+https://github.com/sqlc-dev/sqlc/issues/1322

internal/endtoend/testdata/cte_update/postgresql/pgx/schema.sql

@@ -0,0 +1,3 @@
+{
+  "contexts": ["managed-db"]
+}

internal/endtoend/testdata/cte_update/postgresql/pgx/sqlc.yaml

@@ -0,0 +1,2 @@
+-- name: Foo :one
+SELECT * FROM register_account('a', 'b');

internal/endtoend/testdata/func_return_table/issue.md

@@ -0,0 +1,27 @@
+CREATE TABLE accounts (
+  id         INTEGER GENERATED ALWAYS AS IDENTITY PRIMARY KEY,
+  username   TEXT NOT NULL UNIQUE,
+  password   TEXT NOT NULL
+);
+
+-- this is a useless and horrifying function cause we don't hash
+-- the password, this is just to repro the bug in sqlc
+CREATE OR REPLACE FUNCTION register_account(
+    _username TEXT,
+    _password VARCHAR(70)
+)
+RETURNS TABLE (
+    account_id   INTEGER
+)
+AS $$
+BEGIN
+  INSERT INTO accounts (username, password)
+       VALUES (
+         _username,
+         _password
+       )
+    RETURNING id INTO account_id;
+
+  RETURN NEXT;
+END;
+$$ LANGUAGE plpgsql;

internal/endtoend/testdata/func_return_table/postgresql/pgx/exec.json

@@ -0,0 +1,10 @@
+version: "2"
+sql:
+  - engine: "postgresql"
+    schema: "schema.sql"
+    queries: "query.sql"
+    gen:
+      go:
+        package: "querytest"
+        out: "go"
+        sql_package: "pgx/v5"

internal/endtoend/testdata/func_return_table/postgresql/pgx/go/db.go

@@ -0,0 +1 @@
+https://github.com/sqlc-dev/sqlc/issues/1425

internal/endtoend/testdata/func_return_table/postgresql/pgx/go/models.go

@@ -0,0 +1,3 @@
+{
+  "contexts": ["managed-db"]
+}

internal/endtoend/testdata/func_return_table/postgresql/pgx/go/query.sql.go

@@ -0,0 +1,2 @@
+-- name: SelectJoinUsing :many
+select t1.fk, sum(t2.fk) from t1 join t2 using (fk) group by fk;

internal/endtoend/testdata/func_return_table/postgresql/pgx/query.sql

@@ -0,0 +1,6 @@
+create table t1 (
+        fk integer not null unique
+);
+create table t2 (
+        fk integer not null references t1(fk)
+);

internal/endtoend/testdata/func_return_table/postgresql/pgx/schema.sql

@@ -0,0 +1,10 @@
+version: "2"
+sql:
+  - engine: "postgresql"
+    schema: "schema.sql"
+    queries: "query.sql"
+    gen:
+      go:
+        package: "querytest"
+        out: "go"
+        sql_package: "pgx/v5"