fix(mysql): Prevent UPDATE ... JOIN panic #1590 (#2154)

* fix: update panic

* fix: add test data

Author: nusr

internal/endtoend/testdata/update_two_table/mysql/go/db.go

@@ -0,0 +1,25 @@
+-- https://github.com/kyleconroy/sqlc/issues/1590
+CREATE TABLE authors (
+  name text NOT NULL,
+  deleted_at datetime NOT NULL,
+  created_at datetime NOT NULL,
+  updated_at datetime NOT NULL
+);
+
+CREATE TABLE books (
+  is_amazing tinyint(1) NOT NULL,
+  deleted_at datetime NOT NULL,
+  created_at datetime NOT NULL,
+  updated_at datetime NOT NULL
+);
+
+-- name: DeleteAuthor :exec
+UPDATE
+  authors,
+  books
+SET
+  authors.deleted_at = now(),
+  books.deleted_at = now()
+WHERE
+  books.is_amazing = 1
+  AND authors.name = sqlc.arg(name);

internal/endtoend/testdata/update_two_table/mysql/go/models.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "mysql",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/endtoend/testdata/update_two_table/mysql/go/query.sql.go

@@ -565,28 +565,7 @@ func (c *cc) convertUpdateStmt(n *pcast.UpdateStmt) *ast.UpdateStmt {
 	}
 
 	relations := &ast.List{}
-	switch rel := rels.Items[0].(type) {
-
-	// Special case for joins in updates
-	case *ast.JoinExpr:
-		left, ok := rel.Larg.(*ast.RangeVar)
-		if !ok {
-			panic("expected range var")
-		}
-		relations.Items = append(relations.Items, left)
-
-		right, ok := rel.Rarg.(*ast.RangeVar)
-		if !ok {
-			panic("expected range var")
-		}
-		relations.Items = append(relations.Items, right)
-
-	case *ast.RangeVar:
-		relations.Items = append(relations.Items, rel)
-
-	default:
-		panic("expected range var")
-	}
+	convertToRangeVarList(rels, relations)
 
 	// TargetList
 	list := &ast.List{}

internal/endtoend/testdata/update_two_table/mysql/query.sql

@@ -96,3 +96,43 @@ func isNotNull(n *pcast.ColumnDef) bool {
 	}
 	return false
 }
+
+func convertToRangeVarList(list *ast.List, result *ast.List) {
+	if len(list.Items) == 0 {
+		return
+	}
+	switch rel := list.Items[0].(type) {
+
+	// Special case for joins in updates
+	case *ast.JoinExpr:
+		left, ok := rel.Larg.(*ast.RangeVar)
+		if !ok {
+			if list, check := rel.Larg.(*ast.List); check {
+				convertToRangeVarList(list, result)
+			} else {
+				panic("expected range var")
+			}
+		}
+		if left != nil {
+			result.Items = append(result.Items, left)
+		}
+
+		right, ok := rel.Rarg.(*ast.RangeVar)
+		if !ok {
+			if list, check := rel.Rarg.(*ast.List); check {
+				convertToRangeVarList(list, result)
+			} else {
+				panic("expected range var")
+			}
+		}
+		if right != nil {
+			result.Items = append(result.Items, right)
+		}
+
+	case *ast.RangeVar:
+		result.Items = append(result.Items, rel)
+
+	default:
+		panic("expected range var")
+	}
+}