feat: Typecast Javascript Date objects to ISOStrings #335
Conversation
Without this change, using JS Date objects in bind values will make the library throw. By using the ISOString version we align with node-mysql on their typecasting behaviout for Date objects
|
Great, thank you very much for your contribution! Can you please add one or more tests for the feature? |
|
Glad you like it. Will add the test soon |
There was a problem hiding this comment.
I think what you meant to change was the Statement::bind function.
| @@ -495,6 +495,8 @@ class Database | |||
| blobptr = allocate result, 'i8', ALLOC_NORMAL | |||
| sqlite3_result_blob(cx, blobptr,result.length, -1) | |||
| _free blobptr | |||
| else if result instanceof Date | |||
| sqlite3_result_text(cx, result.toISOString(), -1, -1) | |||
There was a problem hiding this comment.
Are you sure this is what you wanted ?
This change allows user-defined functions to return a Date. This is great, but wasn't #334 about adding Date support to prepared statement parameters ?
There was a problem hiding this comment.
Thanks for the tips @lovasoa
Looks like I was too quick. I changed the build files and my test passed. Didn't realize there were two similar blocks of code.
Now that you have showed me the direction, let me take my time to fix the issues, add tests, add docs and polish the PR
Without this change, using JS Date objects in bind values will make the library throw. By using the ISOString version we align with node-mysql on their typecasting behaviour for Date objects
Fixes #334