Skip to content

Commit abf8f4e

Browse files
committed
code review
1 parent d55358c commit abf8f4e

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

springdoc-openapi-common/src/main/java/org/springdoc/core/AbstractRequestService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ private String getParamJavadoc(JavadocProvider javadocProvider, MethodParameter
687687
final String paramJavadocDescription;
688688
if (delegatingMethodParameter.isParameterObject()) {
689689
String fieldName;
690-
if (pName.contains(DOT))
690+
if (StringUtils.isNotEmpty(pName) && pName.contains(DOT))
691691
fieldName = StringUtils.substringAfter(pName, DOT);
692692
else
693693
fieldName = pName;

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ public void buildGenericResponse(Components components, Map<String, Object> find
217217
*/
218218
private boolean isResponseEntityExceptionHandlerMethod(Method m) {
219219
if (AnnotatedElementUtils.hasAnnotation(m.getDeclaringClass(), ControllerAdvice.class))
220-
return responseEntityExceptionHandlerClass != null && ((responseEntityExceptionHandlerClass.isAssignableFrom(m.getDeclaringClass()) && ReflectionUtils.findMethod(responseEntityExceptionHandlerClass, m.getName(), m.getParameterTypes()) != null));
220+
return responseEntityExceptionHandlerClass != null && (responseEntityExceptionHandlerClass.isAssignableFrom(m.getDeclaringClass()) && ReflectionUtils.findMethod(responseEntityExceptionHandlerClass, m.getName(), m.getParameterTypes()) != null);
221221
return false;
222222
}
223223

springdoc-openapi-common/src/main/java/org/springdoc/core/ParameterInfo.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ public class ParameterInfo {
7777
*/
7878
private boolean requestPart;
7979

80-
/**
81-
* The Generic parameter service.
82-
*/
83-
private GenericParameterService genericParameterService;
84-
8580
/**
8681
* The constant LOGGER.
8782
*/
@@ -95,8 +90,6 @@ public class ParameterInfo {
9590
* @param locale the locale
9691
*/
9792
public ParameterInfo(String pName, MethodParameter methodParameter, GenericParameterService genericParameterService, Locale locale) {
98-
this.genericParameterService = genericParameterService;
99-
PropertyResolverUtils propertyResolverUtils = genericParameterService.getPropertyResolverUtils();
10093
RequestHeader requestHeader = methodParameter.getParameterAnnotation(RequestHeader.class);
10194
RequestParam requestParam = methodParameter.getParameterAnnotation(RequestParam.class);
10295
PathVariable pathVar = methodParameter.getParameterAnnotation(PathVariable.class);

0 commit comments

Comments
 (0)