code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/Constants.java

@@ -106,6 +106,8 @@ public final class Constants {
 
 	public static final String OPENAPI_ARRAY_TYPE = "array";
 
+	public static final String GRACEFUL_EXCEPTION_OCCURRED = "Graceful exception occurred";
+
 	private Constants() {
 		super();
 	}

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericParameterBuilder.java

@@ -43,6 +43,8 @@
 import io.swagger.v3.oas.models.media.Schema;
 import io.swagger.v3.oas.models.parameters.Parameter;
 import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import org.springframework.core.MethodParameter;
 import org.springframework.core.ResolvableType;
@@ -57,6 +59,8 @@ public class GenericParameterBuilder {
 
 	private static final List<Class> ANNOTATIOSN_TO_IGNORE = new ArrayList<>();
 
+	private static final Logger LOGGER = LoggerFactory.getLogger(GenericParameterBuilder.class);
+
 	static {
 		FILE_TYPES.add(MultipartFile.class);
 		FILE_TYPES.add(Resource.class);
@@ -178,7 +182,13 @@ private void setSchema(io.swagger.v3.oas.annotations.Parameter parameterDoc, Com
 		if (StringUtils.isNotBlank(parameterDoc.ref()))
 			parameter.$ref(parameterDoc.ref());
 		else {
-			Schema schema = AnnotationsUtils.getSchema(parameterDoc.schema(), null,false,parameterDoc.schema().implementation(),components,jsonView ).orElse(null);
+			Schema schema = null;
+			try {
+				schema = AnnotationsUtils.getSchema(parameterDoc.schema(), null, false, parameterDoc.schema().implementation(), components, jsonView).orElse(null);
+			}
+			catch (Exception e) {
+				LOGGER.warn(Constants.GRACEFUL_EXCEPTION_OCCURRED, e);
+			}
 			if (schema == null) {
 				if (parameterDoc.content().length > 0)
 					schema = AnnotationsUtils.getSchema(parameterDoc.content()[0], components, jsonView).orElse(null);

springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocAnnotationsUtils.java

@@ -46,8 +46,6 @@ public class SpringDocAnnotationsUtils extends AnnotationsUtils {
 
 	private static final Logger LOGGER = LoggerFactory.getLogger(SpringDocAnnotationsUtils.class);
 
-	private static final String GRACEFUL_EXCEPTION_OCCURRED = "Graceful exception occurred";
-
 	public static Schema resolveSchemaFromType(Class<?> schemaImplementation, Components components,
 			JsonView jsonView, Annotation[] annotations) {
 		Schema schemaObject = extractSchema(components, schemaImplementation, jsonView, annotations);
@@ -68,8 +66,8 @@ public static Schema extractSchema(Components components, Type returnType, JsonV
 							new AnnotatedType(returnType).resolveAsRef(true).jsonViewAnnotation(jsonView).ctxAnnotations(annotations));
 		}
 		catch (Exception e) {
-			LOGGER.error(GRACEFUL_EXCEPTION_OCCURRED, e);
-			return new StringSchema();
+			LOGGER.warn(Constants.GRACEFUL_EXCEPTION_OCCURRED, e);
+			return null;
 		}
 		if (resolvedSchema.schema != null) {
 			schemaN = resolvedSchema.schema;