code review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseService.java

@@ -106,7 +106,7 @@ public class GenericResponseService {
 	/**
 	 * The Controller infos.
 	 */
-	private final List<ControllerAdviceInfo> controllerInfos = new ArrayList<>();
+	private final List<ControllerAdviceInfo> localExceptionHandlers = new ArrayList<>();
 
 	/**
 	 * The Controller advice infos.
@@ -243,7 +243,7 @@ public void buildGenericResponse(Components components, Map<String, Object> find
 					controllerAdviceInfos.add(controllerAdviceInfo);
 				}
 				else {
-					controllerInfos.add(controllerAdviceInfo);
+					localExceptionHandlers.add(controllerAdviceInfo);
 				}
 			}
 		}
@@ -646,7 +646,7 @@ else if (returnType instanceof ParameterizedType) {
 	 * @return the generic map response
 	 */
 	private synchronized Map<String, ApiResponse> getGenericMapResponse(Class<?> beanType) {
-		List<ControllerAdviceInfo> controllerAdviceInfosInThisBean = controllerInfos.stream()
+		List<ControllerAdviceInfo> controllerAdviceInfosInThisBean = localExceptionHandlers.stream()
 				.filter(controllerInfo -> beanType.equals(controllerInfo.getControllerAdvice().getClass()))
 				.collect(Collectors.toList());
 

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app35/ChildProperty.java

@@ -0,0 +1,35 @@
+package test.org.springdoc.api.app35;
+
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+
+import lombok.Data;
+
+@Entity
+public @Data
+class ChildProperty {
+
+    @Id
+    @GeneratedValue(strategy = GenerationType.AUTO)
+    private long id;
+
+    private String name;
+
+	public long getId() {
+		return id;
+	}
+
+	public void setId(long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+}

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app35/ChildPropertyRepository.java

@@ -0,0 +1,9 @@
+package test.org.springdoc.api.app35;
+
+import io.swagger.v3.oas.annotations.Hidden;
+
+import org.springframework.data.repository.PagingAndSortingRepository;
+
+@Hidden
+public interface ChildPropertyRepository extends PagingAndSortingRepository<ChildProperty, Long> {
+}

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app35/Property.java

@@ -0,0 +1,49 @@
+package test.org.springdoc.api.app35;
+
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.JoinColumn;
+import javax.persistence.ManyToOne;
+
+import lombok.Data;
+
+@Entity
+public @Data
+class Property {
+
+    @Id
+    @GeneratedValue(strategy = GenerationType.AUTO)
+    private long id;
+
+    private String name;
+
+    @ManyToOne
+    @JoinColumn(name = "child_property_id")
+    private ChildProperty myChildPropertyName;
+
+	public long getId() {
+		return id;
+	}
+
+	public void setId(long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	public ChildProperty getMyChildPropertyName() {
+		return myChildPropertyName;
+	}
+
+	public void setMyChildPropertyName(ChildProperty myChildPropertyName) {
+		this.myChildPropertyName = myChildPropertyName;
+	}
+}

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app35/PropertyRepository.java

@@ -0,0 +1,6 @@
+package test.org.springdoc.api.app35;
+
+import org.springframework.data.repository.PagingAndSortingRepository;
+
+public interface PropertyRepository extends PagingAndSortingRepository<Property, Long> {
+}

springdoc-openapi-data-rest/src/test/java/test/org/springdoc/api/app35/SpringDocApp35Test.java

@@ -0,0 +1,33 @@
+/*
+ *
+ *  *
+ *  *  *
+ *  *  *  * Copyright 2019-2020 the original author or authors.
+ *  *  *  *
+ *  *  *  * Licensed under the Apache License, Version 2.0 (the "License");
+ *  *  *  * you may not use this file except in compliance with the License.
+ *  *  *  * You may obtain a copy of the License at
+ *  *  *  *
+ *  *  *  *      https://www.apache.org/licenses/LICENSE-2.0
+ *  *  *  *
+ *  *  *  * Unless required by applicable law or agreed to in writing, software
+ *  *  *  * distributed under the License is distributed on an "AS IS" BASIS,
+ *  *  *  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  *  *  * See the License for the specific language governing permissions and
+ *  *  *  * limitations under the License.
+ *  *  *
+ *  *
+ *
+ */
+
+package test.org.springdoc.api.app35;
+
+import test.org.springdoc.api.AbstractSpringDocTest;
+
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
+public class SpringDocApp35Test extends AbstractSpringDocTest {
+
+	@SpringBootApplication
+	static class SpringDocTestApp {}
+}