Skip to content

Commit abe68ab

Browse files
committed
Merge remote-tracking branch 'origin/5.8.x'
2 parents cc8a93e + bd4e0fb commit abe68ab

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

config/src/main/java/org/springframework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ private LogoutFilter createRelyingPartyLogoutFilter(RelyingPartyRegistrationReso
265265
LogoutHandler[] logoutHandlers = this.logoutHandlers.toArray(new LogoutHandler[0]);
266266
Saml2RelyingPartyInitiatedLogoutSuccessHandler logoutRequestSuccessHandler = createSaml2LogoutRequestSuccessHandler(
267267
registrations);
268+
logoutRequestSuccessHandler.setLogoutRequestRepository(this.logoutRequestConfigurer.logoutRequestRepository);
268269
LogoutFilter logoutFilter = new LogoutFilter(logoutRequestSuccessHandler, logoutHandlers);
269270
logoutFilter.setLogoutRequestMatcher(createLogoutMatcher());
270271
return postProcess(logoutFilter);

config/src/test/java/org/springframework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurerTests.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
import static org.assertj.core.api.Assertions.assertThat;
8787
import static org.hamcrest.Matchers.containsString;
8888
import static org.mockito.ArgumentMatchers.any;
89+
import static org.mockito.ArgumentMatchers.eq;
8990
import static org.mockito.BDDMockito.given;
9091
import static org.mockito.BDDMockito.mock;
9192
import static org.mockito.BDDMockito.verify;
@@ -408,6 +409,18 @@ public void saml2LogoutResponseWhenCustomLogoutResponseHandlerThenUses() throws
408409
verify(getBean(Saml2LogoutResponseValidator.class)).validate(any());
409410
}
410411

412+
@Test
413+
public void saml2LogoutWhenCustomLogoutRequestRepositoryThenUses() throws Exception {
414+
this.spring.register(Saml2LogoutComponentsConfig.class).autowire();
415+
RelyingPartyRegistration registration = this.repository.findByRegistrationId("registration-id");
416+
Saml2LogoutRequest logoutRequest = Saml2LogoutRequest.withRelyingPartyRegistration(registration)
417+
.samlRequest(this.rpLogoutRequest).id(this.rpLogoutRequestId).relayState(this.rpLogoutRequestRelayState)
418+
.parameters((params) -> params.put("Signature", this.rpLogoutRequestSignature)).build();
419+
given(getBean(Saml2LogoutRequestResolver.class).resolve(any(), any())).willReturn(logoutRequest);
420+
this.mvc.perform(post("/logout").with(authentication(this.user)).with(csrf()));
421+
verify(getBean(Saml2LogoutRequestRepository.class)).saveLogoutRequest(eq(logoutRequest), any(), any());
422+
}
423+
411424
@Test
412425
public void saml2LogoutWhenLogoutGetThenLogsOutAndSendsLogoutRequest() throws Exception {
413426
this.spring.register(Saml2LogoutWithHttpGet.class).autowire();

0 commit comments

Comments
 (0)