Skip to content

Commit cdcdecc

Browse files
committed
* Bring back GROUP_OF_MESSAGES_ prefix
to avoid complex regexp and don't bother for edge cases, where even that regexp may fail
1 parent 9cf5c00 commit cdcdecc

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

spring-integration-core/src/main/java/org/springframework/integration/store/AbstractKeyValueMessageStore.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public abstract class AbstractKeyValueMessageStore extends AbstractMessageGroupS
4646

4747
protected static final String MESSAGE_KEY_PREFIX = "MESSAGE_";
4848

49-
protected static final String MESSAGE_GROUP_KEY_PREFIX = "MESSAGE_GROUP_";
49+
protected static final String MESSAGE_GROUP_KEY_PREFIX = "GROUP_OF_MESSAGES_";
5050

5151
private final String messagePrefix;
5252

@@ -167,7 +167,7 @@ public Message<?> removeMessage(UUID id) {
167167
@Override
168168
@ManagedAttribute
169169
public long getMessageCount() {
170-
Collection<?> messageIds = doListKeys(this.messagePrefix + "[^GROUP_]*");
170+
Collection<?> messageIds = doListKeys(this.messagePrefix + '*');
171171
return (messageIds != null) ? messageIds.size() : 0;
172172
}
173173

spring-integration-hazelcast/src/main/java/org/springframework/integration/hazelcast/store/HazelcastMessageStore.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ protected Object doRemove(Object id) {
7676
@Override
7777
protected Collection<?> doListKeys(String keyPattern) {
7878
Assert.hasText(keyPattern, "'keyPattern' must not be empty");
79-
return this.map.keySet(Predicates.regex(QueryConstants.KEY_ATTRIBUTE_NAME.value(),
80-
keyPattern.replaceAll("\\*", ".+")));
79+
return this.map.keySet(Predicates.like(QueryConstants.KEY_ATTRIBUTE_NAME.value(),
80+
keyPattern.replaceAll("\\*", "%")));
8181
}
8282

8383
}

spring-integration-redis/src/test/java/org/springframework/integration/redis/store/RedisMessageGroupStoreTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ static void setupConnection() {
8383
void setUpTearDown() {
8484
StringRedisTemplate template = RedisContainerTest.createStringRedisTemplate(redisConnectionFactory);
8585
template.delete(template.keys("MESSAGE_*"));
86+
template.delete(template.keys("GROUP_OF_MESSAGES_*"));
8687
}
8788

8889
@Test

0 commit comments

Comments
 (0)