Skip to content

Commit fe3aad4

Browse files
committed
Latest dependency updates (H2 1.4.189, Underscore.js 1.8.3)
1 parent cffad9d commit fe3aad4

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ ext {
1818
linkScmConnection = 'scm:git:git://github.com/spring-projects/spring-framework.git'
1919
linkScmDevConnection = 'scm:git:ssh://git@github.com:spring-projects/spring-framework.git'
2020

21-
moduleProjects = subprojects.findAll {
21+
moduleProjects = subprojects.findAll {
2222
!it.name.equals('spring-build-src') && !it.name.equals('spring-framework-bom')
2323
}
2424
}
@@ -141,7 +141,7 @@ configure(allprojects) { project ->
141141
testCompile("org.hamcrest:hamcrest-all:${hamcrestVersion}")
142142

143143
sniffer("org.codehaus.mojo:animal-sniffer-ant-tasks:${snifferVersion}")
144-
javaApiSignature("org.codehaus.mojo.signature:java16:1.1@signature") // as from JDK 6 update 18
144+
javaApiSignature("org.codehaus.mojo.signature:java16:1.1@signature") // API level from JDK 6 update 18
145145
}
146146

147147
task copyJavaApiSignature(type: Copy) {
@@ -628,7 +628,7 @@ project("spring-jdbc") {
628628
optional("javax.transaction:javax.transaction-api:${jtaVersion}")
629629
optional("com.mchange:c3p0:0.9.5.1")
630630
optional("org.hsqldb:hsqldb:${hsqldbVersion}")
631-
optional("com.h2database:h2:1.4.188")
631+
optional("com.h2database:h2:1.4.189")
632632
optional("org.apache.derby:derby:10.11.1.1")
633633
optional("org.apache.derby:derbyclient:10.11.1.1")
634634
}
@@ -937,7 +937,7 @@ project("spring-webmvc") {
937937
testCompile("org.slf4j:slf4j-jcl:${slf4jVersion}")
938938
testCompile("org.jruby:jruby:${jrubyVersion}")
939939
testCompile("org.python:jython-standalone:2.5.3")
940-
testCompile("org.webjars:underscorejs:1.8.2")
940+
testCompile("org.webjars:underscorejs:1.8.3")
941941
}
942942
}
943943

spring-webmvc/src/test/java/org/springframework/web/servlet/resource/WebJarsResourceResolverTests.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,8 @@
1616

1717
package org.springframework.web.servlet.resource;
1818

19-
import static org.junit.Assert.*;
20-
import static org.mockito.BDDMockito.*;
21-
import static org.mockito.Mockito.mock;
22-
import static org.mockito.Mockito.never;
23-
import static org.mockito.Mockito.times;
24-
import static org.mockito.Mockito.verify;
25-
2619
import java.util.Collections;
2720
import java.util.List;
28-
2921
import javax.servlet.http.HttpServletRequest;
3022

3123
import org.junit.Before;
@@ -35,6 +27,13 @@
3527
import org.springframework.core.io.Resource;
3628
import org.springframework.mock.web.test.MockHttpServletRequest;
3729

30+
import static org.junit.Assert.*;
31+
import static org.mockito.BDDMockito.*;
32+
import static org.mockito.Mockito.mock;
33+
import static org.mockito.Mockito.never;
34+
import static org.mockito.Mockito.times;
35+
import static org.mockito.Mockito.verify;
36+
3837
/**
3938
* Unit tests for
4039
* {@link org.springframework.web.servlet.resource.WebJarsResourceResolver}.
@@ -51,6 +50,7 @@ public class WebJarsResourceResolverTests {
5150

5251
private HttpServletRequest request = new MockHttpServletRequest();
5352

53+
5454
@Before
5555
public void setup() {
5656
// for this to work, an actual WebJar must be on the test classpath
@@ -59,6 +59,7 @@ public void setup() {
5959
this.chain = mock(ResourceResolverChain.class);
6060
}
6161

62+
6263
@Test
6364
public void resolveUrlExisting() {
6465
this.locations = Collections.singletonList(new ClassPathResource("/META-INF/resources/webjars/", getClass()));
@@ -87,7 +88,7 @@ public void resolveUrlExistingNotInJarFile() {
8788
@Test
8889
public void resolveUrlWebJarResource() {
8990
String file = "/underscorejs/underscore.js";
90-
String expected = "/underscorejs/1.8.2/underscore.js";
91+
String expected = "/underscorejs/1.8.3/underscore.js";
9192
given(this.chain.resolveUrlPath(file, this.locations)).willReturn(null);
9293
given(this.chain.resolveUrlPath(expected, this.locations)).willReturn(expected);
9394

@@ -139,7 +140,7 @@ public void resolveResourceNotFound() {
139140
public void resolveResourceWebJar() {
140141
Resource expected = mock(Resource.class);
141142
String file = "/underscorejs/underscore.js";
142-
String expectedPath = "/underscorejs/1.8.2/underscore.js";
143+
String expectedPath = "/underscorejs/1.8.3/underscore.js";
143144
this.locations = Collections.singletonList(new ClassPathResource("/META-INF/resources/webjars/", getClass()));
144145
given(this.chain.resolveResource(this.request, expectedPath, this.locations)).willReturn(expected);
145146

0 commit comments

Comments
 (0)