Skip to content

Commit f91fae5

Browse files
committed
Avoid deprecation warnings for imports
1 parent 7169577 commit f91fae5

File tree

5 files changed

+11
-14
lines changed

5 files changed

+11
-14
lines changed

spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaVendorAdapter.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.hibernate.SessionFactory;
2929
import org.hibernate.cfg.AvailableSettings;
3030
import org.hibernate.dialect.DB2Dialect;
31-
import org.hibernate.dialect.DerbyDialect;
3231
import org.hibernate.dialect.DerbyTenSevenDialect;
3332
import org.hibernate.dialect.H2Dialect;
3433
import org.hibernate.dialect.HANAColumnStoreDialect;
@@ -37,7 +36,6 @@
3736
import org.hibernate.dialect.MySQL57Dialect;
3837
import org.hibernate.dialect.Oracle12cDialect;
3938
import org.hibernate.dialect.PostgreSQL95Dialect;
40-
import org.hibernate.dialect.PostgreSQLDialect;
4139
import org.hibernate.dialect.SQLServer2012Dialect;
4240
import org.hibernate.dialect.SybaseDialect;
4341
import org.hibernate.resource.jdbc.spi.PhysicalConnectionHandlingMode;
@@ -173,7 +171,7 @@ private Map<String, Object> buildJpaPropertyMap(boolean connectionReleaseOnClose
173171
* @param database the target database
174172
* @return the Hibernate database dialect class, or {@code null} if none found
175173
*/
176-
@SuppressWarnings("deprecation") // for Derby/PostgreSQLDialect on Hibernate 6.2
174+
@SuppressWarnings("deprecation") // for DerbyDialect and PostgreSQLDialect on Hibernate 6.2
177175
@Nullable
178176
protected Class<?> determineDatabaseDialectClass(Database database) {
179177
if (oldDialectsPresent) { // Hibernate <6.2
@@ -195,13 +193,13 @@ protected Class<?> determineDatabaseDialectClass(Database database) {
195193
else { // Hibernate 6.2 aligned
196194
return switch (database) {
197195
case DB2 -> DB2Dialect.class;
198-
case DERBY -> DerbyDialect.class;
196+
case DERBY -> org.hibernate.dialect.DerbyDialect.class;
199197
case H2 -> H2Dialect.class;
200198
case HANA -> HANAColumnStoreDialect.class;
201199
case HSQL -> HSQLDialect.class;
202200
case MYSQL -> MySQL57Dialect.class;
203201
case ORACLE -> Oracle12cDialect.class;
204-
case POSTGRESQL -> PostgreSQLDialect.class;
202+
case POSTGRESQL -> org.hibernate.dialect.PostgreSQLDialect.class;
205203
case SQL_SERVER -> SQLServer2012Dialect.class;
206204
case SYBASE -> SybaseDialect.class;
207205
default -> null;

spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/RouterFunctionMapping.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import org.springframework.http.server.reactive.observation.ServerRequestObservationContext;
3030
import org.springframework.lang.Nullable;
3131
import org.springframework.util.CollectionUtils;
32-
import org.springframework.web.filter.reactive.ServerHttpObservationFilter;
3332
import org.springframework.web.reactive.function.server.HandlerFunction;
3433
import org.springframework.web.reactive.function.server.RouterFunction;
3534
import org.springframework.web.reactive.function.server.RouterFunctions;
@@ -172,7 +171,8 @@ private void setAttributes(
172171
PathPattern matchingPattern = (PathPattern) attributes.get(RouterFunctions.MATCHING_PATTERN_ATTRIBUTE);
173172
if (matchingPattern != null) {
174173
attributes.put(BEST_MATCHING_PATTERN_ATTRIBUTE, matchingPattern);
175-
ServerHttpObservationFilter.findObservationContext(serverRequest.exchange())
174+
org.springframework.web.filter.reactive.ServerHttpObservationFilter
175+
.findObservationContext(serverRequest.exchange())
176176
.ifPresent(context -> context.setPathPattern(matchingPattern.toString()));
177177
ServerRequestObservationContext.findCurrent(serverRequest.exchange())
178178
.ifPresent(context -> context.setPathPattern(matchingPattern.toString()));

spring-webflux/src/main/java/org/springframework/web/reactive/handler/AbstractUrlHandlerMapping.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.springframework.lang.Nullable;
3232
import org.springframework.util.Assert;
3333
import org.springframework.util.StringUtils;
34-
import org.springframework.web.filter.reactive.ServerHttpObservationFilter;
3534
import org.springframework.web.server.ServerWebExchange;
3635
import org.springframework.web.util.pattern.PathPattern;
3736

@@ -168,7 +167,8 @@ protected Object lookupHandler(PathContainer lookupPath, ServerWebExchange excha
168167

169168
exchange.getAttributes().put(BEST_MATCHING_HANDLER_ATTRIBUTE, handler);
170169
exchange.getAttributes().put(BEST_MATCHING_PATTERN_ATTRIBUTE, pattern);
171-
ServerHttpObservationFilter.findObservationContext(exchange)
170+
org.springframework.web.filter.reactive.ServerHttpObservationFilter
171+
.findObservationContext(exchange)
172172
.ifPresent(context -> context.setPathPattern(pattern.toString()));
173173
ServerRequestObservationContext.findCurrent(exchange)
174174
.ifPresent(context -> context.setPathPattern(pattern.toString()));

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMapping.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.springframework.util.CollectionUtils;
4141
import org.springframework.util.MultiValueMap;
4242
import org.springframework.web.bind.annotation.RequestMethod;
43-
import org.springframework.web.filter.reactive.ServerHttpObservationFilter;
4443
import org.springframework.web.method.HandlerMethod;
4544
import org.springframework.web.reactive.HandlerMapping;
4645
import org.springframework.web.reactive.result.condition.NameValueExpression;
@@ -143,7 +142,8 @@ protected void handleMatch(RequestMappingInfo info, HandlerMethod handlerMethod,
143142

144143
exchange.getAttributes().put(BEST_MATCHING_HANDLER_ATTRIBUTE, handlerMethod);
145144
exchange.getAttributes().put(BEST_MATCHING_PATTERN_ATTRIBUTE, bestPattern);
146-
ServerHttpObservationFilter.findObservationContext(exchange)
145+
org.springframework.web.filter.reactive.ServerHttpObservationFilter
146+
.findObservationContext(exchange)
147147
.ifPresent(context -> context.setPathPattern(bestPattern.toString()));
148148
ServerRequestObservationContext.findCurrent(exchange)
149149
.ifPresent(context -> context.setPathPattern(bestPattern.toString()));

spring-webflux/src/test/java/org/springframework/web/reactive/function/server/support/RouterFunctionMappingTests.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
2424
import org.springframework.http.codec.ServerCodecConfigurer;
2525
import org.springframework.http.server.reactive.observation.ServerRequestObservationContext;
26-
import org.springframework.web.filter.reactive.ServerHttpObservationFilter;
2726
import org.springframework.web.reactive.HandlerMapping;
2827
import org.springframework.web.reactive.function.server.HandlerFunction;
2928
import org.springframework.web.reactive.function.server.RouterFunction;
@@ -136,7 +135,7 @@ void mappedRequestShouldHoldAttributes() {
136135
PathPattern matchingPattern = exchange.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE);
137136
assertThat(matchingPattern).isNotNull();
138137
assertThat(matchingPattern.getPatternString()).isEqualTo("/match");
139-
assertThat(ServerHttpObservationFilter.findObservationContext(exchange))
138+
assertThat(org.springframework.web.filter.reactive.ServerHttpObservationFilter.findObservationContext(exchange))
140139
.hasValueSatisfying(context -> assertThat(context.getPathPattern()).isEqualTo(matchingPattern.getPatternString()));
141140
assertThat(ServerRequestObservationContext.findCurrent(exchange))
142141
.hasValueSatisfying(context -> assertThat(context.getPathPattern()).isEqualTo(matchingPattern.getPatternString()));
@@ -152,7 +151,7 @@ void mappedRequestShouldHoldAttributes() {
152151
private ServerWebExchange createExchange(String urlTemplate) {
153152
MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get(urlTemplate));
154153
ServerRequestObservationContext observationContext = new ServerRequestObservationContext(exchange.getRequest(), exchange.getResponse(), exchange.getAttributes());
155-
exchange.getAttributes().put(ServerHttpObservationFilter.CURRENT_OBSERVATION_CONTEXT_ATTRIBUTE, observationContext);
154+
exchange.getAttributes().put(org.springframework.web.filter.reactive.ServerHttpObservationFilter.CURRENT_OBSERVATION_CONTEXT_ATTRIBUTE, observationContext);
156155
exchange.getAttributes().put(ServerRequestObservationContext.CURRENT_OBSERVATION_CONTEXT_ATTRIBUTE, observationContext);
157156
return exchange;
158157
}

0 commit comments

Comments
 (0)