Fix broken RequestMappingHandlerAdapter setter

nertzy · rstoyanchev · commit f4ef5cd451a8 · 2017-09-12T15:04:33.000-04:00
RequestMappingHandlerAdapter.setReactiveRegistry() doesn't actually set the value appropriately. FYI: I found this using lgtm.com https://lgtm.com/projects/g/spring-projects/spring-framework/alerts/?mode=list
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java
@@ -430,7 +430,7 @@ public void setDeferredResultInterceptors(List<DeferredResultProcessingIntercept
 	 */
 	public void setReactiveRegistry(ReactiveAdapterRegistry reactiveRegistry) {
 		Assert.notNull(reactiveRegistry, "ReactiveAdapterRegistry is required");
-		this.reactiveRegistry = this.reactiveRegistry;
+		this.reactiveRegistry = reactiveRegistry;
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -430,7 +430,7 @@ public void setDeferredResultInterceptors(List<DeferredResultProcessingIntercept`
`430`	`430`	`*/`
`431`	`431`	`public void setReactiveRegistry(ReactiveAdapterRegistry reactiveRegistry) {`
`432`	`432`	`Assert.notNull(reactiveRegistry, "ReactiveAdapterRegistry is required");`
`433`		`- this.reactiveRegistry = this.reactiveRegistry;`
	`433`	`+ this.reactiveRegistry = reactiveRegistry;`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`/**`