Skip to content

Commit f33578e

Browse files
committed
Fix failing test and warings
The test failure was caused by the previous commit. The Message resolver now supports payload conversion so it can raise a MessageConversionException, not MethodArgumentTypeMismatchException.
1 parent c411788 commit f33578e

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

spring-jms/src/test/java/org/springframework/jms/config/MethodJmsListenerEndpointTests.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,18 @@
5757
import org.springframework.messaging.handler.annotation.Payload;
5858
import org.springframework.messaging.handler.annotation.SendTo;
5959
import org.springframework.messaging.handler.annotation.support.DefaultMessageHandlerMethodFactory;
60-
import org.springframework.messaging.handler.annotation.support.MethodArgumentTypeMismatchException;
6160
import org.springframework.util.ReflectionUtils;
6261
import org.springframework.validation.Errors;
6362
import org.springframework.validation.Validator;
6463
import org.springframework.validation.annotation.Validated;
6564

66-
import static org.junit.Assert.*;
67-
import static org.mockito.BDDMockito.*;
65+
import static org.junit.Assert.assertEquals;
66+
import static org.junit.Assert.assertNotNull;
67+
import static org.junit.Assert.assertSame;
68+
import static org.junit.Assert.assertTrue;
69+
import static org.mockito.BDDMockito.given;
70+
import static org.mockito.BDDMockito.mock;
71+
import static org.mockito.BDDMockito.verify;
6872

6973
/**
7074
* @author Stephane Nicoll
@@ -407,7 +411,7 @@ public void invalidMessagePayloadType() throws JMSException {
407411
Session session = mock(Session.class);
408412

409413
thrown.expect(ListenerExecutionFailedException.class);
410-
thrown.expectCause(Matchers.isA(MethodArgumentTypeMismatchException.class));
414+
thrown.expectCause(Matchers.isA(MessageConversionException.class));
411415
listener.onMessage(createSimpleJmsTextMessage("test"), session); // Message<String> as Message<Integer>
412416
}
413417

@@ -478,10 +482,10 @@ private Method getTestMethod() {
478482
}
479483

480484

481-
@SendTo("defaultReply")
485+
@SendTo("defaultReply") @SuppressWarnings("unused")
482486
static class JmsEndpointSampleBean {
483487

484-
private final Map<String, Boolean> invocations = new HashMap<String, Boolean>();
488+
private final Map<String, Boolean> invocations = new HashMap<>();
485489

486490
public void resolveMessageAndSession(javax.jms.Message message, Session session) {
487491
invocations.put("resolveMessageAndSession", true);

0 commit comments

Comments
 (0)