Skip to content

Commit b33d8c6

Browse files
authored
Merge pull request #1467 from violetagg/deferred-result-handle-error
Polish - the flag continueProcessing is not needed
2 parents 5f4d1a4 + 5f020d1 commit b33d8c6

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,22 +292,20 @@ public <S> boolean handleTimeout(NativeWebRequest request, DeferredResult<S> def
292292
}
293293
@Override
294294
public <S> boolean handleError(NativeWebRequest request, DeferredResult<S> deferredResult, Throwable t) {
295-
boolean continueProcessing = true;
296295
try {
297296
if (errorCallback != null) {
298297
errorCallback.accept(t);
299298
}
300299
}
301300
finally {
302-
continueProcessing = false;
303301
try {
304302
setResultInternal(t);
305303
}
306304
catch (Throwable ex) {
307305
logger.debug("Failed to handle error result", ex);
308306
}
309307
}
310-
return continueProcessing;
308+
return false;
311309
}
312310
@Override
313311
public <S> void afterCompletion(NativeWebRequest request, DeferredResult<S> deferredResult) {

0 commit comments

Comments
 (0)