Send error signal also for empty server responses

Prior to that commit, the `ResponseSpec` `WebClient` would process error
responses (4xx, 5xx HTTP status) and transform those into error signals
with a `WebClientResponseException`. But this would only work if the
HTTP response would have a non-empty response body.

An empty error response would not send an error signal and only
translate in an `onComplete` signal.

This commit fixes this behavior and makes sure that this error signal is
sent in all cases.

Issue: SPR-15946

Author: bclozel

spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java

@@ -483,6 +483,7 @@ private static Mono<WebClientResponseException> createResponseException(ClientRe
 						DataBufferUtils.release(dataBuffer);
 						return bytes;
 					})
+					.defaultIfEmpty(new byte[0])
 					.map(bodyBytes -> {
 						String msg = String.format("ClientResponse has erroneous status code: %d %s", response.statusCode().value(),
 								response.statusCode().getReasonPhrase());

spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java

@@ -377,6 +377,26 @@ public void shouldGetErrorSignalOn404() throws Exception {
 		});
 	}
 
+	@Test // SPR-15946
+	public void shouldGetErrorSignalOnEmptyErrorResponse() throws Exception {
+		prepareResponse(response -> response.setResponseCode(404)
+				.setHeader("Content-Type", "text/plain"));
+
+		Mono<String> result = this.webClient.get().uri("/greeting")
+				.retrieve()
+				.bodyToMono(String.class);
+
+		StepVerifier.create(result)
+				.expectError(WebClientException.class)
+				.verify(Duration.ofSeconds(3));
+
+		expectRequestCount(1);
+		expectRequest(request -> {
+			assertEquals("*/*", request.getHeader(HttpHeaders.ACCEPT));
+			assertEquals("/greeting", request.getPath());
+		});
+	}
+
 	@Test
 	public void shouldGetInternalServerErrorSignal() throws Exception {
 		String errorMessage = "Internal Server error";
@@ -473,9 +493,7 @@ public void shouldApplyExchangeFilter() throws Exception {
 				.verify(Duration.ofSeconds(3));
 
 		expectRequestCount(1);
-		expectRequest(request -> {
-			assertEquals("bar", request.getHeader("foo"));
-		});
+		expectRequest(request -> assertEquals("bar", request.getHeader("foo")));
 	}
 
 	@Test
@@ -563,7 +581,7 @@ private void expectRequestCount(int count) {
 	@SuppressWarnings("serial")
 	private static class MyException extends RuntimeException {
 
-		public MyException(String message) {
+		MyException(String message) {
 			super(message);
 		}
 	}