Delete temporary MethodParameterFactory solution

SPR-14055 introduced first-class support for the Java 8 Parameter API.

This commit therefore replaces the MethodParameterFactory with use of
the new SynthesizingMethodParameter.forParameter(Parameter) factory
method.

Issue: SPR-13575

Author: sbrannen

spring-test/src/main/java/org/springframework/test/context/junit/jupiter/MethodParameterFactory.java

@@ -18,7 +18,6 @@
 
 import java.lang.annotation.Annotation;
 import java.lang.reflect.AnnotatedElement;
-import java.lang.reflect.Method;
 import java.lang.reflect.Parameter;
 import java.util.Optional;
 
@@ -31,13 +30,13 @@
 import org.springframework.context.ApplicationContext;
 import org.springframework.core.MethodParameter;
 import org.springframework.core.annotation.AnnotatedElementUtils;
+import org.springframework.core.annotation.SynthesizingMethodParameter;
 
 /**
  * Collection of utilities related to autowiring of individual method parameters.
  *
  * @author Sam Brannen
  * @since 5.0
- * @see MethodParameterFactory
  * @see #isAutowirable(Parameter)
  * @see #resolveDependency(Parameter, Class, ApplicationContext)
  */
@@ -86,25 +85,18 @@ static boolean isAutowirable(Parameter parameter) {
 	 * @throws BeansException if dependency resolution failed
 	 * @see #isAutowirable(Parameter)
 	 * @see Autowired#required
-	 * @see MethodParameterFactory#createSynthesizingMethodParameter(Parameter)
+	 * @see SynthesizingMethodParameter#forParameter(Parameter)
 	 * @see AutowireCapableBeanFactory#resolveDependency(DependencyDescriptor, String)
 	 */
-	static Object resolveDependency(Parameter parameter, Class<?> containingClass,
-			ApplicationContext applicationContext) {
-
+	static Object resolveDependency(Parameter parameter, Class<?> containingClass, ApplicationContext applicationContext) {
 		boolean required = findMergedAnnotation(parameter, Autowired.class).map(Autowired::required).orElse(true);
-		MethodParameter methodParameter = (parameter.getDeclaringExecutable() instanceof Method
-				? MethodParameterFactory.createSynthesizingMethodParameter(parameter)
-				: MethodParameterFactory.createMethodParameter(parameter));
+		MethodParameter methodParameter = SynthesizingMethodParameter.forParameter(parameter);
 		DependencyDescriptor descriptor = new DependencyDescriptor(methodParameter, required);
 		descriptor.setContainingClass(containingClass);
-
 		return applicationContext.getAutowireCapableBeanFactory().resolveDependency(descriptor, null);
 	}
 
-	private static <A extends Annotation> Optional<A> findMergedAnnotation(AnnotatedElement element,
-			Class<A> annotationType) {
-
+	private static <A extends Annotation> Optional<A> findMergedAnnotation(AnnotatedElement element, Class<A> annotationType) {
 		return Optional.ofNullable(AnnotatedElementUtils.findMergedAnnotation(element, annotationType));
 	}