Skip to content

Commit 5890758

Browse files
committed
Avoid canonicalName call for already-seen bean name
Issue: SPR-14433
1 parent 76dedd7 commit 5890758

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,10 +449,10 @@ protected boolean isDependent(String beanName, String dependentBeanName) {
449449
}
450450

451451
private boolean isDependent(String beanName, String dependentBeanName, Set<String> alreadySeen) {
452-
String canonicalName = canonicalName(beanName);
453452
if (alreadySeen != null && alreadySeen.contains(beanName)) {
454453
return false;
455454
}
455+
String canonicalName = canonicalName(beanName);
456456
Set<String> dependentBeans = this.dependentBeanMap.get(canonicalName);
457457
if (dependentBeans == null) {
458458
return false;

0 commit comments

Comments
 (0)