Polishing

Author: jhoeller

spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java

@@ -108,7 +108,7 @@ public long getSendTimeout() {
 	public void send(Message<?> message) {
 		SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message);
 		String destination = headers.getDestination();
-		destination = (destination != null) ? destination : getRequiredDefaultDestination();
+		destination = (destination != null ? destination : getRequiredDefaultDestination());
 		doSend(destination, message);
 	}
 
@@ -131,7 +131,6 @@ protected void doSend(String destination, Message<?> message) {
 	}
 
 
-
 	@Override
 	public void convertAndSendToUser(String user, String destination, Object payload) throws MessagingException {
 		convertAndSendToUser(user, destination, payload, (MessagePostProcessor) null);
@@ -160,6 +159,7 @@ public void convertAndSendToUser(String user, String destination, Object payload
 		super.convertAndSend(this.userDestinationPrefix + user + destination, payload, headers, postProcessor);
 	}
 
+
 	/**
 	 * Creates a new map and puts the given headers under the key
 	 * {@link org.springframework.messaging.support.NativeMessageHeaderAccessor#NATIVE_HEADERS NATIVE_HEADERS}.

spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpInputMessage;
 import org.springframework.http.HttpOutputMessage;
@@ -169,11 +170,12 @@ public final void write(final T t, MediaType contentType, HttpOutputMessage outp
 
 		final HttpHeaders headers = outputMessage.getHeaders();
 		if (headers.getContentType() == null) {
+			MediaType contentTypeToUse = contentType;
 			if (contentType == null || contentType.isWildcardType() || contentType.isWildcardSubtype()) {
-				contentType = getDefaultContentType(t);
+				contentTypeToUse = getDefaultContentType(t);
 			}
-			if (contentType != null) {
-				headers.setContentType(contentType);
+			if (contentTypeToUse != null) {
+				headers.setContentType(contentTypeToUse);
 			}
 		}
 		if (headers.getContentLength() == -1) {
@@ -182,10 +184,10 @@ public final void write(final T t, MediaType contentType, HttpOutputMessage outp
 				headers.setContentLength(contentLength);
 			}
 		}
+
 		if (outputMessage instanceof StreamingHttpOutputMessage) {
 			StreamingHttpOutputMessage streamingOutputMessage =
 					(StreamingHttpOutputMessage) outputMessage;
-
 			streamingOutputMessage.setBody(new StreamingHttpOutputMessage.Body() {
 				@Override
 				public void writeTo(final OutputStream outputStream) throws IOException {
@@ -194,7 +196,6 @@ public void writeTo(final OutputStream outputStream) throws IOException {
 						public OutputStream getBody() throws IOException {
 							return outputStream;
 						}
-
 						@Override
 						public HttpHeaders getHeaders() {
 							return headers;
@@ -256,7 +257,7 @@ protected abstract T readInternal(Class<? extends T> clazz, HttpInputMessage inp
 	/**
 	 * Abstract template method that writes the actual body. Invoked from {@link #write}.
 	 * @param t the object to write to the output message
-	 * @param outputMessage the message to write to
+	 * @param outputMessage the HTTP output message to write to
 	 * @throws IOException in case of I/O errors
 	 * @throws HttpMessageNotWritableException in case of conversion errors
 	 */