Polish WebSocketHttpRequestHandler

Author: rstoyanchev

build.gradle

@@ -505,6 +505,7 @@ project("spring-websocket") {
 		compile(project(":spring-core"))
 		compile(project(":spring-context"))
 		compile(project(":spring-web"))
+		optional(project(":spring-webmvc"))
 		optional("javax.servlet:javax.servlet-api:3.1.0")
 		optional("javax.websocket:javax.websocket-api:1.0")
 		optional("org.apache.tomcat:tomcat-websocket:8.0-SNAPSHOT") {

spring-websocket/src/main/java/org/springframework/web/socket/server/support/WebSocketHttpRequestHandler.java

@@ -49,7 +49,7 @@
  * {@link HttpServletResponse} to {@link ServerHttpRequest} and {@link ServerHttpResponse}
  * respectively.
  *
- * <p>The {@link #decorateWebSocketHandler(WebSocketHandler)} method decorates the given
+ * <p>The {@link #applyDefaultDecorators(WebSocketHandler)} method decorates the given
  * WebSocketHandler with a logging and exception handling decorators. This method can
  * be overridden to change that.
  *
@@ -69,10 +69,10 @@ public WebSocketHttpRequestHandler(WebSocketHandler webSocketHandler) {
 		this(webSocketHandler, new DefaultHandshakeHandler());
 	}
 
-	public WebSocketHttpRequestHandler(	WebSocketHandler webSocketHandler, HandshakeHandler handshakeHandler) {
-		Assert.notNull(webSocketHandler, "webSocketHandler must not be null");
+	public WebSocketHttpRequestHandler(WebSocketHandler wsHandler, HandshakeHandler handshakeHandler) {
+		Assert.notNull(wsHandler, "wsHandler must not be null");
 		Assert.notNull(handshakeHandler, "handshakeHandler must not be null");
-		this.wsHandler = decorateWebSocketHandler(webSocketHandler);
+		this.wsHandler = new ExceptionWebSocketHandlerDecorator(new LoggingWebSocketHandlerDecorator(wsHandler));
 		this.handshakeHandler = handshakeHandler;
 	}
 
@@ -94,17 +94,6 @@ public List<HandshakeInterceptor> getHandshakeInterceptors() {
 		return this.interceptors;
 	}
 
-	/**
-	 * Decorate the WebSocketHandler provided to the class constructor.
-	 *
-	 * <p>By default {@link ExceptionWebSocketHandlerDecorator} and
-	 * {@link LoggingWebSocketHandlerDecorator} are applied are added.
-	 */
-	protected WebSocketHandler decorateWebSocketHandler(WebSocketHandler wsHandler) {
-		wsHandler = new ExceptionWebSocketHandlerDecorator(wsHandler);
-		return new LoggingWebSocketHandlerDecorator(wsHandler);
-	}
-
 	@Override
 	public void handleRequest(HttpServletRequest servletRequest, HttpServletResponse servletResponse)
 			throws ServletException, IOException {

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/SockJsHttpRequestHandler.java

@@ -55,21 +55,10 @@ public SockJsHttpRequestHandler(SockJsService sockJsService, WebSocketHandler ws
 		Assert.notNull(sockJsService, "sockJsService must not be null");
 		Assert.notNull(wsHandler, "webSocketHandler must not be null");
 		this.sockJsService = sockJsService;
-		this.wsHandler = decorateWebSocketHandler(wsHandler);
+		this.wsHandler = new ExceptionWebSocketHandlerDecorator(new LoggingWebSocketHandlerDecorator(wsHandler));
 	}
 
 
-	/**
-	 * Decorate the WebSocketHandler provided to the class constructor.
-	 *
-	 * <p>By default {@link ExceptionWebSocketHandlerDecorator} and
-	 * {@link LoggingWebSocketHandlerDecorator} are applied are added.
-	 */
-	protected WebSocketHandler decorateWebSocketHandler(WebSocketHandler wsHandler) {
-		wsHandler = new ExceptionWebSocketHandlerDecorator(wsHandler);
-		return new LoggingWebSocketHandlerDecorator(wsHandler);
-	}
-
 	@Override
 	public void handleRequest(HttpServletRequest servletRequest, HttpServletResponse servletResponse)
 			throws ServletException, IOException {