Skip to content

Commit 31a07e6

Browse files
committed
User AssertJ assertions
1 parent ef01a07 commit 31a07e6

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

spring-core/src/test/java/org/springframework/util/MultiValueMapTests.java

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
import java.util.Map;
2626
import java.util.stream.Stream;
2727

28-
import org.junit.jupiter.api.Assertions;
2928
import org.junit.jupiter.params.ParameterizedTest;
3029
import org.junit.jupiter.params.provider.Arguments;
3130
import org.junit.jupiter.params.provider.MethodSource;
3231

3332
import static org.assertj.core.api.Assertions.assertThat;
33+
import static org.assertj.core.api.SoftAssertions.assertSoftly;
3434
import static org.junit.jupiter.api.Named.named;
3535
import static org.junit.jupiter.params.provider.Arguments.arguments;
3636

@@ -142,27 +142,28 @@ void equalsOnEmpty(MultiValueMap<String, String> map) {
142142
@ParameterizedMultiValueMapTest
143143
void canNotChangeAnUnmodifiableMultiValueMap(MultiValueMap<String, String> map) {
144144
MultiValueMap<String, String> asUnmodifiableMultiValueMap = CollectionUtils.unmodifiableMultiValueMap(map);
145-
Assertions.assertAll(
146-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
147-
() -> asUnmodifiableMultiValueMap.add("key", "value")),
148-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
149-
() -> asUnmodifiableMultiValueMap.addIfAbsent("key", "value")),
150-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
151-
() -> asUnmodifiableMultiValueMap.addAll("key", exampleListOfValues())),
152-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
153-
() -> asUnmodifiableMultiValueMap.addAll(exampleMultiValueMap())),
154-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
155-
() -> asUnmodifiableMultiValueMap.set("key", "value")),
156-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
157-
() -> asUnmodifiableMultiValueMap.setAll(exampleHashMap())),
158-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
159-
() -> asUnmodifiableMultiValueMap.put("key", exampleListOfValues())),
160-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
161-
() -> asUnmodifiableMultiValueMap.putIfAbsent("key", exampleListOfValues())),
162-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
163-
() -> asUnmodifiableMultiValueMap.putAll(exampleMultiValueMap())),
164-
() -> Assertions.assertThrows(UnsupportedOperationException.class,
165-
() -> asUnmodifiableMultiValueMap.remove("key1")));
145+
assertSoftly(softly -> {
146+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
147+
.isThrownBy(() -> asUnmodifiableMultiValueMap.add("key", "value"));
148+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
149+
.isThrownBy(() -> asUnmodifiableMultiValueMap.addIfAbsent("key", "value"));
150+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
151+
.isThrownBy(() -> asUnmodifiableMultiValueMap.addAll("key", exampleListOfValues()));
152+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
153+
.isThrownBy(() -> asUnmodifiableMultiValueMap.addAll(exampleMultiValueMap()));
154+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
155+
.isThrownBy(() -> asUnmodifiableMultiValueMap.set("key", "value"));
156+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
157+
.isThrownBy(() -> asUnmodifiableMultiValueMap.setAll(exampleHashMap()));
158+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
159+
.isThrownBy(() -> asUnmodifiableMultiValueMap.put("key", exampleListOfValues()));
160+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
161+
.isThrownBy(() -> asUnmodifiableMultiValueMap.putIfAbsent("key", exampleListOfValues()));
162+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
163+
.isThrownBy(() -> asUnmodifiableMultiValueMap.putAll(exampleMultiValueMap()));
164+
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
165+
.isThrownBy(() -> asUnmodifiableMultiValueMap.remove("key1"));
166+
});
166167
}
167168

168169
private static List<String> exampleListOfValues() {

0 commit comments

Comments
 (0)