Fix condition in SubProtocolWebSocketHandler

Issue: SPR-11884

Author: rstoyanchev

spring-websocket/src/main/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandler.java

@@ -70,7 +70,7 @@ public class SubProtocolWebSocketHandler implements WebSocketHandler,
 	 * connection isn't doing well (proxy issue, slow network?) and can be closed.
 	 * @see #checkSessions()
 	 */
-	private final int TIME_TO_FIRST_MESSAGE = 60 * 1000;
+	private static final int TIME_TO_FIRST_MESSAGE = 60 * 1000;
 
 
 	private final Log logger = LogFactory.getLog(SubProtocolWebSocketHandler.class);
@@ -298,10 +298,6 @@ public void handleMessage(WebSocketSession session, WebSocketMessage<?> message)
 		if (holder != null) {
 			holder.setHasHandledMessages();
 		}
-		else {
-			// Should never happen
-			throw new IllegalStateException("Session not found: " + session);
-		}
 		checkSessions();
 	}
 
@@ -366,7 +362,7 @@ private String resolveSessionId(Message<?> message) {
 	 */
 	private void checkSessions() throws IOException {
 		long currentTime = System.currentTimeMillis();
-		if (!isRunning() && currentTime - this.lastSessionCheckTime < TIME_TO_FIRST_MESSAGE) {
+		if (!isRunning() || (currentTime - this.lastSessionCheckTime < TIME_TO_FIRST_MESSAGE)) {
 			return;
 		}
 		if (this.sessionCheckLock.tryLock()) {
@@ -376,7 +372,7 @@ private void checkSessions() throws IOException {
 						continue;
 					}
 					long timeSinceCreated = currentTime - holder.getCreateTime();
-					if (holder.hasHandledMessages() || timeSinceCreated < TIME_TO_FIRST_MESSAGE) {
+					if (timeSinceCreated < TIME_TO_FIRST_MESSAGE) {
 						continue;
 					}
 					WebSocketSession session = holder.getSession();

spring-websocket/src/test/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandlerTests.java

@@ -165,6 +165,7 @@ public void checkSession() throws Exception {
 		new DirectFieldAccessor(sessions.get("id1")).setPropertyValue("createTime", sixtyOneSecondsAgo);
 		new DirectFieldAccessor(sessions.get("id2")).setPropertyValue("createTime", sixtyOneSecondsAgo);
 
+		this.webSocketHandler.start();
 		this.webSocketHandler.handleMessage(session1, new TextMessage("foo"));
 
 		assertTrue(session1.isOpen());