diff --git a/pom.xml b/pom.xml
index f6359158d4..55926fb2cd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
org.springframework.data
spring-data-relational-parent
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
pom
Spring Data Relational Parent
diff --git a/spring-data-jdbc-distribution/pom.xml b/spring-data-jdbc-distribution/pom.xml
index 858a5f4b4b..c2dd9c133f 100644
--- a/spring-data-jdbc-distribution/pom.xml
+++ b/spring-data-jdbc-distribution/pom.xml
@@ -14,7 +14,7 @@
org.springframework.data
spring-data-relational-parent
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
../pom.xml
diff --git a/spring-data-jdbc/pom.xml b/spring-data-jdbc/pom.xml
index 1fdf3e615a..6a91420907 100644
--- a/spring-data-jdbc/pom.xml
+++ b/spring-data-jdbc/pom.xml
@@ -6,7 +6,7 @@
4.0.0
spring-data-jdbc
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
Spring Data JDBC
Spring Data module for JDBC repositories.
@@ -15,7 +15,7 @@
org.springframework.data
spring-data-relational-parent
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
diff --git a/spring-data-relational/pom.xml b/spring-data-relational/pom.xml
index 0a529399c3..aac777ce90 100644
--- a/spring-data-relational/pom.xml
+++ b/spring-data-relational/pom.xml
@@ -6,7 +6,7 @@
4.0.0
spring-data-relational
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
Spring Data Relational
Spring Data Relational support
@@ -14,7 +14,7 @@
org.springframework.data
spring-data-relational-parent
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJDBC-518-SNAPSHOT
diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/Criteria.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/Criteria.java
index 39c1ebec77..7672e6a645 100644
--- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/Criteria.java
+++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/Criteria.java
@@ -51,6 +51,7 @@
* @author Mark Paluch
* @author Oliver Drotbohm
* @author Roman Chigvintsev
+ * @author Jens Schauder
* @since 2.0
*/
public class Criteria implements CriteriaDefinition {
@@ -59,7 +60,7 @@ public class Criteria implements CriteriaDefinition {
private final @Nullable Criteria previous;
private final Combinator combinator;
- private final List group;
+ private final List group;
private final @Nullable SqlIdentifier column;
private final @Nullable Comparator comparator;
@@ -70,12 +71,12 @@ private Criteria(SqlIdentifier column, Comparator comparator, @Nullable Object v
this(null, Combinator.INITIAL, Collections.emptyList(), column, comparator, value, false);
}
- private Criteria(@Nullable Criteria previous, Combinator combinator, List group,
+ private Criteria(@Nullable Criteria previous, Combinator combinator, List group,
@Nullable SqlIdentifier column, @Nullable Comparator comparator, @Nullable Object value) {
this(previous, combinator, group, column, comparator, value, false);
}
- private Criteria(@Nullable Criteria previous, Combinator combinator, List group,
+ private Criteria(@Nullable Criteria previous, Combinator combinator, List group,
@Nullable SqlIdentifier column, @Nullable Comparator comparator, @Nullable Object value, boolean ignoreCase) {
this.previous = previous;
@@ -87,7 +88,7 @@ private Criteria(@Nullable Criteria previous, Combinator combinator, List group) {
+ private Criteria(@Nullable Criteria previous, Combinator combinator, List group) {
this.previous = previous;
this.combinator = previous != null && previous.isEmpty() ? Combinator.INITIAL : combinator;
@@ -112,7 +113,7 @@ public static Criteria empty() {
*
* @return new {@link Criteria}.
*/
- public static Criteria from(Criteria... criteria) {
+ public static CriteriaDefinition from(CriteriaDefinition... criteria) {
Assert.notNull(criteria, "Criteria must not be null");
Assert.noNullElements(criteria, "Criteria must not contain null elements");
@@ -125,7 +126,7 @@ public static Criteria from(Criteria... criteria) {
*
* @return new {@link Criteria}.
*/
- public static Criteria from(List criteria) {
+ public static CriteriaDefinition from(List criteria) {
Assert.notNull(criteria, "Criteria must not be null");
Assert.noNullElements(criteria, "Criteria must not contain null elements");
@@ -180,7 +181,7 @@ protected Criteria createCriteria(Comparator comparator, Object value) {
* @return a new {@link Criteria} object.
* @since 1.1
*/
- public Criteria and(Criteria criteria) {
+ public Criteria and(CriteriaDefinition criteria) {
Assert.notNull(criteria, "Criteria must not be null!");
@@ -192,9 +193,8 @@ public Criteria and(Criteria criteria) {
*
* @param criteria criteria objects.
* @return a new {@link Criteria} object.
- * @since 1.1
*/
- public Criteria and(List criteria) {
+ public Criteria and(List criteria) {
Assert.notNull(criteria, "Criteria must not be null!");
@@ -227,7 +227,7 @@ protected Criteria createCriteria(Comparator comparator, Object value) {
* @return a new {@link Criteria} object.
* @since 1.1
*/
- public Criteria or(Criteria criteria) {
+ public Criteria or(CriteriaDefinition criteria) {
Assert.notNull(criteria, "Criteria must not be null!");
@@ -241,7 +241,7 @@ public Criteria or(Criteria criteria) {
* @return a new {@link Criteria} object.
* @since 1.1
*/
- public Criteria or(List criteria) {
+ public Criteria or(List criteria) {
Assert.notNull(criteria, "Criteria must not be null!");
@@ -312,7 +312,7 @@ private boolean doIsEmpty() {
return false;
}
- for (Criteria criteria : group) {
+ for (CriteriaDefinition criteria : group) {
if (!criteria.isEmpty()) {
return false;
@@ -336,7 +336,7 @@ public Combinator getCombinator() {
return combinator;
}
- public List getGroup() {
+ public List getGroup() {
return group;
}
diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/CriteriaDefinition.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/CriteriaDefinition.java
index a0c3375020..a0073edcd3 100644
--- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/CriteriaDefinition.java
+++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/query/CriteriaDefinition.java
@@ -27,6 +27,7 @@
* represent a group of nested criteria objects.
*
* @author Mark Paluch
+ * @author Jens Schauder
* @since 2.0
*/
public interface CriteriaDefinition {
@@ -45,7 +46,7 @@ static CriteriaDefinition empty() {
*
* @return new {@link Criteria}.
*/
- static CriteriaDefinition from(Criteria... criteria) {
+ static CriteriaDefinition from(CriteriaDefinition... criteria) {
Assert.notNull(criteria, "Criteria must not be null");
Assert.noNullElements(criteria, "Criteria must not contain null elements");
@@ -59,7 +60,7 @@ static CriteriaDefinition from(Criteria... criteria) {
* @return new {@link Criteria}.
* @since 1.1
*/
- static CriteriaDefinition from(List criteria) {
+ static CriteriaDefinition from(List criteria) {
Assert.notNull(criteria, "Criteria must not be null");
Assert.noNullElements(criteria, "Criteria must not contain null elements");
@@ -80,7 +81,7 @@ static CriteriaDefinition from(List criteria) {
*/
boolean isGroup();
- List extends CriteriaDefinition> getGroup();
+ List getGroup();
/**
* @return the column/property name.
diff --git a/spring-data-relational/src/test/java/org/springframework/data/relational/core/query/CriteriaUnitTests.java b/spring-data-relational/src/test/java/org/springframework/data/relational/core/query/CriteriaUnitTests.java
index 282156fc57..944fc5abda 100644
--- a/spring-data-relational/src/test/java/org/springframework/data/relational/core/query/CriteriaUnitTests.java
+++ b/spring-data-relational/src/test/java/org/springframework/data/relational/core/query/CriteriaUnitTests.java
@@ -39,7 +39,7 @@ public void fromCriteria() {
Criteria nested1 = where("foo").isNotNull();
Criteria nested2 = where("foo").isNull();
- Criteria criteria = Criteria.from(nested1, nested2);
+ CriteriaDefinition criteria = Criteria.from(nested1, nested2);
assertThat(criteria.isGroup()).isTrue();
assertThat(criteria.getGroup()).containsExactly(nested1, nested2);
@@ -51,7 +51,7 @@ public void fromCriteria() {
public void fromCriteriaOptimized() {
Criteria nested = where("foo").is("bar").and("baz").isNotNull();
- Criteria criteria = Criteria.from(nested);
+ CriteriaDefinition criteria = Criteria.from(nested);
assertThat(criteria).isSameAs(nested).hasToString("foo = 'bar' AND baz IS NOT NULL");
}