Bring back original DataAccessStrategy#insert method signature to maintain backward compatibility.

+ Default implementation of original method will no longer work as expected when the id property of the instance is pre-populated.
+ Deprecate original method.

Author: ctailor2

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DataAccessStrategy.java

@@ -49,9 +49,29 @@ public interface DataAccessStrategy extends RelationResolver {
 	 * @param identifier information about data that needs to be considered for the insert but which is not part of the
 	 *          entity. Namely references back to a parent entity and key/index columns for entities that are stored in a
 	 *          {@link Map} or {@link List}.
-	 * @param includeId an indicator of whether the insert includes the id.
 	 * @return the id generated by the database if any.
 	 * @since 1.1
+	 * @deprecated since 2.4, use {@link #insert(T, Class, Identifier, boolean)}. This will no longer insert as expected
+	 *             when the id property of the instance is pre-populated.
+	 */
+	@Nullable
+	@Deprecated
+	default <T> Object insert(T instance, Class<T> domainType, Identifier identifier) {
+		return insert(instance, domainType, identifier, false);
+	}
+
+	/**
+	 * Inserts the data of a single entity. Referenced entities don't get handled.
+	 *
+	 * @param <T> the type of the instance.
+	 * @param instance the instance to be stored. Must not be {@code null}.
+	 * @param domainType the type of the instance. Must not be {@code null}.
+	 * @param identifier information about data that needs to be considered for the insert but which is not part of the
+	 *          entity. Namely references back to a parent entity and key/index columns for entities that are stored in a
+	 *          {@link Map} or {@link List}.
+	 * @param includeId an indicator of whether the insert includes the id.
+	 * @return the id generated by the database if any.
+	 * @since 2.4
 	 */
 	@Nullable
 	<T> Object insert(T instance, Class<T> domainType, Identifier identifier, boolean includeId);