Stick with current parameter naming for now.

ctailor2 · ctailor2 · commit 9ed9e1be23e6 · 2022-03-02T10:12:15.000-06:00
diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategy.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategy.java
@@ -107,9 +107,7 @@ public <T> Object insert(T instance, Class<T> domainType, Identifier identifier,
 	}
 
 	@Override
-	public <T> Object[] insert(List<RecordDescriptor<T>> recordDescriptors, Class<T> domainType,
-//							   TODO: A better name for this may be the inverse (generatedIdExpected)
-							   boolean includeId) {
+	public <T> Object[] insert(List<RecordDescriptor<T>> recordDescriptors, Class<T> domainType, boolean includeId) {
 
 		SqlIdentifierParameterSource[] sqlParameterSources = recordDescriptors.stream()
 				.map(recordDescriptor -> sqlParametersFactory.getInsert(recordDescriptor.getInstance(), domainType, recordDescriptor.getIdentifier()))

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,7 @@ public <T> Object insert(T instance, Class<T> domainType, Identifier identifier,`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`@Override`
`110`		`- public <T> Object[] insert(List<RecordDescriptor<T>> recordDescriptors, Class<T> domainType,`
`111`		`-// TODO: A better name for this may be the inverse (generatedIdExpected)`
`112`		`- boolean includeId) {`
	`110`	`+ public <T> Object[] insert(List<RecordDescriptor<T>> recordDescriptors, Class<T> domainType, boolean includeId) {`
`113`	`111`
`114`	`112`	`SqlIdentifierParameterSource[] sqlParameterSources = recordDescriptors.stream()`
`115`	`113`	`.map(recordDescriptor -> sqlParametersFactory.getInsert(recordDescriptor.getInstance(), domainType, recordDescriptor.getIdentifier()))`