Skip to content

Commit 809a111

Browse files
committed
DATAJDBC-346: Fixed test failures when using MSSQL database
1 parent 913238a commit 809a111

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/ImmutableAggregateTemplateHsqlIntegrationTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
*/
1616
package org.springframework.data.jdbc.core;
1717

18-
import static java.util.Collections.*;
19-
import static org.assertj.core.api.Assertions.*;
18+
import static java.util.Collections.singletonList;
19+
import static org.assertj.core.api.Assertions.assertThat;
20+
import static org.assertj.core.api.Assertions.tuple;
2021

2122
import lombok.Value;
2223
import lombok.experimental.Wither;
23-
2424
import org.assertj.core.api.SoftAssertions;
2525
import org.junit.ClassRule;
2626
import org.junit.Rule;
@@ -34,6 +34,7 @@
3434
import org.springframework.data.jdbc.testing.TestConfiguration;
3535
import org.springframework.data.relational.core.conversion.RelationalConverter;
3636
import org.springframework.data.relational.core.mapping.RelationalMappingContext;
37+
import org.springframework.test.context.ActiveProfiles;
3738
import org.springframework.test.context.ContextConfiguration;
3839
import org.springframework.test.context.junit4.rules.SpringClassRule;
3940
import org.springframework.test.context.junit4.rules.SpringMethodRule;
@@ -46,6 +47,7 @@
4647
*/
4748
@ContextConfiguration
4849
@Transactional
50+
@ActiveProfiles("hsql")
4951
public class ImmutableAggregateTemplateHsqlIntegrationTests {
5052

5153
@ClassRule public static final SpringClassRule classRule = new SpringClassRule();

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryCrossAggregateHsqlIntegrationTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.data.jdbc.repository;
1717

18-
import static org.assertj.core.api.Assertions.*;
18+
import static org.assertj.core.api.Assertions.assertThat;
1919

2020
import org.junit.ClassRule;
2121
import org.junit.Rule;
@@ -33,6 +33,7 @@
3333
import org.springframework.data.repository.CrudRepository;
3434
import org.springframework.jdbc.core.JdbcTemplate;
3535
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
36+
import org.springframework.test.context.ActiveProfiles;
3637
import org.springframework.test.context.ContextConfiguration;
3738
import org.springframework.test.context.junit4.rules.SpringClassRule;
3839
import org.springframework.test.context.junit4.rules.SpringMethodRule;
@@ -46,6 +47,7 @@
4647
*/
4748
@ContextConfiguration
4849
@Transactional
50+
@ActiveProfiles("hsql")
4951
public class JdbcRepositoryCrossAggregateHsqlIntegrationTests {
5052

5153
private static final long TWO_ID = 23L;

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryWithCollectionsAndManuallyAssignedIdHsqlIntegrationTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import org.springframework.data.relational.core.mapping.event.BeforeSaveEvent;
4141
import org.springframework.data.repository.CrudRepository;
4242
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
43+
import org.springframework.test.context.ActiveProfiles;
4344
import org.springframework.test.context.ContextConfiguration;
4445
import org.springframework.test.context.junit4.rules.SpringClassRule;
4546
import org.springframework.test.context.junit4.rules.SpringMethodRule;
@@ -52,6 +53,7 @@
5253
*/
5354
@ContextConfiguration
5455
@Transactional
56+
@ActiveProfiles("hsql")
5557
public class JdbcRepositoryWithCollectionsAndManuallyAssignedIdHsqlIntegrationTests {
5658

5759
static AtomicLong id = new AtomicLong(0);

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/EnableJdbcAuditingHsqlIntegrationTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,10 @@ private <T, R extends CrudRepository<T, Long>> Consumer<Consumer<R>> configureRe
193193

194194
return (Consumer<R> test) -> {
195195

196-
try (ConfigurableApplicationContext context = new AnnotationConfigApplicationContext(configurationClasses)) {
197-
196+
try (AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext()) {
197+
context.getEnvironment().setActiveProfiles("hsql");
198+
context.register(configurationClasses);
199+
context.refresh();
198200
test.accept(context.getBean(repositoryType));
199201

200202
softly.assertAll();
@@ -236,6 +238,7 @@ static class DummyEntity {
236238

237239
@ComponentScan("org.springframework.data.jdbc.testing")
238240
@EnableJdbcRepositories(considerNestedRepositories = true)
241+
@ActiveProfiles("hsql")
239242
static class TestConfiguration {
240243

241244
@Bean

0 commit comments

Comments
 (0)