From 351d7663775a522438c8746dcd744117d34f6c46 Mon Sep 17 00:00:00 2001
From: jinbeom <kst20026@gamil.com>
Date: Sun, 15 Sep 2024 08:19:15 +0900
Subject: [PATCH 1/3] Refactor DefaultRedisList to Remove Code Duplication.

---
 .../support/collections/DefaultRedisList.java    | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
index 8c9aa5f8d0..4ab522991c 100644
--- a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
+++ b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
@@ -216,16 +216,14 @@ public boolean remove(Object o) {
 	public void add(int index, E element) {
 
 		if (index == 0) {
-			listOps.leftPush(element);
-			cap();
+			addFirst(element);
 			return;
 		}
 
 		int size = size();
 
 		if (index == size()) {
-			listOps.rightPush(element);
-			cap();
+			addLast(element);
 			return;
 		}
 
@@ -245,8 +243,7 @@ public boolean addAll(int index, Collection<? extends E> collection) {
 			Collection<? extends E> reverseCollection = CollectionUtils.reverse(collection);
 
 			for (E element : reverseCollection) {
-				listOps.leftPush(element);
-				cap();
+				addFirst(element);
 			}
 
 			return true;
@@ -256,8 +253,7 @@ public boolean addAll(int index, Collection<? extends E> collection) {
 
 		if (index == size()) {
 			for (E element : collection) {
-				listOps.rightPush(element);
-				cap();
+				addLast(element);
 			}
 			return true;
 		}
@@ -341,9 +337,7 @@ public E element() {
 
 	@Override
 	public boolean offer(E element) {
-		listOps.rightPush(element);
-		cap();
-		return true;
+		return add(element);
 	}
 
 	@Override

From 2905834d2a7f0946693b5be59c9a0d0f7c0b89d1 Mon Sep 17 00:00:00 2001
From: jinbeom <kst20026@gamil.com>
Date: Sun, 15 Sep 2024 08:21:11 +0900
Subject: [PATCH 2/3] Refactor addAll Method in DefaultRedisList for Improved
 Readability.

---
 .../redis/support/collections/DefaultRedisList.java | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
index 4ab522991c..a1de9e0713 100644
--- a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
+++ b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
@@ -239,22 +239,15 @@ public boolean addAll(int index, Collection<? extends E> collection) {
 
 		// insert collection in reverse
 		if (index == 0) {
-
-			Collection<? extends E> reverseCollection = CollectionUtils.reverse(collection);
-
-			for (E element : reverseCollection) {
-				addFirst(element);
-			}
-
+			CollectionUtils.reverse(collection)
+					.forEach(this::addFirst);
 			return true;
 		}
 
 		int size = size();
 
 		if (index == size()) {
-			for (E element : collection) {
-				addLast(element);
-			}
+			collection.forEach(this::addLast);
 			return true;
 		}
 

From b78e3f44b92ab599287581f9ec6b14b9cd1543b1 Mon Sep 17 00:00:00 2001
From: jinbeom <kst20026@gamil.com>
Date: Sun, 15 Sep 2024 08:39:47 +0900
Subject: [PATCH 3/3] Add author information to DefaultRedisList.

---
 .../data/redis/support/collections/DefaultRedisList.java         | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
index a1de9e0713..b2ea1d878e 100644
--- a/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
+++ b/src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java
@@ -41,6 +41,7 @@
  * @author Christoph Strobl
  * @author Mark Paluch
  * @author John Blum
+ * @author Jinbeom Kim
  */
 public class DefaultRedisList<E> extends AbstractRedisCollection<E> implements RedisList<E> {