Skip to content

Commit 5d7adf0

Browse files
jinbeommp911de
jinbeom
authored andcommitted
Remove duplicate code in DefaultRedisList.
Closes: #2996 Original pull request: #2997
1 parent d738ec4 commit 5d7adf0

File tree

1 file changed

+7
-19
lines changed

1 file changed

+7
-19
lines changed

src/main/java/org/springframework/data/redis/support/collections/DefaultRedisList.java

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
* @author Christoph Strobl
4242
* @author Mark Paluch
4343
* @author John Blum
44+
* @author Jinbeom Kim
4445
*/
4546
public class DefaultRedisList<E> extends AbstractRedisCollection<E> implements RedisList<E> {
4647

@@ -216,16 +217,14 @@ public boolean remove(Object o) {
216217
public void add(int index, E element) {
217218

218219
if (index == 0) {
219-
listOps.leftPush(element);
220-
cap();
220+
addFirst(element);
221221
return;
222222
}
223223

224224
int size = size();
225225

226226
if (index == size()) {
227-
listOps.rightPush(element);
228-
cap();
227+
addLast(element);
229228
return;
230229
}
231230

@@ -241,24 +240,15 @@ public boolean addAll(int index, Collection<? extends E> collection) {
241240

242241
// insert collection in reverse
243242
if (index == 0) {
244-
245-
Collection<? extends E> reverseCollection = CollectionUtils.reverse(collection);
246-
247-
for (E element : reverseCollection) {
248-
listOps.leftPush(element);
249-
cap();
250-
}
251-
243+
CollectionUtils.reverse(collection)
244+
.forEach(this::addFirst);
252245
return true;
253246
}
254247

255248
int size = size();
256249

257250
if (index == size()) {
258-
for (E element : collection) {
259-
listOps.rightPush(element);
260-
cap();
261-
}
251+
collection.forEach(this::addLast);
262252
return true;
263253
}
264254

@@ -341,9 +331,7 @@ public E element() {
341331

342332
@Override
343333
public boolean offer(E element) {
344-
listOps.rightPush(element);
345-
cap();
346-
return true;
334+
return add(element);
347335
}
348336

349337
@Override

0 commit comments

Comments
 (0)