DATAREDIS-277 - Add support for 'SLAVEOF'.

'SLAVEOF' and 'SLAVEOF NO ONE' are available via 'RedisConnection' and 'RedisOperations' for 'jedis', 'jredis', 'lettuce' and 'srp'.

Original Pull Request: #57

Author: christophstrobl

docs/src/reference/docbook/appendix/appendix-command-reference.xml

@@ -138,7 +138,7 @@
 				<row><entry><code>SINTER</code></entry><entry>X</entry></row>
 				<row><entry><code>SINTERSTORE</code></entry><entry>X</entry></row>
 				<row><entry><code>SISMEMBER</code></entry><entry>X</entry></row>
-				<row><entry><code>SLAVEOF</code></entry><entry>-</entry></row>
+				<row><entry><code>SLAVEOF</code></entry><entry>X</entry></row>
 				<row><entry><code>SLOWLOG</code></entry><entry>-</entry></row>
 				<row><entry><code>SMEMBERS</code></entry><entry>X</entry></row>
 				<row><entry><code>SMOVE</code></entry><entry>X</entry></row>

src/main/java/org/springframework/data/redis/connection/DefaultStringRedisConnection.java

@@ -2191,6 +2191,24 @@ public Long time() {
 		return this.delegate.time();
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(String host, int port) {
+		this.delegate.slaveOf(host, port);
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+		this.delegate.slaveOfNoOne();
+	}
+
 	/**
 	 * Specifies if pipelined and tx results should be deserialized to Strings. If false, results of
 	 * {@link #closePipeline()} and {@link #exec()} will be of the type returned by the underlying connection

src/main/java/org/springframework/data/redis/connection/RedisServerCommands.java

@@ -161,4 +161,22 @@ public enum ShutdownOption {
 	 * @since 1.1
 	 */
 	Long time();
+
+	/**
+	 * Change redis replication setting to new master.
+	 * 
+	 * @param host
+	 * @param port
+	 * @since 1.3
+	 * @see http://redis.io/commands/slaveof
+	 */
+	void slaveOf(String host, int port);
+
+	/**
+	 * Change server into master.
+	 * 
+	 * @since 1.3
+	 * @see http://redis.io/commands/slaveof
+	 */
+	void slaveOfNoOne();
 }

src/main/java/org/springframework/data/redis/connection/jedis/JedisConnection.java

@@ -2808,6 +2808,41 @@ public Long time() {
 		return Converters.toTimeMillis(serverTimeInformation.get(0), serverTimeInformation.get(1));
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(String host, int port) {
+
+		Assert.hasText(host, "Host must not be null for 'SLAVEOF' command.");
+		if (isQueueing() || isPipelined()) {
+			throw new UnsupportedOperationException("'SLAVEOF' cannot be called in pipline / transaction mode.");
+		}
+		try {
+			this.jedis.slaveof(host, port);
+		} catch (Exception e) {
+			throw convertJedisAccessException(e);
+		}
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+
+		if (isQueueing() || isPipelined()) {
+			throw new UnsupportedOperationException("'SLAVEOF' cannot be called in pipline / transaction mode.");
+		}
+		try {
+			this.jedis.slaveofNoOne();
+		} catch (Exception e) {
+			throw convertJedisAccessException(e);
+		}
+	}
+
 	/**
 	 * Specifies if pipelined results should be converted to the expected data type. If false, results of
 	 * {@link #closePipeline()} and {@link #exec()} will be of the type returned by the Jedis driver

src/main/java/org/springframework/data/redis/connection/jredis/JredisConnection.java

@@ -1185,4 +1185,32 @@ public <T> T evalSha(String scriptSha1, ReturnType returnType, int numKeys, byte
 	public Long time() {
 		throw new UnsupportedOperationException("The 'TIME' command is not supported by the JRedis driver.");
 	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(String host, int port) {
+
+		try {
+			this.jredis.slaveof(host, port);
+		} catch (Exception e) {
+			throw convertJredisAccessException(e);
+		}
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+
+		try {
+			this.jredis.slaveofnone();
+		} catch (Exception e) {
+			throw convertJredisAccessException(e);
+		}
+	}
 }

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceConnection.java

@@ -2903,6 +2903,52 @@ public Long time() {
 		return Converters.toTimeMillis(new String(result.get(0)), new String(result.get(1)));
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(String host, int port) {
+
+		Assert.hasText(host, "Host must not be null for 'SLAVEOF' command.");
+		try {
+			if (isPipelined()) {
+				pipeline(new LettuceStatusResult(getAsyncConnection().slaveof(host, port)));
+				return;
+			}
+			if (isQueueing()) {
+				transaction(new LettuceTxResult(getConnection().slaveof(host, port)));
+				return;
+			}
+			getConnection().slaveof(host, port);
+		} catch (Exception ex) {
+			throw convertLettuceAccessException(ex);
+		}
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+
+		try {
+			if (isPipelined()) {
+				pipeline(new LettuceStatusResult(getAsyncConnection().slaveofNoOne()));
+				return;
+			}
+			if (isQueueing()) {
+				transaction(new LettuceTxResult(getConnection().slaveofNoOne()));
+				return;
+			}
+			getConnection().slaveofNoOne();
+		} catch (Exception ex) {
+			throw convertLettuceAccessException(ex);
+		}
+
+	}
+
 	/**
 	 * Specifies if pipelined and transaction results should be converted to the expected data type. If false, results of
 	 * {@link #closePipeline()} and {@link #exec()} will be of the type returned by the Lettuce driver

src/main/java/org/springframework/data/redis/connection/srp/SrpConnection.java

@@ -2222,6 +2222,43 @@ public Long time() {
 		return SrpConverters.toTimeAsLong(reply.data());
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(String host, int port) {
+
+		Assert.hasText(host, "Host must not be null for 'SLAVEOF' command.");
+		try {
+			if (isPipelined()) {
+				pipeline(new SrpStatusResult(pipeline.slaveof(host, port)));
+				return;
+			}
+			client.slaveof(host, port);
+		} catch (Exception e) {
+			throw convertSrpAccessException(e);
+		}
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.connection.RedisServerCommands#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+
+		try {
+			if (isPipelined()) {
+				pipeline(new SrpStatusResult(pipeline.slaveof("NO", "ONE")));
+				return;
+			}
+			client.slaveof("NO", "ONE");
+		} catch (Exception e) {
+			throw convertSrpAccessException(e);
+		}
+	}
+
 	private List<Object> closeTransaction() {
 		List<Object> results = Collections.emptyList();
 		if (txTracker != null) {

src/main/java/org/springframework/data/redis/core/RedisOperations.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2013 the original author or authors.
+ * Copyright 2011-2014 the original author or authors.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,6 +31,7 @@
  * useful option for extensibility and testability (as it can be easily mocked or stubbed).
  * 
  * @author Costin Leau
+ * @author Christoph Strobl
  */
 public interface RedisOperations<K, V> {
 
@@ -284,4 +285,20 @@ <T> T execute(RedisScript<T> script, RedisSerializer<?> argsSerializer, RedisSer
 	RedisSerializer<?> getHashKeySerializer();
 
 	RedisSerializer<?> getHashValueSerializer();
+
+	/**
+	 * Change redis replication setting to new master.
+	 * 
+	 * @param host
+	 * @param port
+	 * @since 1.3
+	 */
+	void slaveOf(String host, int port);
+
+	/**
+	 * Change server into master.
+	 * 
+	 * @since 1.3
+	 */
+	void slaveOfNoOne();
 }

src/main/java/org/springframework/data/redis/core/RedisTemplate.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2013 the original author or authors.
+ * Copyright 2011-2014 the original author or authors.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -69,6 +69,7 @@
  * <b>This is the central class in Redis support</b>.
  * 
  * @author Costin Leau
+ * @author Christoph Strobl
  * @param <K> the Redis key type against which the template works (usually a String)
  * @param <V> the Redis value type against which the template works
  * @see StringRedisTemplate
@@ -989,4 +990,38 @@ public <HK, HV> BoundHashOperations<K, HK, HV> boundHashOps(K key) {
 	public <HK, HV> HashOperations<K, HK, HV> opsForHash() {
 		return new DefaultHashOperations<K, HK, HV>(this);
 	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.core.RedisOperations#slaveOf(java.lang.String, int)
+	 */
+	@Override
+	public void slaveOf(final String host, final int port) {
+		execute(new RedisCallback<Void>() {
+
+			@Override
+			public Void doInRedis(RedisConnection connection) throws DataAccessException {
+				connection.slaveOf(host, port);
+				return null;
+			}
+
+		});
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.redis.core.RedisOperations#slaveOfNoOne()
+	 */
+	@Override
+	public void slaveOfNoOne() {
+		execute(new RedisCallback<Void>() {
+
+			@Override
+			public Void doInRedis(RedisConnection connection) throws DataAccessException {
+				connection.slaveOfNoOne();
+				return null;
+			}
+		});
+
+	}
 }

src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionUnitTestSuite.java

@@ -113,6 +113,34 @@ public void pExpireHavingIntOverflowShouldUseRedisServerTimeAsReferenceForPExpir
 			connection.pExpire("foo".getBytes(), msec);
 			verifyNativeConnectionInvocation().pexpireAt(any(byte[].class), eq(expected));
 		}
+
+		/**
+		 * @see DATAREDIS-277
+		 */
+		@Test(expected = IllegalArgumentException.class)
+		public void slaveOfShouldThrowExectpionWhenCalledForNullHost() {
+			connection.slaveOf(null, 0);
+		}
+
+		/**
+		 * @see DATAREDIS-277
+		 */
+		@Test
+		public void slaveOfShouldBeSentCorrectly() {
+
+			connection.slaveOf("127.0.0.1", 1001);
+			verifyNativeConnectionInvocation().slaveof(eq("127.0.0.1"), eq(1001));
+		}
+
+		/**
+		 * @see DATAREDIS-277
+		 */
+		@Test
+		public void slaveOfNoOneShouldBeSentCorrectly() {
+
+			connection.slaveOfNoOne();
+			verifyNativeConnectionInvocation().slaveofNoOne();
+		}
 	}
 
 	public static class JedisConnectionPipelineUnitTests extends JedisConnectionUnitTests {
@@ -141,6 +169,23 @@ public void shutdownSaveShouldBeSentCorrectlyUsingLuaScript() {
 			super.shutdownSaveShouldBeSentCorrectlyUsingLuaScript();
 		}
 
+		/**
+		 * @see DATAREDIS-277
+		 */
+		@Override
+		@Test(expected = UnsupportedOperationException.class)
+		public void slaveOfShouldBeSentCorrectly() {
+			super.slaveOfShouldBeSentCorrectly();
+		}
+
+		/**
+		 * @see DATAREDIS-277
+		 */
+		@Test(expected = UnsupportedOperationException.class)
+		public void slaveOfNoOneShouldBeSentCorrectly() {
+			super.slaveOfNoOneShouldBeSentCorrectly();
+		}
+
 	}
 
 	/**