Skip to content

Commit 3786ecd

Browse files
committed
DATAGRAPH-1428 - Polishing.
Reorder methods. Fix import ordering. Original pull request: #554.
1 parent 04e095d commit 3786ecd

File tree

2 files changed

+23
-18
lines changed

2 files changed

+23
-18
lines changed

src/main/java/org/springframework/data/neo4j/repository/support/SimpleNeo4jRepository.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,9 @@ public void delete(T entity) {
162162

163163
@Override
164164
@Transactional
165-
public void deleteAll() {
165+
public void deleteAllById(Iterable<? extends ID> ids) {
166166

167-
this.neo4jOperations.deleteAll(this.entityInformation.getJavaType());
167+
this.neo4jOperations.deleteAllById(ids, this.entityInformation.getJavaType());
168168
}
169169

170170
@Override
@@ -179,8 +179,8 @@ public void deleteAll(Iterable<? extends T> entities) {
179179

180180
@Override
181181
@Transactional
182-
public void deleteAllById(Iterable<? extends ID> ids) {
182+
public void deleteAll() {
183183

184-
this.neo4jOperations.deleteAllById(ids, this.entityInformation.getJavaType());
184+
this.neo4jOperations.deleteAll(this.entityInformation.getJavaType());
185185
}
186186
}

src/main/java/org/springframework/data/neo4j/repository/support/SimpleReactiveNeo4jRepository.java

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package org.springframework.data.neo4j.repository.support;
1717

18-
import org.springframework.data.neo4j.core.mapping.Neo4jPersistentProperty;
1918
import reactor.core.publisher.Flux;
2019
import reactor.core.publisher.Mono;
2120

@@ -26,10 +25,12 @@
2625
import org.apiguardian.api.API;
2726
import org.neo4j.cypherdsl.core.Statement;
2827
import org.reactivestreams.Publisher;
28+
2929
import org.springframework.data.domain.Sort;
3030
import org.springframework.data.neo4j.core.ReactiveNeo4jOperations;
31-
import org.springframework.data.neo4j.core.mapping.Neo4jPersistentEntity;
3231
import org.springframework.data.neo4j.core.mapping.CypherGenerator;
32+
import org.springframework.data.neo4j.core.mapping.Neo4jPersistentEntity;
33+
import org.springframework.data.neo4j.core.mapping.Neo4jPersistentProperty;
3334
import org.springframework.data.neo4j.repository.query.CypherAdapterUtils;
3435
import org.springframework.data.repository.reactive.ReactiveSortingRepository;
3536
import org.springframework.stereotype.Repository;
@@ -187,13 +188,14 @@ public Mono<Void> delete(T entity) {
187188

188189
/*
189190
* (non-Javadoc)
190-
* @see org.springframework.data.repository.reactive.ReactiveCrudRepository#deleteAll()
191+
* @see org.springframework.data.repository.reactive.ReactiveCrudRepository#deleteAllById(java.lang.Iterabl)
191192
*/
192193
@Override
193-
@Transactional
194-
public Mono<Void> deleteAll() {
194+
public Mono<Void> deleteAllById(Iterable<? extends ID> ids) {
195195

196-
return this.neo4jOperations.deleteAll(this.entityInformation.getJavaType());
196+
Assert.notNull(ids, "The given Iterable of ids must not be null!");
197+
198+
return this.neo4jOperations.deleteAllById(ids, this.entityInformation.getJavaType());
197199
}
198200

199201
/*
@@ -211,14 +213,6 @@ public Mono<Void> deleteAll(Iterable<? extends T> entities) {
211213
return this.neo4jOperations.deleteAllById(ids, this.entityInformation.getJavaType());
212214
}
213215

214-
@Override
215-
public Mono<Void> deleteAllById(Iterable<? extends ID> ids) {
216-
217-
Assert.notNull(ids, "The given Iterable of ids must not be null!");
218-
219-
return this.neo4jOperations.deleteAllById(ids, this.entityInformation.getJavaType());
220-
}
221-
222216
/*
223217
* (non-Javadoc)
224218
* @see org.springframework.data.repository.reactive.ReactiveCrudRepository#deleteAll(org.reactivestreams.Publisher)
@@ -230,4 +224,15 @@ public Mono<Void> deleteAll(Publisher<? extends T> entitiesPublisher) {
230224
Assert.notNull(entitiesPublisher, "The given Publisher of entities must not be null!");
231225
return Flux.from(entitiesPublisher).flatMap(this::delete).then();
232226
}
227+
228+
/*
229+
* (non-Javadoc)
230+
* @see org.springframework.data.repository.reactive.ReactiveCrudRepository#deleteAll()
231+
*/
232+
@Override
233+
@Transactional
234+
public Mono<Void> deleteAll() {
235+
236+
return this.neo4jOperations.deleteAll(this.entityInformation.getJavaType());
237+
}
233238
}

0 commit comments

Comments
 (0)