DATAMONGO-1566 - Adapt API in MongoRepositoryFactoryBean.

Related tickets: DATACMNS-891.

Author: odrotbohm

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/support/MongoRepositoryFactoryBean.java

@@ -30,13 +30,22 @@
  * 
  * @author Oliver Gierke
  */
-public class MongoRepositoryFactoryBean<T extends Repository<S, ID>, S, ID extends Serializable> extends
-		RepositoryFactoryBeanSupport<T, S, ID> {
+public class MongoRepositoryFactoryBean<T extends Repository<S, ID>, S, ID extends Serializable>
+		extends RepositoryFactoryBeanSupport<T, S, ID> {
 
 	private MongoOperations operations;
 	private boolean createIndexesForQueryMethods = false;
 	private boolean mappingContextConfigured = false;
 
+	/**
+	 * Creates a new {@link MongoRepositoryFactoryBean} for the given repository interface.
+	 * 
+	 * @param repositoryInterface must not be {@literal null}.
+	 */
+	public MongoRepositoryFactoryBean(Class<? extends T> repositoryInterface) {
+		super(repositoryInterface);
+	}
+
 	/**
 	 * Configures the {@link MongoOperations} to be used.
 	 * 

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/performance/PerformanceTests.java

@@ -97,9 +97,9 @@ public void setUp() throws Exception {
 		this.converter = new MappingMongoConverter(new DefaultDbRefResolver(mongoDbFactory), context);
 		this.operations = new MongoTemplate(new SimpleMongoDbFactory(this.mongo, DATABASE_NAME), converter);
 
-		MongoRepositoryFactoryBean<PersonRepository, Person, ObjectId> factory = new MongoRepositoryFactoryBean<PersonRepository, Person, ObjectId>();
+		MongoRepositoryFactoryBean<PersonRepository, Person, ObjectId> factory = new MongoRepositoryFactoryBean<PersonRepository, Person, ObjectId>(
+				PersonRepository.class);
 		factory.setMongoOperations(operations);
-		factory.setRepositoryInterface(PersonRepository.class);
 		factory.afterPropertiesSet();
 
 		this.repository = factory.getObject();
@@ -125,8 +125,8 @@ public void doWithWriteConcern(String constantName, WriteConcern concern) {
 	@Test
 	public void plainConversion() throws InterruptedException {
 
-		Statistics statistics = new Statistics("Plain conversion of " + NUMBER_OF_PERSONS * 100
-				+ " persons - After %s iterations");
+		Statistics statistics = new Statistics(
+				"Plain conversion of " + NUMBER_OF_PERSONS * 100 + " persons - After %s iterations");
 
 		List<DBObject> dbObjects = getPersonDBObjects(NUMBER_OF_PERSONS * 100);
 
@@ -842,8 +842,8 @@ public String print(double referenceAverage, double referenceMedian) {
 		 */
 		@Override
 		public String toString() {
-			return times.isEmpty() ? "" : String.format("%s, %s: %s", api, mode,
-					StringUtils.collectionToCommaDelimitedString(times)) + '\n';
+			return times.isEmpty() ? ""
+					: String.format("%s, %s: %s", api, mode, StringUtils.collectionToCommaDelimitedString(times)) + '\n';
 		}
 	}
 

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/config/MongoRepositoriesRegistrarIntegrationTests.java

@@ -15,11 +15,6 @@
  */
 package org.springframework.data.mongodb.repository.config;
 
-import static org.hamcrest.CoreMatchers.*;
-import static org.junit.Assert.*;
-
-import java.util.Arrays;
-
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -59,15 +54,4 @@ public MongoOperations mongoTemplate() throws Exception {
 
 	@Test
 	public void testConfiguration() {}
-
-	/**
-	 * @see DATAMONGO-901
-	 */
-	@Test
-	public void registersTypePredictingPostProcessor() {
-
-		Iterable<String> beanNames = Arrays.asList(context.getBeanDefinitionNames());
-
-		assertThat(beanNames, hasItem(containsString("RepositoryFactoryBeanSupport_Predictor")));
-	}
 }

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/support/MongoRepositoryFactoryBeanUnitTests.java

@@ -48,7 +48,7 @@ public class MongoRepositoryFactoryBeanUnitTests {
 	@SuppressWarnings("rawtypes")
 	public void addsIndexEnsuringQueryCreationListenerIfConfigured() {
 
-		MongoRepositoryFactoryBean factory = new MongoRepositoryFactoryBean();
+		MongoRepositoryFactoryBean factory = new MongoRepositoryFactoryBean(ContactRepository.class);
 		factory.setCreateIndexesForQueryMethods(true);
 
 		List<Object> listeners = getListenersFromFactory(factory);
@@ -60,7 +60,7 @@ public void addsIndexEnsuringQueryCreationListenerIfConfigured() {
 	@SuppressWarnings("rawtypes")
 	public void doesNotAddIndexEnsuringQueryCreationListenerByDefault() {
 
-		List<Object> listeners = getListenersFromFactory(new MongoRepositoryFactoryBean());
+		List<Object> listeners = getListenersFromFactory(new MongoRepositoryFactoryBean(ContactRepository.class));
 		assertThat(listeners.size(), is(1));
 	}
 
@@ -72,7 +72,6 @@ private List<Object> getListenersFromFactory(MongoRepositoryFactoryBean factoryB
 
 		factoryBean.setLazyInit(true);
 		factoryBean.setMongoOperations(operations);
-		factoryBean.setRepositoryInterface(ContactRepository.class);
 		factoryBean.afterPropertiesSet();
 
 		RepositoryFactorySupport factory = factoryBean.createRepositoryFactory();

spring-data-mongodb/src/test/resources/org/springframework/data/mongodb/repository/PersonRepositoryIntegrationTests-context.xml

@@ -17,8 +17,8 @@
 	</bean>
 
 	<bean class="org.springframework.data.mongodb.repository.support.MongoRepositoryFactoryBean">
+		<constructor-arg value="org.springframework.data.mongodb.repository.PersonRepository"/>
 		<property name="mongoOperations" ref="mongoTemplate"/>
-		<property name="repositoryInterface" value="org.springframework.data.mongodb.repository.PersonRepository"/>
 		<property name="namedQueries">
 			<bean class="org.springframework.data.repository.core.support.PropertiesBasedNamedQueries">
 				<constructor-arg>
@@ -34,5 +34,5 @@
 			<bean class="org.springframework.data.mongodb.repository.SampleEvaluationContextExtension"/>
 		</constructor-arg>
 	</bean>
-	
+
 </beans>