Skip to content

Commit 2b58f70

Browse files
committed
DATAMONGO-1605 - Polishing.
Remove additional quoting around JSON serialization because JSON serialization adds quotes to a string. Reformat code.
1 parent 5d8f10f commit 2b58f70

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ExpressionEvaluatingParameterBinder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,6 @@ private String getParameterValueForBinding(MongoParameterAccessor accessor, Mong
219219
return base64representation;
220220
}
221221

222-
if (binding.isExpression() && value instanceof String) {
223-
return "\"" + JSON.serialize(value) + "\"";
224-
}
225-
226222
return JSON.serialize(value);
227223
}
228224

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQueryUnitTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ public void findUsingSpelShouldRetainParameterType() throws Exception {
523523
public void findUsingSpelShouldRetainNullValues() throws Exception {
524524

525525
StringBasedMongoQuery mongoQuery = createQueryForMethod("findByUsingSpel", Object.class);
526-
ConvertingParameterAccessor accessor = StubParameterAccessor.getAccessor(converter, new Object[]{null});
526+
ConvertingParameterAccessor accessor = StubParameterAccessor.getAccessor(converter, new Object[] { null });
527527

528528
org.springframework.data.mongodb.core.query.Query query = mongoQuery.createQuery(accessor);
529529
assertThat(query.getQueryObject(), is((DBObject) new BasicDBObject().append("arg0", null)));

0 commit comments

Comments
 (0)