Skip to content

Commit 19abff8

Browse files
committed
DATAMONGO-1465 - Polishing.
Replace boolean flag in convertAndJoinScriptArgs with literal. Joined args are rendered to JavaScript and require always string quotation. Original pull request: #383.
1 parent 5f199cf commit 19abff8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultScriptOperations.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public Object call(final String scriptName, final Object... args) {
116116

117117
@Override
118118
public Object doInDB(DB db) throws MongoException, DataAccessException {
119-
return db.eval(String.format("%s(%s)", scriptName, convertAndJoinScriptArgs(true, args)));
119+
return db.eval(String.format("%s(%s)", scriptName, convertAndJoinScriptArgs(args)));
120120
}
121121
});
122122
}
@@ -171,8 +171,8 @@ private Object[] convertScriptArgs(boolean quote, Object... args) {
171171
return convertedValues.toArray();
172172
}
173173

174-
private String convertAndJoinScriptArgs(boolean quote, Object... args) {
175-
return ObjectUtils.isEmpty(args) ? "" : StringUtils.arrayToCommaDelimitedString(convertScriptArgs(quote, args));
174+
private String convertAndJoinScriptArgs(Object... args) {
175+
return ObjectUtils.isEmpty(args) ? "" : StringUtils.arrayToCommaDelimitedString(convertScriptArgs(true, args));
176176
}
177177

178178
/**

0 commit comments

Comments
 (0)