DATAMONGO-1085 - Fixed sorting with querydsl in QueryDslMongoRepository.

We now translate QSort's OrderSpecifiers into appropriate sort criteria.
Previously the OrderSpecificers were not correctly translated to appropriate property path expressions.
Added support for findAll(Pageable) and findAll(Sort) to QueryDslMongoRepository.
Avoid multiple creations of sortObjects in MongoTemplate.getMappedSortObject(..).

Author: Thomas Darimont

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java

@@ -1966,11 +1966,16 @@ private static final MongoConverter getDefaultMongoConverter(MongoDbFactory fact
 
 	private DBObject getMappedSortObject(Query query, Class<?> type) {
 
-		if (query == null || query.getSortObject() == null) {
+		if (query == null) {
+			return null;
+		}
+
+		DBObject sortObject = query.getSortObject();
+		if (sortObject == null) {
 			return null;
 		}
 
-		return queryMapper.getMappedSort(query.getSortObject(), mappingContext.getPersistentEntity(type));
+		return queryMapper.getMappedSort(sortObject, mappingContext.getPersistentEntity(type));
 	}
 
 	// Callback implementations

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/support/QueryDslMongoRepository.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2012 the original author or authors.
+ * Copyright 2011-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@
 import org.springframework.data.mongodb.core.MongoTemplate;
 import org.springframework.data.mongodb.repository.query.MongoEntityInformation;
 import org.springframework.data.querydsl.EntityPathResolver;
+import org.springframework.data.querydsl.QSort;
 import org.springframework.data.querydsl.QueryDslPredicateExecutor;
 import org.springframework.data.querydsl.SimpleEntityPathResolver;
 import org.springframework.data.repository.core.EntityMetadata;
@@ -43,6 +44,7 @@
  * Special QueryDsl based repository implementation that allows execution {@link Predicate}s in various forms.
  * 
  * @author Oliver Gierke
+ * @author Thomas Darimont
  */
 public class QueryDslMongoRepository<T, ID extends Serializable> extends SimpleMongoRepository<T, ID> implements
 		QueryDslPredicateExecutor<T> {
@@ -98,7 +100,6 @@ public List<T> findAll(Predicate predicate) {
 	 * @see org.springframework.data.querydsl.QueryDslPredicateExecutor#findAll(com.mysema.query.types.Predicate, com.mysema.query.types.OrderSpecifier<?>[])
 	 */
 	public List<T> findAll(Predicate predicate, OrderSpecifier<?>... orders) {
-
 		return createQueryFor(predicate).orderBy(orders).list();
 	}
 
@@ -114,6 +115,25 @@ public Page<T> findAll(Predicate predicate, Pageable pageable) {
 		return new PageImpl<T>(applyPagination(query, pageable).list(), pageable, countQuery.count());
 	}
 
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.data.querydsl.QueryDslPredicateExecutor#findAll(com.mysema.query.types.Predicate, org.springframework.data.domain.Pageable)
+	 */
+	public Page<T> findAll(Pageable pageable) {
+
+		MongodbQuery<T> countQuery = createQuery();
+		MongodbQuery<T> query = createQuery();
+
+		return new PageImpl<T>(applyPagination(query, pageable).list(), pageable, countQuery.count());
+	}
+
+	/* (non-Javadoc)
+	 * @see org.springframework.data.mongodb.repository.support.SimpleMongoRepository#findAll(org.springframework.data.domain.Sort)
+	 */
+	public List<T> findAll(Sort sort) {
+		return applySorting(createQuery(), sort).list();
+	}
+
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.querydsl.QueryDslPredicateExecutor#count(com.mysema.query.types.Predicate)
@@ -129,11 +149,11 @@ public long count(Predicate predicate) {
 	 * @return
 	 */
 	private MongodbQuery<T> createQueryFor(Predicate predicate) {
+		return createQuery().where(predicate);
+	}
 
-		Class<T> domainType = getEntityInformation().getJavaType();
-
-		MongodbQuery<T> query = new SpringDataMongodbQuery<T>(getMongoOperations(), domainType);
-		return query.where(predicate);
+	private MongodbQuery<T> createQuery() {
+		return new SpringDataMongodbQuery<T>(getMongoOperations(), getEntityInformation().getJavaType());
 	}
 
 	/**
@@ -166,6 +186,14 @@ private MongodbQuery<T> applySorting(MongodbQuery<T> query, Sort sort) {
 			return query;
 		}
 
+		if (sort instanceof QSort) {
+
+			List<OrderSpecifier<?>> orderSpecifiers = ((QSort) sort).getOrderSpecifiers();
+			query.orderBy(orderSpecifiers.toArray(new OrderSpecifier<?>[orderSpecifiers.size()]));
+
+			return query;
+		}
+
 		for (Order order : sort) {
 			query.orderBy(toOrder(order));
 		}

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/AbstractPersonRepositoryIntegrationTests.java

@@ -47,6 +47,7 @@
 import org.springframework.data.mongodb.core.MongoOperations;
 import org.springframework.data.mongodb.core.query.BasicQuery;
 import org.springframework.data.mongodb.repository.Person.Sex;
+import org.springframework.data.querydsl.QSort;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 
 import com.google.common.collect.Lists;
@@ -1090,4 +1091,49 @@ public void shouldSupportSortingByQueryDslOrderSpecifier() {
 		assertThat(result, hasSize(persons.size()));
 		assertThat(result.get(0).getFirstname(), is(persons.get(2).getFirstname()));
 	}
+
+	/**
+	 * @see DATAMONGO-1085
+	 */
+	@Test
+	public void shouldSupportSortingWithQSortByQueryDslOrderSpecifier() throws Exception {
+
+		repository.deleteAll();
+
+		List<Person> persons = new ArrayList<Person>();
+		for (int i = 0; i < 3; i++) {
+			Person pers = new Person(String.format("Siggi %s", i), "Bar", 30);
+			pers.setAddress(new Address(String.format("Street %s", i), "12345", "SinCity"));
+			persons.add(pers);
+		}
+		repository.save(persons);
+
+		PageRequest pageRequest = new PageRequest(0, 2, new QSort(person.address.street.desc()));
+		List<Person> result = Lists.newArrayList(repository.findAll(pageRequest));
+
+		assertThat(result, hasSize(pageRequest.getPageSize()));
+		assertThat(result.get(0).getFirstname(), is("Siggi 2"));
+	}
+
+	/**
+	 * @see DATAMONGO-1085
+	 */
+	@Test
+	public void shouldSupportSortingWithQSort() throws Exception {
+
+		repository.deleteAll();
+
+		List<Person> persons = new ArrayList<Person>();
+		for (int i = 0; i < 3; i++) {
+			Person pers = new Person(String.format("Siggi %s", i), "Bar", 30);
+			pers.setAddress(new Address(String.format("Street %s", i), "12345", "SinCity"));
+			persons.add(pers);
+		}
+		repository.save(persons);
+
+		List<Person> result = Lists.newArrayList(repository.findAll(new QSort(person.address.street.desc())));
+
+		assertThat(result, hasSize(persons.size()));
+		assertThat(result.get(0).getFirstname(), is("Siggi 2"));
+	}
 }

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/PersonRepositoryIntegrationTests.java

@@ -24,4 +24,22 @@
  * @author Thomas Darimont
  */
 @ContextConfiguration
-public class PersonRepositoryIntegrationTests extends AbstractPersonRepositoryIntegrationTests {}
+public class PersonRepositoryIntegrationTests extends AbstractPersonRepositoryIntegrationTests {
+	@Override
+	public void shouldSupportSortingWithQSortByQueryDslOrderSpecifier() throws Exception {
+		// TODO Auto-generated method stub
+		super.shouldSupportSortingWithQSortByQueryDslOrderSpecifier();
+	}
+
+	@Override
+	public void shouldSupportSortingByQueryDslOrderSpecifier() {
+		// TODO Auto-generated method stub
+		super.shouldSupportSortingByQueryDslOrderSpecifier();
+	}
+
+	@Override
+	public void shouldSupportSortingWithQSort() throws Exception {
+		// TODO Auto-generated method stub
+		super.shouldSupportSortingWithQSort();
+	}
+}