Skip to content

Commit 8f5fa59

Browse files
DATAKV-186 - Polishing.
Add missing author information and split test. Original Pull Request: #24
1 parent c5e0d1a commit 8f5fa59

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

src/main/java/org/springframework/data/keyvalue/repository/support/SimpleKeyValueRepository.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
* @author Christoph Strobl
3535
* @author Oliver Gierke
3636
* @author Mark Paluch
37+
* @author Eugene Nikiforov
3738
* @param <T>
3839
* @param <ID>
3940
*/

src/test/java/org/springframework/data/keyvalue/repository/SimpleKeyValueRepositoryUnitTests.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@
1515
*/
1616
package org.springframework.data.keyvalue.repository;
1717

18+
import static org.hamcrest.core.Is.*;
1819
import static org.junit.Assert.*;
19-
import static org.mockito.ArgumentMatchers.*;
20+
import static org.mockito.ArgumentMatchers.any;
21+
import static org.mockito.ArgumentMatchers.anyString;
22+
import static org.mockito.ArgumentMatchers.eq;
2023
import static org.mockito.Mockito.*;
2124

2225
import java.io.Serializable;
@@ -39,6 +42,7 @@
3942

4043
/**
4144
* @author Christoph Strobl
45+
* @author Eugene Nikiforov
4246
*/
4347
@RunWith(MockitoJUnitRunner.class)
4448
public class SimpleKeyValueRepositoryUnitTests {
@@ -126,14 +130,17 @@ public void findAllIds() {
126130
}
127131

128132
@Test // DATAKV-186
129-
public void existsById() {
133+
public void existsByIdReturnsFalseForEmptyOptional() {
134+
130135
when(opsMock.findById(any(Serializable.class), any(Class.class))).thenReturn(Optional.empty());
131-
assertFalse(repo.existsById("one"));
136+
assertThat(repo.existsById("one"), is(false));
137+
}
138+
139+
@Test // DATAKV-186
140+
public void existsByIdReturnsTrueWhenOptionalValuePresent() {
132141

133142
when(opsMock.findById(any(Serializable.class), any(Class.class))).thenReturn(Optional.of(new Foo()));
134143
assertTrue(repo.existsById("one"));
135-
136-
verify(opsMock, times(2)).findById(anyString(), eq(Foo.class));
137144
}
138145

139146
@Test // DATACMNS-525

0 commit comments

Comments
 (0)