DATAKV-187 - Polishing.

Remove Serializable ID constraints from factory beans. Replace casts with type.cast(…). Convert anonymous inner classes to lambdas. Remove unused code and casts. Simplify test entities by removing Serializable and using lombok. Letter casing, formatting, Javadoc.

Original pull request: #25.

Author: mp911de

src/main/asciidoc/key-value-repositories.adoc

@@ -20,7 +20,7 @@ interface KeyValueOperations {
 
     void delete(Class<?> type);                                   <3>
 
-    <T> T findById(Serializable id, Class<T> type);               <4>
+    <T> T findById(Object id, Class<T> type);                     <4>
 
     <T> Iterable<T> findAllOf(Class<T> type);                     <5>
 

src/main/java/org/springframework/data/keyvalue/core/AbstractKeyValueAdapter.java

@@ -24,6 +24,7 @@
  * {@literal count} execution to.
  *
  * @author Christoph Strobl
+ * @author Mark Paluch
  */
 public abstract class AbstractKeyValueAdapter implements KeyValueAdapter {
 
@@ -43,7 +44,7 @@ protected AbstractKeyValueAdapter() {
 	 */
 	protected AbstractKeyValueAdapter(QueryEngine<? extends KeyValueAdapter, ?, ?> engine) {
 
-		this.engine = engine != null ? engine : new SpelQueryEngine<>();
+		this.engine = engine != null ? engine : new SpelQueryEngine();
 		this.engine.registerAdapter(this);
 	}
 
@@ -62,7 +63,7 @@ protected AbstractKeyValueAdapter(QueryEngine<? extends KeyValueAdapter, ?, ?> e
 	 */
 	@Override
 	public <T> T get(Object id, String keyspace, Class<T> type) {
-		return (T) get(id, keyspace);
+		return type.cast(get(id, keyspace));
 	}
 
 	/*
@@ -71,7 +72,7 @@ public <T> T get(Object id, String keyspace, Class<T> type) {
 	 */
 	@Override
 	public <T> T delete(Object id, String keyspace, Class<T> type) {
-		return (T) delete(id, keyspace);
+		return type.cast(delete(id, keyspace));
 	}
 
 	/*

src/main/java/org/springframework/data/keyvalue/core/KeyValueOperations.java

@@ -25,22 +25,22 @@
 
 /**
  * Interface that specifies a basic set of key/value operations. Implemented by {@link KeyValueTemplate}.
- * 
+ *
  * @author Christoph Strobl
  */
 public interface KeyValueOperations extends DisposableBean {
 
 	/**
 	 * Add given object. Object needs to have id property to which a generated value will be assigned.
-	 * 
+	 *
 	 * @param objectToInsert
 	 * @return
 	 */
 	<T> T insert(T objectToInsert);
 
 	/**
 	 * Add object with given id.
-	 * 
+	 *
 	 * @param id must not be {@literal null}.
 	 * @param objectToInsert must not be {@literal null}.
 	 */
@@ -49,7 +49,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get all elements of given type. Respects {@link KeySpace} if present and therefore returns all elements that can be
 	 * assigned to requested type.
-	 * 
+	 *
 	 * @param type must not be {@literal null}.
 	 * @return empty iterable if no elements found.
 	 */
@@ -58,7 +58,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get all elements ordered by sort. Respects {@link KeySpace} if present and therefore returns all elements that can
 	 * be assigned to requested type.
-	 * 
+	 *
 	 * @param sort must not be {@literal null}.
 	 * @param type must not be {@literal null}.
 	 * @return
@@ -68,16 +68,16 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get element of given type with given id. Respects {@link KeySpace} if present and therefore returns all elements
 	 * that can be assigned to requested type.
-	 * 
+	 *
 	 * @param id must not be {@literal null}.
 	 * @param type must not be {@literal null}.
-	 * @return null if not found.
+	 * @return {@link Optional#empty()} if not found.
 	 */
 	<T> Optional<T> findById(Object id, Class<T> type);
 
 	/**
 	 * Execute operation against underlying store.
-	 * 
+	 *
 	 * @param action must not be {@literal null}.
 	 * @return
 	 */
@@ -86,7 +86,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get all elements matching the given query. <br />
 	 * Respects {@link KeySpace} if present and therefore returns all elements that can be assigned to requested type..
-	 * 
+	 *
 	 * @param query must not be {@literal null}.
 	 * @param type must not be {@literal null}.
 	 * @return empty iterable if no match found.
@@ -96,7 +96,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get all elements in given range. Respects {@link KeySpace} if present and therefore returns all elements that can
 	 * be assigned to requested type.
-	 * 
+	 *
 	 * @param offset
 	 * @param rows
 	 * @param type must not be {@literal null}.
@@ -107,7 +107,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Get all elements in given range ordered by sort. Respects {@link KeySpace} if present and therefore returns all
 	 * elements that can be assigned to requested type.
-	 * 
+	 *
 	 * @param offset
 	 * @param rows
 	 * @param sort
@@ -130,7 +130,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Remove all elements of type. Respects {@link KeySpace} if present and therefore removes all elements that can be
 	 * assigned to requested type.
-	 * 
+	 *
 	 * @param type must not be {@literal null}.
 	 */
 	void delete(Class<?> type);
@@ -143,7 +143,7 @@ public interface KeyValueOperations extends DisposableBean {
 
 	/**
 	 * Delete item of type with given id.
-	 * 
+	 *
 	 * @param id must not be {@literal null}.
 	 * @param type must not be {@literal null}.
 	 * @return the deleted item or {@literal null} if no match found.
@@ -153,7 +153,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Total number of elements with given type available. Respects {@link KeySpace} if present and therefore counts all
 	 * elements that can be assigned to requested type.
-	 * 
+	 *
 	 * @param type must not be {@literal null}.
 	 * @return
 	 */
@@ -162,7 +162,7 @@ public interface KeyValueOperations extends DisposableBean {
 	/**
 	 * Total number of elements matching given query. Respects {@link KeySpace} if present and therefore counts all
 	 * elements that can be assigned to requested type.
-	 * 
+	 *
 	 * @param query
 	 * @param type
 	 * @return