Skip to content

Commit 0ad24ec

Browse files
DATAKV-137 - Polishing.
Remove whitespaces & unused imports, fix warnings. Original Pull Request: #20
1 parent 302dfd4 commit 0ad24ec

File tree

4 files changed

+14
-22
lines changed

4 files changed

+14
-22
lines changed

src/main/java/org/springframework/data/keyvalue/repository/query/KeyValuePartTreeQuery.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ protected KeyValueQuery<?> prepareQuery(KeyValueQuery<?> instance, Object[] para
144144
parameters);
145145
criteria = new SpelCriteria(spelExpression, context);
146146
}
147-
147+
148148
KeyValueQuery<?> query = new KeyValueQuery(criteria);
149149
Pageable pageable = accessor.getPageable();
150150
Sort sort = accessor.getSort();
@@ -157,12 +157,12 @@ protected KeyValueQuery<?> prepareQuery(KeyValueQuery<?> instance, Object[] para
157157
}
158158

159159
private SpelExpression getSpelExpression(Object criteria) {
160-
161-
if(criteria instanceof SpelExpression){
160+
161+
if (criteria instanceof SpelExpression) {
162162
return (SpelExpression) criteria;
163163
}
164-
165-
if(criteria instanceof SpelCriteria){
164+
165+
if (criteria instanceof SpelCriteria) {
166166
return getSpelExpression(((SpelCriteria) criteria).getExpression());
167167
}
168168

src/test/java/org/springframework/data/keyvalue/repository/query/CachingKeyValuePartTreeQueryUnitTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import static org.hamcrest.core.IsNot.*;
1919
import static org.hamcrest.core.IsSame.*;
2020
import static org.junit.Assert.*;
21-
import static org.mockito.Matchers.any;
21+
import static org.mockito.Matchers.*;
2222
import static org.mockito.Mockito.*;
2323

2424
import java.lang.reflect.Method;
@@ -39,7 +39,7 @@
3939

4040
/**
4141
* Unit tests for {@link CachingKeyValuePartTreeQuery}.
42-
*
42+
*
4343
* @author Mark Paluch
4444
*/
4545
@RunWith(MockitoJUnitRunner.class)
@@ -50,6 +50,7 @@ public class CachingKeyValuePartTreeQueryUnitTests {
5050
@Mock ProjectionFactory projectionFactoryMock;
5151

5252
@Before
53+
@SuppressWarnings({ "unchecked", "rawtypes" })
5354
public void setUp() throws Exception {
5455

5556
when(metadataMock.getDomainType()).thenReturn((Class) Person.class);
@@ -60,7 +61,6 @@ public void setUp() throws Exception {
6061
* @see DATAKV-137
6162
*/
6263
@Test
63-
@SuppressWarnings({ "unchecked", "rawtypes" })
6464
public void cachedSpelExpressionShouldBeReusedWithNewContext() throws NoSuchMethodException, SecurityException {
6565

6666
QueryMethod qm = new QueryMethod(Repo.class.getMethod("findByFirstname", String.class), metadataMock,

src/test/java/org/springframework/data/map/AbstractRepositoryUnitTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ public void projectsResultToDynamicInterface() {
203203
protected KeyValueRepositoryFactory createKeyValueRepositoryFactory(KeyValueOperations operations) {
204204
return new KeyValueRepositoryFactory(operations);
205205
}
206-
206+
207207
protected abstract T getRepository(KeyValueRepositoryFactory factory);
208208

209209
public static interface PersonRepository extends CrudRepository<Person, String>, KeyValueRepository<Person, String> {

src/test/java/org/springframework/data/map/CachingQuerySimpleKeyValueRepositoryUnitTests.java

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,23 @@
1515
*/
1616
package org.springframework.data.map;
1717

18-
import static org.hamcrest.Matchers.hasItems;
19-
import static org.junit.Assert.assertThat;
20-
21-
import org.junit.Test;
2218
import org.springframework.data.keyvalue.core.KeyValueOperations;
2319
import org.springframework.data.keyvalue.repository.query.CachingKeyValuePartTreeQuery;
2420
import org.springframework.data.keyvalue.repository.query.SpelQueryCreator;
2521
import org.springframework.data.keyvalue.repository.support.KeyValueRepositoryFactory;
2622
import org.springframework.data.keyvalue.repository.support.SimpleKeyValueRepository;
27-
import org.springframework.data.map.AbstractRepositoryUnitTests.PersonRepository;
2823

2924
/**
30-
* Unit tests for {@link SimpleKeyValueRepository} using {@link CachingKeyValuePartTreeQuery} and {@link SpelQueryCreator}.
31-
*
25+
* Unit tests for {@link SimpleKeyValueRepository} using {@link CachingKeyValuePartTreeQuery} and
26+
* {@link SpelQueryCreator}.
27+
*
3228
* @author Mark Paluch
29+
* @author Christoph Strobl
3330
*/
34-
public class CachingQuerySimpleKeyValueRepositoryUnitTests extends AbstractRepositoryUnitTests<PersonRepository> {
31+
public class CachingQuerySimpleKeyValueRepositoryUnitTests extends SimpleKeyValueRepositoryUnitTests {
3532

3633
@Override
3734
protected KeyValueRepositoryFactory createKeyValueRepositoryFactory(KeyValueOperations operations) {
3835
return new KeyValueRepositoryFactory(operations, SpelQueryCreator.class, CachingKeyValuePartTreeQuery.class);
3936
}
40-
41-
@Override
42-
protected PersonRepository getRepository(KeyValueRepositoryFactory factory) {
43-
return factory.getRepository(PersonRepository.class);
44-
}
4537
}

0 commit comments

Comments
 (0)