diff --git a/pom.xml b/pom.xml
index b9cbeaf1be..61b73c587d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
org.springframework.data
spring-data-jpa
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATAJPA-1110-SNAPSHOT
Spring Data JPA
Spring Data module for JPA repositories.
@@ -26,7 +26,7 @@
1.8.0.10
2.0.0
2.4.1
- 2.0.0.BUILD-SNAPSHOT
+ 2.0.0.DATACMNS-1058-SNAPSHOT
reuseReports
diff --git a/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java b/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
index 8b73be075d..b0c2313700 100644
--- a/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
+++ b/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
@@ -398,11 +398,13 @@ public List findAll(Specification spec, Sort sort) {
* @see org.springframework.data.repository.query.QueryByExampleExecutor#findOne(org.springframework.data.domain.Example)
*/
@Override
- public S findOne(Example example) {
+ public Optional findOne(Example example) {
+
try {
- return getQuery(new ExampleSpecification(example), example.getProbeType(), (Sort) null).getSingleResult();
+ return Optional
+ .of(getQuery(new ExampleSpecification(example), example.getProbeType(), (Sort) null).getSingleResult());
} catch (NoResultException e) {
- return null;
+ return Optional.empty();
}
}
diff --git a/src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java b/src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java
index f860519e60..068f90f119 100644
--- a/src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java
+++ b/src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java
@@ -15,9 +15,8 @@
*/
package org.springframework.data.jpa.repository;
-import static org.hamcrest.Matchers.*;
-import static org.hamcrest.Matchers.not;
-import static org.junit.Assert.*;
+import static org.assertj.core.api.Assertions.*;
+import static org.hamcrest.core.IsEqual.*;
import static org.springframework.data.domain.Example.*;
import static org.springframework.data.domain.ExampleMatcher.*;
import static org.springframework.data.domain.Sort.Direction.*;
@@ -43,7 +42,7 @@
import javax.persistence.criteria.Predicate;
import javax.persistence.criteria.Root;
-import org.hamcrest.Matchers;
+import org.hamcrest.core.IsNot;
import org.junit.Assume;
import org.junit.Before;
import org.junit.Ignore;
@@ -55,8 +54,6 @@
import org.springframework.dao.InvalidDataAccessApiUsageException;
import org.springframework.data.domain.Example;
import org.springframework.data.domain.ExampleMatcher;
-import org.springframework.data.domain.ExampleMatcher.GenericPropertyMatcher;
-import org.springframework.data.domain.ExampleMatcher.StringMatcher;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageImpl;
import org.springframework.data.domain.PageRequest;
@@ -65,6 +62,7 @@
import org.springframework.data.domain.Sort;
import org.springframework.data.domain.Sort.Direction;
import org.springframework.data.domain.Sort.Order;
+import org.springframework.data.domain.ExampleMatcher.*;
import org.springframework.data.jpa.domain.Specification;
import org.springframework.data.jpa.domain.sample.Address;
import org.springframework.data.jpa.domain.sample.Role;
@@ -130,7 +128,7 @@ public void testCreation() {
flushTestUsers();
- assertThat((Long) countQuery.getSingleResult(), is(before + 4));
+ assertThat((Long) countQuery.getSingleResult()).isEqualTo(before + 4L);
}
@Test
@@ -138,8 +136,7 @@ public void testRead() throws Exception {
flushTestUsers();
- User foundPerson = repository.findById(id).get();
- assertThat(firstUser.getFirstname(), is(foundPerson.getFirstname()));
+ assertThat(repository.findById(id)).map(User::getFirstname).contains(firstUser.getFirstname());
}
@Test
@@ -147,8 +144,8 @@ public void findsAllByGivenIds() {
flushTestUsers();
- Iterable result = repository.findAllById(Arrays.asList(firstUser.getId(), secondUser.getId()));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(repository.findAllById(Arrays.asList(firstUser.getId(), secondUser.getId()))).contains(firstUser,
+ secondUser);
}
@Test
@@ -156,32 +153,24 @@ public void testReadByIdReturnsNullForNotFoundEntities() {
flushTestUsers();
- assertThat(repository.findById(id * 27), is(java.util.Optional.empty()));
+ assertThat(repository.findById(id * 27)).isNotPresent();
}
@Test
public void savesCollectionCorrectly() throws Exception {
- List result = repository.saveAll(Arrays.asList(firstUser, secondUser, thirdUser));
- assertThat(result, is(notNullValue()));
- assertThat(result.size(), is(3));
- assertThat(result, hasItems(firstUser, secondUser, thirdUser));
+ assertThat(repository.saveAll(Arrays.asList(firstUser, secondUser, thirdUser))).hasSize(3).contains(firstUser,
+ secondUser, thirdUser);
}
@Test
public void savingNullCollectionIsNoOp() throws Exception {
-
- List result = repository.saveAll((Collection) null);
- assertThat(result, is(notNullValue()));
- assertThat(result.isEmpty(), is(true));
+ assertThat(repository.saveAll(null)).isEmpty();
}
@Test
public void savingEmptyCollectionIsNoOp() throws Exception {
-
- List result = repository.saveAll(new ArrayList());
- assertThat(result, is(notNullValue()));
- assertThat(result.isEmpty(), is(true));
+ assertThat(repository.saveAll(new ArrayList<>())).isEmpty();
}
@Test
@@ -192,16 +181,15 @@ public void testUpdate() {
User foundPerson = repository.findById(id).get();
foundPerson.setLastname("Schlicht");
- User updatedPerson = repository.findById(id).get();
- assertThat(updatedPerson.getFirstname(), is(foundPerson.getFirstname()));
+ assertThat(repository.findById(id)).map(User::getFirstname).contains(foundPerson.getFirstname());
}
@Test
public void existReturnsWhetherAnEntityCanBeLoaded() throws Exception {
flushTestUsers();
- assertThat(repository.existsById(id), is(true));
- assertThat(repository.existsById(id * 27), is(false));
+ assertThat(repository.existsById(id)).isTrue();
+ assertThat(repository.existsById(id * 27)).isFalse();
}
@Test
@@ -210,8 +198,9 @@ public void deletesAUserById() {
flushTestUsers();
repository.deleteById(firstUser.getId());
- assertThat(repository.existsById(id), is(false));
- assertThat(repository.findById(id), is(java.util.Optional.empty()));
+
+ assertThat(repository.existsById(id)).isFalse();
+ assertThat(repository.findById(id)).isNotPresent();
}
@Test
@@ -220,21 +209,18 @@ public void testDelete() {
flushTestUsers();
repository.delete(firstUser);
- assertThat(repository.existsById(id), is(false));
- assertThat(repository.findById(id), is(java.util.Optional.empty()));
+
+ assertThat(repository.existsById(id)).isFalse();
+ assertThat(repository.findById(id)).isNotPresent();
}
@Test
public void returnsAllSortedCorrectly() throws Exception {
flushTestUsers();
- List result = repository.findAll(Sort.by(ASC, "lastname"));
- assertThat(result, is(notNullValue()));
- assertThat(result.size(), is(4));
- assertThat(result.get(0), is(secondUser));
- assertThat(result.get(1), is(firstUser));
- assertThat(result.get(2), is(thirdUser));
- assertThat(result.get(3), is(fourthUser));
+
+ assertThat(repository.findAll(Sort.by(ASC, "lastname"))).hasSize(4).containsExactly(secondUser, firstUser,
+ thirdUser, fourthUser);
}
@Test // DATAJPA-296
@@ -245,12 +231,8 @@ public void returnsAllIgnoreCaseSortedCorrectly() throws Exception {
Order order = new Order(ASC, "firstname").ignoreCase();
List result = repository.findAll(Sort.by(order));
- assertThat(result, is(notNullValue()));
- assertThat(result.size(), is(4));
- assertThat(result.get(0), is(thirdUser));
- assertThat(result.get(1), is(secondUser));
- assertThat(result.get(2), is(fourthUser));
- assertThat(result.get(3), is(firstUser));
+ assertThat(repository.findAll(Sort.by(order))).hasSize(4).containsExactly(thirdUser, secondUser, fourthUser,
+ firstUser);
}
@Test
@@ -261,9 +243,9 @@ public void deleteColletionOfEntities() {
long before = repository.count();
repository.deleteAll(Arrays.asList(firstUser, secondUser));
- assertThat(repository.existsById(firstUser.getId()), is(false));
- assertThat(repository.existsById(secondUser.getId()), is(false));
- assertThat(repository.count(), is(before - 2));
+ assertThat(repository.existsById(firstUser.getId())).isFalse();
+ assertThat(repository.existsById(secondUser.getId())).isFalse();
+ assertThat(repository.count()).isEqualTo(before - 2);
}
@Test
@@ -274,9 +256,10 @@ public void batchDeleteColletionOfEntities() {
long before = repository.count();
repository.deleteInBatch(Arrays.asList(firstUser, secondUser));
- assertThat(repository.existsById(firstUser.getId()), is(false));
- assertThat(repository.existsById(secondUser.getId()), is(false));
- assertThat(repository.count(), is(before - 2));
+
+ assertThat(repository.existsById(firstUser.getId())).isFalse();
+ assertThat(repository.existsById(secondUser.getId())).isFalse();
+ assertThat(repository.count()).isEqualTo(before - 2);
}
@Test
@@ -292,7 +275,7 @@ public void executesManipulatingQuery() throws Exception {
repository.renameAllUsersTo("newLastname");
long expected = repository.count();
- assertThat(repository.findByLastname("newLastname").size(), is(Long.valueOf(expected).intValue()));
+ assertThat(repository.findByLastname("newLastname").size()).isEqualTo(Long.valueOf(expected).intValue());
}
@Test
@@ -308,15 +291,12 @@ public void testFindByLastname() throws Exception {
flushTestUsers();
- List byName = repository.findByLastname("Gierke");
-
- assertThat(byName.size(), is(1));
- assertThat(byName.get(0), is(firstUser));
+ assertThat(repository.findByLastname("Gierke")).containsOnly(firstUser);
}
/**
* Tests, that searching by the email address of the reference user returns exactly that instance.
- *
+ *
* @throws Exception
*/
@Test
@@ -324,10 +304,7 @@ public void testFindByEmailAddress() throws Exception {
flushTestUsers();
- User byName = repository.findByEmailAddress("gierke@synyx.de");
-
- assertThat(byName, is(notNullValue()));
- assertThat(byName, is(firstUser));
+ assertThat(repository.findByEmailAddress("gierke@synyx.de")).isEqualTo(firstUser);
}
/**
@@ -338,13 +315,13 @@ public void testReadAll() {
flushTestUsers();
- assertThat(repository.count(), is(4L));
- assertThat(repository.findAll(), hasItems(firstUser, secondUser, thirdUser, fourthUser));
+ assertThat(repository.count()).isEqualTo(4L);
+ assertThat(repository.findAll()).contains(firstUser, secondUser, thirdUser, fourthUser);
}
/**
* Tests that all users get deleted by triggering {@link UserRepository#deleteAll()}.
- *
+ *
* @throws Exception
*/
@Test
@@ -354,7 +331,7 @@ public void deleteAll() throws Exception {
repository.deleteAll();
- assertThat(repository.count(), is(0L));
+ assertThat(repository.count()).isZero();
}
@Test // DATAJPA-137
@@ -364,7 +341,7 @@ public void deleteAllInBatch() {
repository.deleteAllInBatch();
- assertThat(repository.count(), is(0L));
+ assertThat(repository.count()).isZero();
}
/**
@@ -381,12 +358,11 @@ public void testCascadesPersisting() {
// Fetches first user from database
User firstReferenceUser = repository.findById(firstUser.getId()).get();
- assertThat(firstReferenceUser, is(firstUser));
+ assertThat(firstReferenceUser).isEqualTo(firstUser);
// Fetch colleagues and assert link
Set colleagues = firstReferenceUser.getColleagues();
- assertThat(colleagues.size(), is(1));
- assertThat(colleagues.contains(secondUser), is(true));
+ assertThat(colleagues).containsOnly(secondUser);
}
/**
@@ -415,8 +391,7 @@ public void testMergingCascadesCollegueas() {
User reference = repository.findById(firstUser.getId()).get();
Set colleagues = reference.getColleagues();
- assertThat(colleagues, is(notNullValue()));
- assertThat(colleagues.size(), is(2));
+ assertThat(colleagues).hasSize(2);
}
@Test
@@ -428,7 +403,7 @@ public void testCountsCorrectly() {
user.setEmailAddress("gierke@synyx.de");
repository.save(user);
- assertThat(repository.count() == count + 1, is(true));
+ assertThat(repository.count()).isEqualTo(count + 1);
}
@Test
@@ -446,35 +421,35 @@ public void testOverwritingFinder() {
@Test
public void testUsesQueryAnnotation() {
- assertThat(repository.findByAnnotatedQuery("gierke@synyx.de"), is(nullValue()));
+ assertThat(repository.findByAnnotatedQuery("gierke@synyx.de")).isNull();
}
@Test
public void testExecutionOfProjectingMethod() {
flushTestUsers();
- assertThat(repository.countWithFirstname("Oliver").longValue(), is(1L));
+ assertThat(repository.countWithFirstname("Oliver")).isEqualTo(1L);
}
@Test
public void executesSpecificationCorrectly() {
flushTestUsers();
- assertThat(repository.findAll(where(userHasFirstname("Oliver"))).size(), is(1));
+ assertThat(repository.findAll(where(userHasFirstname("Oliver")))).hasSize(1);
}
@Test
public void executesSingleEntitySpecificationCorrectly() throws Exception {
flushTestUsers();
- assertThat(repository.findOne(userHasFirstname("Oliver")), is(firstUser));
+ assertThat(repository.findOne(userHasFirstname("Oliver"))).isEqualTo(firstUser);
}
@Test
public void returnsNullIfNoEntityFoundForSingleEntitySpecification() throws Exception {
flushTestUsers();
- assertThat(repository.findOne(userHasLastname("Beauford")), is(nullValue()));
+ assertThat(repository.findOne(userHasLastname("Beauford"))).isNull();
}
@Test(expected = IncorrectResultSizeDataAccessException.class)
@@ -489,7 +464,7 @@ public void executesCombinedSpecificationsCorrectly() {
flushTestUsers();
Specification spec = where(userHasFirstname("Oliver")).or(userHasLastname("Arrasz"));
- assertThat(repository.findAll(spec), hasSize(2));
+ assertThat(repository.findAll(spec)).hasSize(2);
}
@Test // DATAJPA-253
@@ -497,10 +472,8 @@ public void executesNegatingSpecificationCorrectly() {
flushTestUsers();
Specification spec = not(userHasFirstname("Oliver")).and(userHasLastname("Arrasz"));
- List result = repository.findAll(spec);
- assertThat(result, hasSize(1));
- assertThat(result, hasItem(secondUser));
+ assertThat(repository.findAll(spec)).containsOnly(secondUser);
}
@Test
@@ -510,9 +483,9 @@ public void executesCombinedSpecificationsWithPageableCorrectly() {
Specification spec = where(userHasFirstname("Oliver")).or(userHasLastname("Arrasz"));
Page users = repository.findAll(spec, PageRequest.of(0, 1));
- assertThat(users.getSize(), is(1));
- assertThat(users.hasPrevious(), is(false));
- assertThat(users.getTotalElements(), is(2L));
+ assertThat(users.getSize()).isEqualTo(1);
+ assertThat(users.hasPrevious()).isFalse();
+ assertThat(users.getTotalElements()).isEqualTo(2L);
}
@Test
@@ -521,8 +494,7 @@ public void executesMethodWithAnnotatedNamedParametersCorrectly() throws Excepti
firstUser = repository.save(firstUser);
secondUser = repository.save(secondUser);
- assertTrue(
- repository.findByLastnameOrFirstname("Oliver", "Arrasz").containsAll(Arrays.asList(firstUser, secondUser)));
+ assertThat(repository.findByLastnameOrFirstname("Oliver", "Arrasz")).contains(firstUser, secondUser);
}
@Test
@@ -531,9 +503,7 @@ public void executesMethodWithNamedParametersCorrectlyOnMethodsWithQueryCreation
firstUser = repository.save(firstUser);
secondUser = repository.save(secondUser);
- List result = repository.findByFirstnameOrLastname("Oliver", "Arrasz");
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(repository.findByFirstnameOrLastname("Oliver", "Arrasz")).containsOnly(firstUser, secondUser);
}
@Test
@@ -541,11 +511,8 @@ public void executesLikeAndOrderByCorrectly() throws Exception {
flushTestUsers();
- List result = repository.findByLastnameLikeOrderByFirstnameDesc("%r%");
- assertThat(result.size(), is(3));
- assertEquals(fourthUser, result.get(0));
- assertEquals(firstUser, result.get(1));
- assertEquals(secondUser, result.get(2));
+ assertThat(repository.findByLastnameLikeOrderByFirstnameDesc("%r%")).hasSize(3).containsExactly(fourthUser,
+ firstUser, secondUser);
}
@Test
@@ -553,9 +520,7 @@ public void executesNotLikeCorrectly() throws Exception {
flushTestUsers();
- List result = repository.findByLastnameNotLike("%er%");
- assertThat(result.size(), is(3));
- assertThat(result, hasItems(secondUser, thirdUser, fourthUser));
+ assertThat(repository.findByLastnameNotLike("%er%")).containsOnly(secondUser, thirdUser, fourthUser);
}
@Test
@@ -563,9 +528,7 @@ public void executesSimpleNotCorrectly() throws Exception {
flushTestUsers();
- List result = repository.findByLastnameNot("Gierke");
- assertThat(result.size(), is(3));
- assertThat(result, hasItems(secondUser, thirdUser, fourthUser));
+ assertThat(repository.findByLastnameNot("Gierke")).containsOnly(secondUser, thirdUser, fourthUser);
}
@Test
@@ -588,14 +551,14 @@ public void returnsSamePageIfNoSpecGiven() throws Exception {
Pageable pageable = PageRequest.of(0, 1);
flushTestUsers();
- assertThat(repository.findAll((Specification) null, pageable), is(repository.findAll(pageable)));
+ assertThat(repository.findAll((Specification) null, pageable)).isEqualTo(repository.findAll(pageable));
}
@Test
public void returnsAllAsPageIfNoPageableIsGiven() throws Exception {
flushTestUsers();
- assertThat(repository.findAll((Pageable) null), is((Page) new PageImpl(repository.findAll())));
+ assertThat(repository.findAll((Pageable) null)).isEqualTo(new PageImpl(repository.findAll()));
}
@Test
@@ -606,15 +569,14 @@ public void removeDetachedObject() throws Exception {
em.detach(firstUser);
repository.delete(firstUser);
- assertThat(repository.count(), is(3L));
+ assertThat(repository.count()).isEqualTo(3L);
}
@Test
public void executesPagedSpecificationsCorrectly() throws Exception {
Page result = executeSpecWithSort(null);
- assertThat(result.getContent(), anyOf(hasItem(firstUser), hasItem(thirdUser)));
- assertThat(result.getContent(), not(hasItem(secondUser)));
+ assertThat(result.getContent()).isSubsetOf(firstUser, thirdUser);
}
@Test
@@ -622,9 +584,7 @@ public void executesPagedSpecificationsWithSortCorrectly() throws Exception {
Page result = executeSpecWithSort(Sort.by(Direction.ASC, "lastname"));
- assertThat(result.getContent(), hasItem(firstUser));
- assertThat(result.getContent(), not(hasItem(secondUser)));
- assertThat(result.getContent(), not(hasItem(thirdUser)));
+ assertThat(result.getContent()).contains(firstUser).doesNotContain(secondUser, thirdUser);
}
@Test
@@ -632,9 +592,7 @@ public void executesPagedSpecificationWithSortCorrectly2() throws Exception {
Page result = executeSpecWithSort(Sort.by(Direction.DESC, "lastname"));
- assertThat(result.getContent(), hasItem(thirdUser));
- assertThat(result.getContent(), not(hasItem(secondUser)));
- assertThat(result.getContent(), not(hasItem(firstUser)));
+ assertThat(result.getContent()).contains(thirdUser).doesNotContain(secondUser, firstUser);
}
@Test
@@ -646,14 +604,8 @@ public void executesQueryMethodWithDeepTraversalCorrectly() throws Exception {
thirdUser.setManager(firstUser);
repository.saveAll(Arrays.asList(firstUser, thirdUser));
- List result = repository.findByManagerLastname("Arrasz");
-
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
-
- result = repository.findByManagerLastname("Gierke");
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(thirdUser));
+ assertThat(repository.findByManagerLastname("Arrasz")).containsOnly(firstUser);
+ assertThat(repository.findByManagerLastname("Gierke")).containsOnly(thirdUser);
}
@Test
@@ -665,24 +617,17 @@ public void executesFindByColleaguesLastnameCorrectly() throws Exception {
thirdUser.addColleague(firstUser);
repository.saveAll(Arrays.asList(firstUser, thirdUser));
- List result = repository.findByColleaguesLastname(secondUser.getLastname());
-
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
+ assertThat(repository.findByColleaguesLastname(secondUser.getLastname())).containsOnly(firstUser);
- result = repository.findByColleaguesLastname("Gierke");
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(thirdUser, secondUser));
+ assertThat(repository.findByColleaguesLastname("Gierke")).containsOnly(thirdUser, secondUser);
}
@Test
public void executesFindByNotNullLastnameCorrectly() throws Exception {
flushTestUsers();
- List result = repository.findByLastnameNotNull();
- assertThat(result.size(), is(4));
- assertThat(result, hasItems(firstUser, secondUser, thirdUser, fourthUser));
+ assertThat(repository.findByLastnameNotNull()).containsOnly(firstUser, secondUser, thirdUser, fourthUser);
}
@Test
@@ -691,10 +636,7 @@ public void executesFindByNullLastnameCorrectly() throws Exception {
flushTestUsers();
User forthUser = repository.save(new User("Foo", null, "email@address.com"));
- List result = repository.findByLastnameNull();
-
- assertThat(result.size(), is(1));
- assertThat(result, hasItems(forthUser));
+ assertThat(repository.findByLastnameNull()).containsOnly(forthUser);
}
@Test
@@ -702,13 +644,8 @@ public void findsSortedByLastname() throws Exception {
flushTestUsers();
- List result = repository.findByEmailAddressLike("%@%", Sort.by(Direction.ASC, "lastname"));
-
- assertThat(result.size(), is(4));
- assertThat(result.get(0), is(secondUser));
- assertThat(result.get(1), is(firstUser));
- assertThat(result.get(2), is(thirdUser));
- assertThat(result.get(3), is(fourthUser));
+ assertThat(repository.findByEmailAddressLike("%@%", Sort.by(Direction.ASC, "lastname"))).containsExactly(secondUser,
+ firstUser, thirdUser, fourthUser);
}
@Test
@@ -716,9 +653,7 @@ public void findsUsersBySpringDataNamedQuery() {
flushTestUsers();
- List result = repository.findBySpringDataNamedQuery("Gierke");
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
+ assertThat(repository.findBySpringDataNamedQuery("Gierke")).containsOnly(firstUser);
}
@Test // DATADOC-86
@@ -727,7 +662,7 @@ public void readsPageWithGroupByClauseCorrectly() {
flushTestUsers();
Page result = repository.findByLastnameGrouped(PageRequest.of(0, 10));
- assertThat(result.getTotalPages(), is(1));
+ assertThat(result.getTotalPages()).isEqualTo(1);
}
@Test
@@ -735,9 +670,7 @@ public void executesLessThatOrEqualQueriesCorrectly() {
flushTestUsers();
- List result = repository.findByAgeLessThanEqual(35);
- assertThat(result.size(), is(3));
- assertThat(result, hasItems(firstUser, secondUser, fourthUser));
+ assertThat(repository.findByAgeLessThanEqual(35)).containsOnly(firstUser, secondUser, fourthUser);
}
@Test
@@ -745,9 +678,7 @@ public void executesGreaterThatOrEqualQueriesCorrectly() {
flushTestUsers();
- List result = repository.findByAgeGreaterThanEqual(35);
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(secondUser, thirdUser));
+ assertThat(repository.findByAgeGreaterThanEqual(35)).containsOnly(secondUser, thirdUser);
}
@Test // DATAJPA-117
@@ -755,10 +686,7 @@ public void executesNativeQueryCorrectly() {
flushTestUsers();
- List result = repository.findNativeByLastname("Matthews");
-
- assertThat(result, hasItem(thirdUser));
- assertThat(result.size(), is(1));
+ assertThat(repository.findNativeByLastname("Matthews")).containsOnly(thirdUser);
}
@Test // DATAJPA-132
@@ -768,9 +696,7 @@ public void executesFinderWithTrueKeywordCorrectly() {
firstUser.setActive(false);
repository.save(firstUser);
- List result = repository.findByActiveTrue();
- assertThat(result.size(), is(3));
- assertThat(result, hasItems(secondUser, thirdUser, fourthUser));
+ assertThat(repository.findByActiveTrue()).containsOnly(secondUser, thirdUser, fourthUser);
}
@Test // DATAJPA-132
@@ -780,9 +706,7 @@ public void executesFinderWithFalseKeywordCorrectly() {
firstUser.setActive(false);
repository.save(firstUser);
- List result = repository.findByActiveFalse();
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
+ assertThat(repository.findByActiveFalse()).containsOnly(firstUser);
}
/**
@@ -797,8 +721,7 @@ public void executesAnnotatedCollectionMethodCorrectly() {
repository.save(firstUser);
List result = null; // repository.findColleaguesFor(firstUser);
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(thirdUser));
+ assertThat(result).containsOnly(thirdUser);
}
@Test // DATAJPA-188
@@ -806,9 +729,7 @@ public void executesFinderWithAfterKeywordCorrectly() {
flushTestUsers();
- List result = repository.findByCreatedAtAfter(secondUser.getCreatedAt());
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(thirdUser, fourthUser));
+ assertThat(repository.findByCreatedAtAfter(secondUser.getCreatedAt())).containsOnly(thirdUser, fourthUser);
}
@Test // DATAJPA-188
@@ -816,36 +737,31 @@ public void executesFinderWithBeforeKeywordCorrectly() {
flushTestUsers();
- List result = repository.findByCreatedAtBefore(thirdUser.getCreatedAt());
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(repository.findByCreatedAtBefore(thirdUser.getCreatedAt())).containsOnly(firstUser, secondUser);
}
@Test // DATAJPA-180
public void executesFinderWithStartingWithCorrectly() {
flushTestUsers();
- List result = repository.findByFirstnameStartingWith("Oli");
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
+
+ assertThat(repository.findByFirstnameStartingWith("Oli")).containsOnly(firstUser);
}
@Test // DATAJPA-180
public void executesFinderWithEndingWithCorrectly() {
flushTestUsers();
- List result = repository.findByFirstnameEndingWith("er");
- assertThat(result.size(), is(1));
- assertThat(result, hasItem(firstUser));
+
+ assertThat(repository.findByFirstnameEndingWith("er")).containsOnly(firstUser);
}
@Test // DATAJPA-180
public void executesFinderWithContainingCorrectly() {
flushTestUsers();
- List result = repository.findByFirstnameContaining("a");
- assertThat(result.size(), is(2));
- assertThat(result, hasItems(secondUser, thirdUser));
+
+ assertThat(repository.findByFirstnameContaining("a")).containsOnly(secondUser, thirdUser);
}
@Test // DATAJPA-201
@@ -853,17 +769,15 @@ public void allowsExecutingPageableMethodWithNullPageable() {
flushTestUsers();
- List users = repository.findByFirstname("Oliver", null);
- assertThat(users.size(), is(1));
- assertThat(users, hasItem(firstUser));
+ assertThat(repository.findByFirstname("Oliver", null)).containsOnly(firstUser);
Page page = repository.findByFirstnameIn(null, "Oliver");
- assertThat(page.getNumberOfElements(), is(1));
- assertThat(page.getContent(), hasItem(firstUser));
+ assertThat(page.getNumberOfElements()).isEqualTo(1);
+ assertThat(page.getContent()).contains(firstUser);
page = repository.findAll((Pageable) null);
- assertThat(page.getNumberOfElements(), is(4));
- assertThat(page.getContent(), hasItems(firstUser, secondUser, thirdUser, fourthUser));
+ assertThat(page.getNumberOfElements()).isEqualTo(4);
+ assertThat(page.getContent()).contains(firstUser, secondUser, thirdUser, fourthUser);
}
@Test // DATAJPA-207
@@ -873,8 +787,8 @@ public void executesNativeQueryForNonEntitiesCorrectly() {
List result = repository.findOnesByNativeQuery();
- assertThat(result.size(), is(4));
- assertThat(result, hasItem(1));
+ assertThat(result.size()).isEqualTo(4);
+ assertThat(result).contains(1);
}
@Test // DATAJPA-232
@@ -882,14 +796,11 @@ public void handlesIterableOfIdsCorrectly() {
flushTestUsers();
- Set set = new HashSet();
+ Set set = new HashSet<>();
set.add(firstUser.getId());
set.add(secondUser.getId());
- Iterable result = repository.findAllById(set);
-
- assertThat(result, is(Matchers. iterableWithSize(2)));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(repository.findAllById(set)).containsOnly(firstUser, secondUser);
}
protected void flushTestUsers() {
@@ -905,25 +816,25 @@ protected void flushTestUsers() {
id = firstUser.getId();
- assertThat(id, is(notNullValue()));
- assertThat(secondUser.getId(), is(notNullValue()));
- assertThat(thirdUser.getId(), is(notNullValue()));
- assertThat(fourthUser.getId(), is(notNullValue()));
+ assertThat(id).isNotNull();
+ assertThat(secondUser.getId()).isNotNull();
+ assertThat(thirdUser.getId()).isNotNull();
+ assertThat(fourthUser.getId()).isNotNull();
- assertThat(repository.existsById(id), is(true));
- assertThat(repository.existsById(secondUser.getId()), is(true));
- assertThat(repository.existsById(thirdUser.getId()), is(true));
- assertThat(repository.existsById(fourthUser.getId()), is(true));
+ assertThat(repository.existsById(id)).isTrue();
+ assertThat(repository.existsById(secondUser.getId())).isTrue();
+ assertThat(repository.existsById(thirdUser.getId())).isTrue();
+ assertThat(repository.existsById(fourthUser.getId())).isTrue();
}
private static void assertSameElements(Collection first, Collection second) {
for (T element : first) {
- assertThat(element, isIn(second));
+ assertThat(element).isIn(second);
}
for (T element : second) {
- assertThat(element, isIn(first));
+ assertThat(element).isIn(first);
}
}
@@ -933,7 +844,7 @@ private void assertDeleteCallDoesNotDeleteAnything(List collection) {
long count = repository.count();
repository.deleteAll(collection);
- assertThat(repository.count(), is(count));
+ assertThat(repository.count()).isEqualTo(count);
}
@Test
@@ -945,7 +856,7 @@ public void ordersByReferencedEntityCorrectly() {
Page all = repository.findAll(PageRequest.of(0, 10, Sort.by("manager.id")));
- assertThat(all.getContent().isEmpty(), is(false));
+ assertThat(all.getContent().isEmpty()).isFalse();
}
@Test // DATAJPA-252
@@ -955,7 +866,7 @@ public void bindsSortingToOuterJoinCorrectly() {
// Managers not set, make sure adding the sort does not rule out those Users
Page result = repository.findAllPaged(PageRequest.of(0, 10, Sort.by("manager.lastname")));
- assertThat(result.getContent(), hasSize((int) repository.count()));
+ assertThat(result.getContent()).hasSize((int) repository.count());
}
@Test // DATAJPA-277
@@ -969,8 +880,8 @@ public Predicate toPredicate(Root root, CriteriaQuery> query, CriteriaBu
}
}, PageRequest.of(0, 20, Sort.by("manager.lastname")));
- assertThat(page.getNumberOfElements(), is(1));
- assertThat(page, hasItem(firstUser));
+ assertThat(page.getNumberOfElements()).isEqualTo(1);
+ assertThat(page).containsOnly(firstUser);
}
@Test // DATAJPA-346
@@ -984,12 +895,12 @@ public void shouldGenerateLeftOuterJoinInfindAllWithPaginationAndSortOnNestedPro
flushTestUsers();
Page pages = repository.findAll(PageRequest.of(0, 4, Sort.by(Sort.Direction.ASC, "manager.firstname")));
- assertThat(pages.getSize(), is(4));
- assertThat(pages.getContent().get(0).getManager(), is(nullValue()));
- assertThat(pages.getContent().get(1).getManager(), is(nullValue()));
- assertThat(pages.getContent().get(2).getManager().getFirstname(), is("Joachim"));
- assertThat(pages.getContent().get(3).getManager().getFirstname(), is("Oliver"));
- assertThat(pages.getTotalElements(), is(4L));
+ assertThat(pages.getSize()).isEqualTo(4);
+ assertThat(pages.getContent().get(0).getManager()).isNull();
+ assertThat(pages.getContent().get(1).getManager()).isNull();
+ assertThat(pages.getContent().get(2).getManager().getFirstname()).isEqualTo("Joachim");
+ assertThat(pages.getContent().get(3).getManager().getFirstname()).isEqualTo("Oliver");
+ assertThat(pages.getTotalElements()).isEqualTo(4L);
}
@Test // DATAJPA-292
@@ -999,8 +910,7 @@ public void executesManualQueryWithPositionLikeExpressionCorrectly() {
List result = repository.findByFirstnameLike("Da");
- assertThat(result, hasSize(1));
- assertThat(result, hasItem(thirdUser));
+ assertThat(result).containsOnly(thirdUser);
}
@Test // DATAJPA-292
@@ -1010,8 +920,7 @@ public void executesManualQueryWithNamedLikeExpressionCorrectly() {
List result = repository.findByFirstnameLikeNamed("Da");
- assertThat(result, hasSize(1));
- assertThat(result, hasItem(thirdUser));
+ assertThat(result).containsOnly(thirdUser);
}
@Test // DATAJPA-231
@@ -1019,7 +928,7 @@ public void executesDerivedCountQueryToLong() {
flushTestUsers();
- assertThat(repository.countByLastname("Matthews"), is(1L));
+ assertThat(repository.countByLastname("Matthews")).isEqualTo(1L);
}
@Test // DATAJPA-231
@@ -1027,7 +936,7 @@ public void executesDerivedCountQueryToInt() {
flushTestUsers();
- assertThat(repository.countUsersByFirstname("Dave"), is(1));
+ assertThat(repository.countUsersByFirstname("Dave")).isEqualTo(1);
}
@Test // DATAJPA-231
@@ -1035,15 +944,15 @@ public void executesDerivedExistsQuery() {
flushTestUsers();
- assertThat(repository.existsByLastname("Matthews"), is(true));
- assertThat(repository.existsByLastname("Hans Peter"), is(false));
+ assertThat(repository.existsByLastname("Matthews")).isEqualTo(true);
+ assertThat(repository.existsByLastname("Hans Peter")).isEqualTo(false);
}
@Test // DATAJPA-332
public void findAllReturnsEmptyIterableIfNoIdsGiven() {
- assertThat(repository.findAllById(Collections. emptySet()), is(emptyIterable()));
- assertThat(repository.findAllById((Iterable) null), is(emptyIterable()));
+ assertThat(repository.findAllById(Collections. emptySet())).isEmpty();
+ assertThat(repository.findAllById((Iterable) null)).isEmpty();
}
@Test // DATAJPA-391
@@ -1052,8 +961,7 @@ public void executesManuallyDefinedQueryWithFieldProjection() {
flushTestUsers();
List lastname = repository.findFirstnamesByLastname("Matthews");
- assertThat(lastname, hasSize(1));
- assertThat(lastname, hasItem("Dave"));
+ assertThat(lastname).containsOnly("Dave");
}
@Test // DATAJPA-83
@@ -1062,7 +970,7 @@ public void looksUpEntityReference() {
flushTestUsers();
User result = repository.getOne(firstUser.getId());
- assertThat(result, is(firstUser));
+ assertThat(result).isEqualTo(firstUser);
}
@Test // DATAJPA-415
@@ -1072,8 +980,7 @@ public void invokesQueryWithVarargsParametersCorrectly() {
Collection result = repository.findByIdIn(firstUser.getId(), secondUser.getId());
- assertThat(result, hasSize(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(result).containsOnly(firstUser, secondUser);
}
@Test // DATAJPA-415
@@ -1085,8 +992,8 @@ public void shouldSupportModifyingQueryWithVarArgs() {
fourthUser.getId());
long expectedCount = repository.count();
- assertThat(repository.findByActiveFalse().size(), is((int) expectedCount));
- assertThat(repository.findByActiveTrue().size(), is(0));
+ assertThat(repository.findByActiveFalse().size()).isEqualTo((int) expectedCount);
+ assertThat(repository.findByActiveTrue().size()).isEqualTo(0);
}
@Test // DATAJPA-405
@@ -1094,10 +1001,7 @@ public void executesFinderWithOrderClauseOnly() {
flushTestUsers();
- List result = repository.findAllByOrderByLastnameAsc();
-
- assertThat(result, hasSize(4));
- assertThat(result, contains(secondUser, firstUser, thirdUser, fourthUser));
+ assertThat(repository.findAllByOrderByLastnameAsc()).containsOnly(secondUser, firstUser, thirdUser, fourthUser);
}
@Test // DATAJPA-427
@@ -1109,7 +1013,7 @@ public void sortByAssociationPropertyShouldUseLeftOuterJoin() {
List result = repository.findAll(Sort.by(Sort.Direction.ASC, "colleagues.id"));
- assertThat(result, hasSize(4));
+ assertThat(result).hasSize(4);
}
@Test // DATAJPA-427
@@ -1121,7 +1025,7 @@ public void sortByAssociationPropertyInPageableShouldUseLeftOuterJoin() {
Page page = repository.findAll(PageRequest.of(0, 10, Sort.by(Sort.Direction.ASC, "colleagues.id")));
- assertThat(page.getContent(), hasSize(4));
+ assertThat(page.getContent()).hasSize(4);
}
@Test // DATAJPA-427
@@ -1132,8 +1036,8 @@ public void sortByEmbeddedProperty() {
Page page = repository.findAll(PageRequest.of(0, 10, Sort.by(Sort.Direction.ASC, "address.streetName")));
- assertThat(page.getContent(), hasSize(4));
- assertThat(page.getContent().get(3), is(thirdUser));
+ assertThat(page.getContent()).hasSize(4);
+ assertThat(page.getContent().get(3)).isEqualTo(thirdUser);
}
@Test // DATAJPA-454
@@ -1145,9 +1049,8 @@ public void findsUserByBinaryDataReference() throws Exception {
flushTestUsers();
List result = repository.findByBinaryData(data);
- assertThat(result, hasSize(1));
- assertThat(result, hasItem(firstUser));
- assertThat(result.get(0).getBinaryData(), is(data));
+ assertThat(result).containsOnly(firstUser);
+ assertThat(result.get(0).getBinaryData()).isEqualTo(data);
}
@Test // DATAJPA-461
@@ -1157,8 +1060,7 @@ public void customFindByQueryWithPositionalVarargsParameters() {
Collection result = repository.findByIdsCustomWithPositionalVarArgs(firstUser.getId(), secondUser.getId());
- assertThat(result, hasSize(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(result).containsOnly(firstUser, secondUser);
}
@Test // DATAJPA-461
@@ -1168,8 +1070,7 @@ public void customFindByQueryWithNamedVarargsParameters() {
Collection result = repository.findByIdsCustomWithNamedVarArgs(firstUser.getId(), secondUser.getId());
- assertThat(result, hasSize(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(result).containsOnly(firstUser, secondUser);
}
@Test // DATAJPA-464
@@ -1182,8 +1083,8 @@ public void saveAndFlushShouldSupportReturningSubTypesOfRepositoryEntity() {
SpecialUser savedUser = repository.saveAndFlush(user);
- assertThat(user.getFirstname(), is(savedUser.getFirstname()));
- assertThat(user.getEmailAddress(), is(savedUser.getEmailAddress()));
+ assertThat(user.getFirstname()).isEqualTo(savedUser.getFirstname());
+ assertThat(user.getEmailAddress()).isEqualTo(savedUser.getEmailAddress());
}
@Test // DATAJPA-218
@@ -1200,7 +1101,7 @@ public void findAllByUntypedExampleShouldReturnSubTypesOfRepositoryEntity() {
List result = repository
.findAll(Example.of(new User(), ExampleMatcher.matching().withIgnorePaths("age", "createdAt", "dateOfBirth")));
- assertThat(result, hasSize(5));
+ assertThat(result).hasSize(5);
}
@Test // DATAJPA-218
@@ -1217,7 +1118,7 @@ public void findAllByTypedUserExampleShouldReturnSubTypesOfRepositoryEntity() {
Example example = Example.of(new User(), matching().withIgnorePaths("age", "createdAt", "dateOfBirth"));
List result = repository.findAll(example);
- assertThat(result, hasSize(5));
+ assertThat(result).hasSize(5);
}
@Test // DATAJPA-218
@@ -1235,7 +1136,7 @@ public void findAllByTypedSpecialUserExampleShouldReturnSubTypesOfRepositoryEnti
matching().withIgnorePaths("age", "createdAt", "dateOfBirth"));
List result = repository.findAll(example);
- assertThat(result, hasSize(1));
+ assertThat(result).hasSize(1);
}
@Test // DATAJPA-491
@@ -1249,8 +1150,8 @@ public void sortByNestedAssociationPropertyWithSortInPageable() {
Page page = repository.findAll(PageRequest.of(0, 10, //
Sort.by(Sort.Direction.ASC, "manager.manager.firstname")));
- assertThat(page.getContent(), hasSize(4));
- assertThat(page.getContent().get(3), is(firstUser));
+ assertThat(page.getContent()).hasSize(4);
+ assertThat(page.getContent().get(3)).isEqualTo(firstUser);
}
@Test // DATAJPA-510
@@ -1264,8 +1165,8 @@ public void sortByNestedAssociationPropertyWithSortOrderIgnoreCaseInPageable() {
Page page = repository.findAll(PageRequest.of(0, 10, //
Sort.by(new Sort.Order(Direction.ASC, "manager.manager.firstname").ignoreCase())));
- assertThat(page.getContent(), hasSize(4));
- assertThat(page.getContent().get(3), is(firstUser));
+ assertThat(page.getContent()).hasSize(4);
+ assertThat(page.getContent().get(3)).isEqualTo(firstUser);
}
@Test // DATAJPA-496
@@ -1279,8 +1180,7 @@ public void findByElementCollectionAttribute() {
List result = repository.findByAttributesIn(new HashSet(Arrays.asList("cool", "hip")));
- assertThat(result, hasSize(2));
- assertThat(result, hasItems(firstUser, secondUser));
+ assertThat(result).containsOnly(firstUser, secondUser);
}
@Test // DATAJPA-460
@@ -1289,8 +1189,7 @@ public void deleteByShouldReturnListOfDeletedElementsWhenRetunTypeIsCollectionLi
flushTestUsers();
List result = repository.deleteByLastname(firstUser.getLastname());
- assertThat(result, hasItem(firstUser));
- assertThat(result, hasSize(1));
+ assertThat(result).containsOnly(firstUser);
}
@Test // DATAJPA-460
@@ -1299,7 +1198,7 @@ public void deleteByShouldRemoveElementsMatchingDerivedQuery() {
flushTestUsers();
repository.deleteByLastname(firstUser.getLastname());
- assertThat(repository.countByLastname(firstUser.getLastname()), is(0L));
+ assertThat(repository.countByLastname(firstUser.getLastname())).isEqualTo(0L);
}
@Test // DATAJPA-460
@@ -1307,7 +1206,7 @@ public void deleteByShouldReturnNumberOfEntitiesRemovedIfReturnTypeIsLong() {
flushTestUsers();
- assertThat(repository.removeByLastname(firstUser.getLastname()), is(1L));
+ assertThat(repository.removeByLastname(firstUser.getLastname())).isEqualTo(1L);
}
@Test // DATAJPA-460
@@ -1315,7 +1214,7 @@ public void deleteByShouldReturnZeroInCaseNoEntityHasBeenRemovedAndReturnTypeIsN
flushTestUsers();
- assertThat(repository.removeByLastname("bubu"), is(0L));
+ assertThat(repository.removeByLastname("bubu")).isEqualTo(0L);
}
@Test // DATAJPA-460
@@ -1323,7 +1222,7 @@ public void deleteByShouldReturnEmptyListInCaseNoEntityHasBeenRemovedAndReturnTy
flushTestUsers();
- assertThat(repository.deleteByLastname("dorfuaeB"), empty());
+ assertThat(repository.deleteByLastname("dorfuaeB")).isEmpty();
}
/**
@@ -1340,8 +1239,8 @@ public void findBinaryDataByIdJpaQl() throws Exception {
byte[] result = null; // repository.findBinaryDataByIdJpaQl(firstUser.getId());
- assertThat(result.length, is(data.length));
- assertThat(result, is(data));
+ assertThat(result.length).isEqualTo(data.length);
+ assertThat(result).isEqualTo(data);
}
@Test // DATAJPA-506
@@ -1353,8 +1252,8 @@ public void findBinaryDataByIdNative() throws Exception {
flushTestUsers();
byte[] result = repository.findBinaryDataByIdNative(firstUser.getId());
- assertThat(result.length, is(data.length));
- assertThat(result, is(data));
+ assertThat(result.length).isEqualTo(data.length);
+ assertThat(result).isEqualTo(data);
}
@Test // DATAJPA-456
@@ -1366,7 +1265,7 @@ public void findPaginatedExplicitQueryWithCountQueryProjection() {
Page result = repository.findAllByFirstnameLike("", PageRequest.of(0, 10));
- assertThat(result.getContent().size(), is(3));
+ assertThat(result.getContent().size()).isEqualTo(3);
}
@Test // DATAJPA-456
@@ -1376,7 +1275,7 @@ public void findPaginatedNamedQueryWithCountQueryProjection() {
Page result = repository.findByNamedQueryAndCountProjection("Gierke", PageRequest.of(0, 10));
- assertThat(result.getContent().size(), is(1));
+ assertThat(result.getContent().size()).isEqualTo(1);
}
@Test // DATAJPA-551
@@ -1386,8 +1285,8 @@ public void findOldestUser() {
User oldest = thirdUser;
- assertThat(repository.findFirstByOrderByAgeDesc(), is(oldest));
- assertThat(repository.findFirst1ByOrderByAgeDesc(), is(oldest));
+ assertThat(repository.findFirstByOrderByAgeDesc()).isEqualTo(oldest);
+ assertThat(repository.findFirst1ByOrderByAgeDesc()).isEqualTo(oldest);
}
@Test // DATAJPA-551
@@ -1397,8 +1296,8 @@ public void findYoungestUser() {
User youngest = firstUser;
- assertThat(repository.findTopByOrderByAgeAsc(), is(youngest));
- assertThat(repository.findTop1ByOrderByAgeAsc(), is(youngest));
+ assertThat(repository.findTopByOrderByAgeAsc()).isEqualTo(youngest);
+ assertThat(repository.findTop1ByOrderByAgeAsc()).isEqualTo(youngest);
}
@Test // DATAJPA-551
@@ -1409,8 +1308,8 @@ public void find2OldestUsers() {
User oldest1 = thirdUser;
User oldest2 = secondUser;
- assertThat(repository.findFirst2ByOrderByAgeDesc(), hasItems(oldest1, oldest2));
- assertThat(repository.findTop2ByOrderByAgeDesc(), hasItems(oldest1, oldest2));
+ assertThat(repository.findFirst2ByOrderByAgeDesc()).contains(oldest1, oldest2);
+ assertThat(repository.findTop2ByOrderByAgeDesc()).contains(oldest1, oldest2);
}
@Test // DATAJPA-551
@@ -1421,8 +1320,8 @@ public void find2YoungestUsers() {
User youngest1 = firstUser;
User youngest2 = fourthUser;
- assertThat(repository.findFirst2UsersBy(Sort.by(ASC, "age")), hasItems(youngest1, youngest2));
- assertThat(repository.findTop2UsersBy(Sort.by(ASC, "age")), hasItems(youngest1, youngest2));
+ assertThat(repository.findFirst2UsersBy(Sort.by(ASC, "age"))).contains(youngest1, youngest2);
+ assertThat(repository.findTop2UsersBy(Sort.by(ASC, "age"))).contains(youngest1, youngest2);
}
@Test // DATAJPA-551
@@ -1435,10 +1334,10 @@ public void find3YoungestUsersPageableWithPageSize2() {
User youngest3 = secondUser;
Page firstPage = repository.findFirst3UsersBy(PageRequest.of(0, 2, ASC, "age"));
- assertThat(firstPage.getContent(), hasItems(youngest1, youngest2));
+ assertThat(firstPage.getContent()).contains(youngest1, youngest2);
Page secondPage = repository.findFirst3UsersBy(PageRequest.of(1, 2, ASC, "age"));
- assertThat(secondPage.getContent(), hasItems(youngest3));
+ assertThat(secondPage.getContent()).contains(youngest3);
}
@Test // DATAJPA-551
@@ -1451,10 +1350,10 @@ public void find2YoungestUsersPageableWithPageSize3() {
User youngest3 = secondUser;
Page firstPage = repository.findFirst2UsersBy(PageRequest.of(0, 3, ASC, "age"));
- assertThat(firstPage.getContent(), hasItems(youngest1, youngest2));
+ assertThat(firstPage.getContent()).contains(youngest1, youngest2);
Page secondPage = repository.findFirst2UsersBy(PageRequest.of(1, 3, ASC, "age"));
- assertThat(secondPage.getContent(), hasItems(youngest3));
+ assertThat(secondPage.getContent()).contains(youngest3);
}
@Test // DATAJPA-551
@@ -1467,10 +1366,10 @@ public void find3YoungestUsersPageableWithPageSize2Sliced() {
User youngest3 = secondUser;
Slice firstPage = repository.findTop3UsersBy(PageRequest.of(0, 2, ASC, "age"));
- assertThat(firstPage.getContent(), hasItems(youngest1, youngest2));
+ assertThat(firstPage.getContent()).contains(youngest1, youngest2);
Slice secondPage = repository.findTop3UsersBy(PageRequest.of(1, 2, ASC, "age"));
- assertThat(secondPage.getContent(), hasItems(youngest3));
+ assertThat(secondPage.getContent()).contains(youngest3);
}
@Test // DATAJPA-551
@@ -1483,10 +1382,10 @@ public void find2YoungestUsersPageableWithPageSize3Sliced() {
User youngest3 = secondUser;
Slice firstPage = repository.findTop2UsersBy(PageRequest.of(0, 3, ASC, "age"));
- assertThat(firstPage.getContent(), hasItems(youngest1, youngest2));
+ assertThat(firstPage.getContent()).contains(youngest1, youngest2);
Slice secondPage = repository.findTop2UsersBy(PageRequest.of(1, 3, ASC, "age"));
- assertThat(secondPage.getContent(), hasItems(youngest3));
+ assertThat(secondPage.getContent()).contains(youngest3);
}
@Test // DATAJPA-912
@@ -1495,12 +1394,12 @@ public void pageableQueryReportsTotalFromResult() {
flushTestUsers();
Page firstPage = repository.findAll(PageRequest.of(0, 10));
- assertThat(firstPage.getContent(), hasSize(4));
- assertThat(firstPage.getTotalElements(), is(4L));
+ assertThat(firstPage.getContent()).hasSize(4);
+ assertThat(firstPage.getTotalElements()).isEqualTo(4L);
Page secondPage = repository.findAll(PageRequest.of(1, 3));
- assertThat(secondPage.getContent(), hasSize(1));
- assertThat(secondPage.getTotalElements(), is(4L));
+ assertThat(secondPage.getContent()).hasSize(1);
+ assertThat(secondPage.getTotalElements()).isEqualTo(4L);
}
@Test // DATAJPA-912
@@ -1509,12 +1408,12 @@ public void pageableQueryReportsTotalFromCount() {
flushTestUsers();
Page firstPage = repository.findAll(PageRequest.of(0, 4));
- assertThat(firstPage.getContent(), hasSize(4));
- assertThat(firstPage.getTotalElements(), is(4L));
+ assertThat(firstPage.getContent()).hasSize(4);
+ assertThat(firstPage.getTotalElements()).isEqualTo(4L);
Page secondPage = repository.findAll(PageRequest.of(10, 10));
- assertThat(secondPage.getContent(), hasSize(0));
- assertThat(secondPage.getTotalElements(), is(4L));
+ assertThat(secondPage.getContent()).hasSize(0);
+ assertThat(secondPage.getTotalElements()).isEqualTo(4L);
}
@Test // DATAJPA-506
@@ -1524,8 +1423,8 @@ public void invokesQueryWithWrapperType() {
Optional result = repository.findOptionalByEmailAddress("gierke@synyx.de");
- assertThat(result.isPresent(), is(true));
- assertThat(result.get(), is(firstUser));
+ assertThat(result.isPresent()).isEqualTo(true);
+ assertThat(result.get()).isEqualTo(firstUser);
}
@Test // DATAJPA-564
@@ -1534,8 +1433,7 @@ public void shouldFindUserByFirstnameAndLastnameWithSpelExpressionInStringBasedQ
flushTestUsers();
List users = repository.findByFirstnameAndLastnameWithSpelExpression("Oliver", "ierk");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-564
@@ -1544,8 +1442,7 @@ public void shouldFindUserByLastnameWithSpelExpressionInStringBasedQuery() {
flushTestUsers();
List users = repository.findByLastnameWithSpelExpression("ierk");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-564
@@ -1554,8 +1451,7 @@ public void shouldFindBySpELExpressionWithoutArgumentsWithQuestionmark() {
flushTestUsers();
List users = repository.findOliverBySpELExpressionWithoutArgumentsWithQuestionmark();
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-564
@@ -1564,8 +1460,7 @@ public void shouldFindBySpELExpressionWithoutArgumentsWithColon() {
flushTestUsers();
List users = repository.findOliverBySpELExpressionWithoutArgumentsWithColon();
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-564
@@ -1574,8 +1469,7 @@ public void shouldFindUsersByAgeForSpELExpression() {
flushTestUsers();
List users = repository.findUsersByAgeForSpELExpressionByIndexedParameter(35);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-564
@@ -1584,8 +1478,7 @@ public void shouldfindUsersByFirstnameForSpELExpressionWithParameterNameVariable
flushTestUsers();
List users = repository.findUsersByFirstnameForSpELExpression("Joachim");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-564
@@ -1596,14 +1489,12 @@ public void shouldFindCurrentUserWithCustomQueryDependingOnSecurityContext() {
SampleSecurityContextHolder.getCurrent().setPrincipal(secondUser);
List users = repository.findCurrentUserWithCustomQuery();
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
SampleSecurityContextHolder.getCurrent().setPrincipal(firstUser);
users = repository.findCurrentUserWithCustomQuery();
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).contains(firstUser);
}
@Test // DATAJPA-564
@@ -1614,8 +1505,7 @@ public void shouldFindByFirstnameAndCurrentUserWithCustomQuery() {
SampleSecurityContextHolder.getCurrent().setPrincipal(secondUser);
List users = repository.findByFirstnameAndCurrentUserWithCustomQuery("Joachim");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-564
@@ -1624,8 +1514,7 @@ public void shouldfindUsersByFirstnameForSpELExpressionOnlyWithParameterNameVari
flushTestUsers();
List users = repository.findUsersByFirstnameForSpELExpressionWithParameterVariableOnly("Joachim");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-564
@@ -1634,8 +1523,7 @@ public void shouldfindUsersByFirstnameForSpELExpressionOnlyWithParameterIndexRef
flushTestUsers();
List users = repository.findUsersByFirstnameForSpELExpressionWithParameterIndexOnly("Joachim");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-564
@@ -1645,15 +1533,11 @@ public void shouldFindUsersInNativeQueryWithPagination() {
Page users = repository.findUsersInNativeQueryWithPagination(PageRequest.of(0, 2));
- assertThat(users.getContent(), hasSize(2));
- assertThat(users.getContent().get(0), is(firstUser));
- assertThat(users.getContent().get(1), is(secondUser));
+ assertThat(users.getContent()).hasSize(2).containsExactly(firstUser, secondUser);
users = repository.findUsersInNativeQueryWithPagination(PageRequest.of(1, 2));
- assertThat(users.getContent(), hasSize(2));
- assertThat(users.getContent().get(0), is(thirdUser));
- assertThat(users.getContent().get(1), is(fourthUser));
+ assertThat(users.getContent()).hasSize(2).containsExactly(thirdUser, fourthUser);
}
@Test // DATAJPA-629
@@ -1663,8 +1547,7 @@ public void shouldfindUsersBySpELExpressionParametersWithSpelTemplateExpression(
List users = repository
.findUsersByFirstnameForSpELExpressionWithParameterIndexOnlyWithEntityExpression("Joachim", "Arrasz");
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-606
@@ -1673,7 +1556,7 @@ public void findByEmptyCollectionOfStrings() throws Exception {
flushTestUsers();
List users = repository.findByAttributesIn(new HashSet());
- assertThat(users, hasSize(0));
+ assertThat(users).hasSize(0);
}
@Test // DATAJPA-606
@@ -1682,7 +1565,7 @@ public void findByEmptyCollectionOfIntegers() throws Exception {
flushTestUsers();
List users = repository.findByAgeIn(Arrays. asList());
- assertThat(users, hasSize(0));
+ assertThat(users).hasSize(0);
}
@Test // DATAJPA-606
@@ -1691,7 +1574,7 @@ public void findByEmptyArrayOfIntegers() throws Exception {
flushTestUsers();
List users = repository.queryByAgeIn(new Integer[0]);
- assertThat(users, hasSize(0));
+ assertThat(users).hasSize(0);
}
@Test // DATAJPA-606
@@ -1700,8 +1583,7 @@ public void findByAgeWithEmptyArrayOfIntegersOrFirstName() {
flushTestUsers();
List users = repository.queryByAgeInOrFirstname(new Integer[0], secondUser.getFirstname());
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(secondUser));
+ assertThat(users).containsOnly(secondUser);
}
@Test // DATAJPA-677
@@ -1727,7 +1609,7 @@ public void accept(User user) {
stream.close();
}
- assertThat(users, hasSize(4));
+ assertThat(users).hasSize(4);
}
@Test // DATAJPA-677
@@ -1753,7 +1635,7 @@ public void accept(User user) {
stream.close();
}
- assertThat(users, hasSize(4));
+ assertThat(users).hasSize(4);
}
@Test // DATAJPA-677
@@ -1779,7 +1661,7 @@ public void accept(User user) {
stream.close();
}
- assertThat(users, hasSize(2));
+ assertThat(users).hasSize(2);
}
@Test // DATAJPA-218
@@ -1793,8 +1675,8 @@ public void findAllByExample() {
List users = repository.findAll(of(prototype));
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).hasSize(1);
+ assertThat(users.get(0)).isEqualTo(firstUser);
}
@Test // DATAJPA-218
@@ -1808,7 +1690,7 @@ public void findAllByExampleWithEmptyProbe() {
List users = repository
.findAll(of(prototype, ExampleMatcher.matching().withIgnorePaths("age", "createdAt", "active")));
- assertThat(users, hasSize(4));
+ assertThat(users).hasSize(4);
}
@Test(expected = InvalidDataAccessApiUsageException.class) // DATAJPA-218
@@ -1827,8 +1709,7 @@ public void findAllByExampleWithExcludedAttributes() {
Example example = Example.of(prototype, matching().withIgnorePaths("createdAt"));
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
@@ -1852,8 +1733,8 @@ public void findAllByExampleWithAssociation() {
Example example = Example.of(prototype, matching().withIgnorePaths("age"));
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).hasSize(1);
+ assertThat(users.get(0)).isEqualTo(firstUser);
}
@Test // DATAJPA-218
@@ -1871,8 +1752,7 @@ public void findAllByExampleWithEmbedded() {
Example example = Example.of(prototype, matching().withIgnorePaths("age"));
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
@@ -1887,8 +1767,7 @@ public void findAllByExampleWithStartingStringMatcher() {
matching().withStringMatcher(StringMatcher.STARTING).withIgnorePaths("age", "createdAt"));
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
@@ -1903,8 +1782,7 @@ public void findAllByExampleWithEndingStringMatcher() {
matching().withStringMatcher(StringMatcher.ENDING).withIgnorePaths("age", "createdAt"));
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test(expected = InvalidDataAccessApiUsageException.class) // DATAJPA-218
@@ -1931,8 +1809,7 @@ public void findAllByExampleWithIgnoreCase() {
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
@@ -1948,15 +1825,14 @@ public void findAllByExampleWithStringMatcherAndIgnoreCase() {
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
public void findAllByExampleWithIncludeNull() {
// something is wrong with OpenJPA - I do not know what
- Assume.assumeThat(PersistenceProvider.fromEntityManager(em), not(equalTo(PersistenceProvider.OPEN_JPA)));
+ Assume.assumeThat(PersistenceProvider.fromEntityManager(em), IsNot.not(equalTo(PersistenceProvider.OPEN_JPA)));
flushTestUsers();
@@ -1979,8 +1855,7 @@ public void findAllByExampleWithIncludeNull() {
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(fifthUser));
+ assertThat(users).containsOnly(fifthUser);
}
@Test // DATAJPA-218
@@ -1996,8 +1871,7 @@ public void findAllByExampleWithPropertySpecifier() {
List users = repository.findAll(example);
- assertThat(users, hasSize(1));
- assertThat(users.get(0), is(firstUser));
+ assertThat(users).containsOnly(firstUser);
}
@Test // DATAJPA-218
@@ -2018,9 +1892,7 @@ public void findAllByExampleWithSort() {
List users = repository.findAll(example, Sort.by(DESC, "age"));
- assertThat(users, hasSize(2));
- assertThat(users.get(0), is(user1));
- assertThat(users.get(1), is(firstUser));
+ assertThat(users).hasSize(2).containsExactly(user1, firstUser);
}
@Test // DATAJPA-218
@@ -2043,9 +1915,9 @@ public void findAllByExampleWithPageable() {
Page users = repository.findAll(example, PageRequest.of(0, 10, Sort.by(DESC, "age")));
- assertThat(users.getSize(), is(10));
- assertThat(users.hasNext(), is(true));
- assertThat(users.getTotalElements(), is(100L));
+ assertThat(users.getSize()).isEqualTo(10);
+ assertThat(users.hasNext()).isEqualTo(true);
+ assertThat(users.getTotalElements()).isEqualTo(100L);
}
@Test(expected = InvalidDataAccessApiUsageException.class) // DATAJPA-218
@@ -2093,9 +1965,8 @@ public void findOneByExampleWithExcludedAttributes() {
prototype.setAge(28);
Example example = Example.of(prototype, matching().withIgnorePaths("createdAt"));
- User users = repository.findOne(example);
- assertThat(users, is(firstUser));
+ assertThat(repository.findOne(example)).contains(firstUser);
}
@Test // DATAJPA-218
@@ -2109,7 +1980,7 @@ public void countByExampleWithExcludedAttributes() {
Example example = Example.of(prototype, matching().withIgnorePaths("createdAt"));
long count = repository.count(example);
- assertThat(count, is(1L));
+ assertThat(count).isEqualTo(1L);
}
@Test // DATAJPA-218
@@ -2123,7 +1994,7 @@ public void existsByExampleWithExcludedAttributes() {
Example example = Example.of(prototype, matching().withIgnorePaths("createdAt"));
boolean exists = repository.exists(example);
- assertThat(exists, is(true));
+ assertThat(exists).isEqualTo(true);
}
@Test // DATAJPA-905
@@ -2133,9 +2004,9 @@ public void excutesPagedSpecificationSettingAnOrder() {
Page result = repository.findAll(where(userHasLastnameLikeWithSort("e")), PageRequest.of(0, 1));
- assertThat(result.getTotalElements(), is(2L));
- assertThat(result.getNumberOfElements(), is(1));
- assertThat(result.getContent().get(0), is(thirdUser));
+ assertThat(result.getTotalElements()).isEqualTo(2L);
+ assertThat(result.getNumberOfElements()).isEqualTo(1);
+ assertThat(result.getContent().get(0)).isEqualTo(thirdUser);
}
private Page executeSpecWithSort(Sort sort) {
@@ -2145,7 +2016,7 @@ private Page executeSpecWithSort(Sort sort) {
Specification spec = where(userHasFirstname("Oliver")).or(userHasLastname("Matthews"));
Page result = repository.findAll(spec, PageRequest.of(0, 1, sort));
- assertThat(result.getTotalElements(), is(2L));
+ assertThat(result.getTotalElements()).isEqualTo(2L);
return result;
}
}