Skip to content

Commit 53b5871

Browse files
committed
DATAES-163 - Modified tests to work with new version of spring-data-elasticsearch base on ES2.x
1 parent 063d8ed commit 53b5871

File tree

2 files changed

+18
-26
lines changed

2 files changed

+18
-26
lines changed

src/test/java/org/springframework/data/elasticsearch/entities/SampleEntityUUIDKeyed.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@
1515
*/
1616
package org.springframework.data.elasticsearch.entities;
1717

18-
import lombok.*;
19-
2018
import java.util.UUID;
2119

20+
import lombok.*;
2221
import org.springframework.data.annotation.Id;
2322
import org.springframework.data.annotation.Version;
2423
import org.springframework.data.elasticsearch.annotations.Document;
@@ -36,7 +35,7 @@
3635
@NoArgsConstructor
3736
@AllArgsConstructor
3837
@Builder
39-
@Document(indexName = "test-index-uuid-keyed", type = "test-type-uuid-keyed", indexStoreType = "memory", shards = 1, replicas = 0, refreshInterval = "-1")
38+
@Document(indexName = "test-index-uuid-keyed", type = "test-type-uuid-keyed", shards = 1, replicas = 0, refreshInterval = "-1")
4039
public class SampleEntityUUIDKeyed {
4140

4241
@Id

src/test/java/org/springframework/data/elasticsearch/repository/support/UUIDElasticsearchRepositoryTests.java

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,12 @@
1515
*/
1616
package org.springframework.data.elasticsearch.repository.support;
1717

18-
import static org.elasticsearch.index.query.QueryBuilders.matchAllQuery;
19-
import static org.elasticsearch.index.query.QueryBuilders.termQuery;
20-
import static org.hamcrest.Matchers.equalTo;
21-
import static org.hamcrest.Matchers.greaterThanOrEqualTo;
22-
import static org.hamcrest.Matchers.is;
23-
import static org.hamcrest.Matchers.notNullValue;
24-
import static org.hamcrest.Matchers.nullValue;
25-
import static org.junit.Assert.assertEquals;
26-
import static org.junit.Assert.assertNotNull;
27-
import static org.junit.Assert.assertThat;
28-
29-
import java.util.ArrayList;
30-
import java.util.Arrays;
31-
import java.util.List;
32-
import java.util.UUID;
33-
34-
import org.elasticsearch.common.collect.Lists;
18+
import static org.elasticsearch.index.query.QueryBuilders.*;
19+
import static org.hamcrest.Matchers.*;
20+
import static org.junit.Assert.*;
21+
22+
import java.util.*;
23+
3524
import org.junit.Before;
3625
import org.junit.Test;
3726
import org.junit.runner.RunWith;
@@ -68,8 +57,8 @@ public class UUIDElasticsearchRepositoryTests {
6857
public void before() {
6958
elasticsearchTemplate.deleteIndex(SampleEntityUUIDKeyed.class);
7059
elasticsearchTemplate.createIndex(SampleEntityUUIDKeyed.class);
71-
elasticsearchTemplate.putMapping(SampleEntityUUIDKeyed.class);
72-
elasticsearchTemplate.refresh(SampleEntityUUIDKeyed.class, true);
60+
elasticsearchTemplate.putMapping(SampleEntityUUIDKeyed.class);
61+
elasticsearchTemplate.refresh(SampleEntityUUIDKeyed.class);
7362
}
7463

7564
@Test
@@ -222,12 +211,13 @@ public void shouldFindAllByIdQuery() {
222211
repository.save(sampleEntityUUIDKeyed2);
223212

224213
// when
225-
Iterable<SampleEntityUUIDKeyed> sampleEntities = repository.findAll(Arrays.asList(documentId, documentId2));
214+
LinkedList<SampleEntityUUIDKeyed> sampleEntities = (LinkedList<SampleEntityUUIDKeyed>) repository.findAll(Arrays.asList(documentId, documentId2));
226215

227216
// then
228217
assertNotNull("sample entities cant be null..", sampleEntities);
229-
List<SampleEntityUUIDKeyed> entities = Lists.newArrayList(sampleEntities);
230-
assertThat(entities.size(), is(2));
218+
assertThat(sampleEntities.size(), is(2));
219+
assertThat(sampleEntities.get(0).getId(), isIn(Arrays.asList(documentId, documentId2)));
220+
assertThat(sampleEntities.get(1).getId(), isIn(Arrays.asList(documentId, documentId2)));
231221
}
232222

233223
@Test
@@ -324,6 +314,7 @@ public void shouldDeleteByMessageAndReturnList() {
324314
repository.save(Arrays.asList(sampleEntityUUIDKeyed1, sampleEntityUUIDKeyed2, sampleEntityUUIDKeyed3));
325315
// when
326316
List<SampleEntityUUIDKeyed> result = repository.deleteByAvailable(true);
317+
repository.refresh();
327318
// then
328319
assertThat(result.size(), equalTo(2));
329320
SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(matchAllQuery()).build();
@@ -354,6 +345,7 @@ public void shouldDeleteByListForMessage() {
354345
repository.save(Arrays.asList(sampleEntityUUIDKeyed1, sampleEntityUUIDKeyed2, sampleEntityUUIDKeyed3));
355346
// when
356347
List<SampleEntityUUIDKeyed> result = repository.deleteByMessage("hello world 3");
348+
repository.refresh();
357349
// then
358350
assertThat(result.size(), equalTo(1));
359351
SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(matchAllQuery()).build();
@@ -384,14 +376,14 @@ public void shouldDeleteByType() {
384376
repository.save(Arrays.asList(sampleEntityUUIDKeyed1, sampleEntityUUIDKeyed2, sampleEntityUUIDKeyed3));
385377
// when
386378
repository.deleteByType("article");
379+
repository.refresh();
387380
// then
388381
SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(matchAllQuery()).build();
389382
Page<SampleEntityUUIDKeyed> sampleEntities = repository.search(searchQuery);
390383
assertThat(sampleEntities.getTotalElements(), equalTo(2L));
391384
}
392385

393386

394-
395387
@Test
396388
public void shouldDeleteEntity() {
397389
// given
@@ -403,6 +395,7 @@ public void shouldDeleteEntity() {
403395
repository.save(sampleEntityUUIDKeyed);
404396
// when
405397
repository.delete(sampleEntityUUIDKeyed);
398+
repository.refresh();
406399
// then
407400
SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(termQuery("id", documentId)).build();
408401
Page<SampleEntityUUIDKeyed> sampleEntities = repository.search(searchQuery);

0 commit comments

Comments
 (0)