Skip to content

Commit 4abb1dc

Browse files
committed
Handle null errors.
Signed-off-by: Youssef Aouichaoui <youssef3wi@icloud.com>
1 parent 190f055 commit 4abb1dc

File tree

2 files changed

+9
-17
lines changed

2 files changed

+9
-17
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1005,6 +1005,9 @@ public DeleteByQueryRequest documentDeleteByQueryRequest(DeleteQuery query, @Nul
10051005
if (query.getExpandWildcards() != null && !query.getExpandWildcards().isEmpty()) {
10061006
dqb.expandWildcards(expandWildcards(query.getExpandWildcards()));
10071007
}
1008+
if (query.getStats() != null && !query.getStats().isEmpty()) {
1009+
dqb.stats(query.getStats());
1010+
}
10081011
dqb.allowNoIndices(query.getAllowNoIndices())
10091012
.conflicts(query.getConflicts())
10101013
.ignoreUnavailable(query.getIgnoreUnavailable())
@@ -1013,7 +1016,6 @@ public DeleteByQueryRequest documentDeleteByQueryRequest(DeleteQuery query, @Nul
10131016
.searchType(searchType(query.getSearchType()))
10141017
.searchTimeout(time(query.getSearchTimeout()))
10151018
.slices(query.getSlices())
1016-
.stats(query.getStats())
10171019
.terminateAfter(query.getTerminateAfter())
10181020
.timeout(time(query.getTimeout()))
10191021
.version(query.getVersion());

src/main/java/org/springframework/data/elasticsearch/core/query/DeleteQuery.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,10 @@ public class DeleteQuery extends BaseQuery {
140140
/**
141141
* Query that specifies the documents to delete.
142142
*/
143-
@Nullable
144143
private final Query query;
145144

146-
public static Builder builder() {
147-
return new Builder();
145+
public static Builder builder(Query query) {
146+
return new Builder(query);
148147
}
149148

150149
public DeleteQuery(Builder builder) {
@@ -252,7 +251,7 @@ public Query getQuery() {
252251
return query;
253252
}
254253

255-
public static final class Builder extends BaseQueryBuilder<DeleteQuery, DeleteQuery.Builder> {
254+
public static final class Builder extends BaseQueryBuilder<DeleteQuery, Builder> {
256255
// For Lucene query
257256
@Nullable
258257
private String luceneQuery;
@@ -288,10 +287,10 @@ public static final class Builder extends BaseQueryBuilder<DeleteQuery, DeleteQu
288287
private Boolean version;
289288

290289
// Body
291-
@Nullable
292-
private Query query;
290+
private final Query query;
293291

294-
private Builder() {
292+
private Builder(Query query) {
293+
this.query = query;
295294
}
296295

297296
/**
@@ -443,15 +442,6 @@ public Builder withVersion(@Nullable Boolean version) {
443442
return this;
444443
}
445444

446-
/**
447-
* Query that specifies the documents to delete.
448-
*/
449-
public Builder withQuery(Query query) {
450-
this.query = query;
451-
452-
return this;
453-
}
454-
455445
@Override
456446
public DeleteQuery build() {
457447
if (luceneQuery == null) {

0 commit comments

Comments
 (0)