From 87180c8db05f2b55965bf6484c6d71f4d48a1a4f Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Thu, 27 Apr 2023 10:48:13 +0200 Subject: [PATCH 1/2] order-constructor - Prepare branch --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 13bf0377b4..fa66174d43 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ org.springframework.data spring-data-commons - 3.1.0-SNAPSHOT + 3.1.0-order-constructor-SNAPSHOT Spring Data Core Core Spring concepts underpinning every Spring Data module. From 0c56286ef6441baa3c1b2ae317b124df42bcab94 Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Thu, 27 Apr 2023 10:51:15 +0200 Subject: [PATCH 2/2] Make all args Order constructor public. The other constructors are already public, and this one is actually needed by subclasses. --- src/main/java/org/springframework/data/domain/Sort.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/springframework/data/domain/Sort.java b/src/main/java/org/springframework/data/domain/Sort.java index da8f8748f7..32079b70ef 100644 --- a/src/main/java/org/springframework/data/domain/Sort.java +++ b/src/main/java/org/springframework/data/domain/Sort.java @@ -356,6 +356,7 @@ public static enum NullHandling { * * @author Oliver Gierke * @author Kevin Raymond + * @author Jens Schauder */ public static class Order implements Serializable { @@ -434,7 +435,7 @@ public static Order desc(String property) { * @param nullHandling must not be {@literal null}. * @since 1.7 */ - private Order(@Nullable Direction direction, String property, boolean ignoreCase, NullHandling nullHandling) { + public Order(@Nullable Direction direction, String property, boolean ignoreCase, NullHandling nullHandling) { if (!StringUtils.hasText(property)) { throw new IllegalArgumentException("Property must not be null or empty");