Polishing.

Fix test naming. Improve equals check by caching resolved generics.

Author: mp911de

src/main/java/org/springframework/data/util/TypeDiscoverer.java

@@ -60,6 +60,8 @@ class TypeDiscoverer<S> implements TypeInformation<S> {
 	private final Map<Constructor<?>, List<TypeInformation<?>>> constructorParameters = new ConcurrentHashMap<>();
 	private final Lazy<List<TypeInformation<?>>> typeArguments;
 
+	private final Lazy<List<Class>> resolvedGenerics;
+
 	protected TypeDiscoverer(ResolvableType type) {
 
 		Assert.notNull(type, "Type must not be null");
@@ -68,9 +70,11 @@ protected TypeDiscoverer(ResolvableType type) {
 		this.componentType = Lazy.of(this::doGetComponentType);
 		this.valueType = Lazy.of(this::doGetMapValueType);
 		this.typeArguments = Lazy.of(this::doGetTypeArguments);
+		this.resolvedGenerics = Lazy.of(() -> Arrays.stream(resolvableType.getGenerics()) //
+				.map(ResolvableType::toClass).collect(Collectors.toList()));
 	}
 
-	static TypeDiscoverer<?> td(ResolvableType type) {
+	static TypeDiscoverer<?> ofCached(ResolvableType type) {
 
 		Assert.notNull(type, "Type must not be null");
 
@@ -325,15 +329,7 @@ public boolean equals(@Nullable Object o) {
 			return false;
 		}
 
-		var collect1 = Arrays.stream(resolvableType.getGenerics()) //
-				.map(ResolvableType::toClass) //
-				.collect(Collectors.toList());
-
-		var collect2 = Arrays.stream(that.resolvableType.getGenerics()) //
-				.map(ResolvableType::toClass) //
-				.collect(Collectors.toList());
-
-		return ObjectUtils.nullSafeEquals(collect1, collect2);
+		return ObjectUtils.nullSafeEquals(resolvedGenerics.get(), that.resolvedGenerics.get());
 	}
 
 	@Override

src/main/java/org/springframework/data/util/TypeInformation.java

@@ -60,7 +60,7 @@ public static TypeInformation<?> of(ResolvableType type) {
 		Assert.notNull(type, "Type must not be null");
 
 		return type.hasGenerics() || (type.isArray() && type.getComponentType().hasGenerics()) //
-				|| (type.getType() instanceof TypeVariable) ? TypeDiscoverer.td(type) : ClassTypeInformation.from(type);
+				|| (type.getType() instanceof TypeVariable) ? TypeDiscoverer.ofCached(type) : ClassTypeInformation.from(type);
 	}
 
 	/**

src/test/java/org/springframework/data/mapping/PropertyPathUnitTests.java

@@ -124,7 +124,7 @@ void handlesArrayCorrectly() {
 	}
 
 	@Test
-	void handlesInvalidCollectionCompountTypeProperl() {
+	void handlesInvalidCollectionCompoundTypeProperly() {
 
 		try {
 			PropertyPath.from("usersMame", Bar.class);