DATACMNS-1359 - Improved exception message for missing accessors and getters.

The exception messages used in the PersistentProperty.getRequired(Getter|Setter|Wither|Field)(…) now mention the name of the property that's offending.

Author: odrotbohm

src/main/java/org/springframework/data/mapping/PersistentProperty.java

@@ -87,7 +87,7 @@ default Method getRequiredGetter() {
 		Method getter = getGetter();
 
 		if (getter == null) {
-			throw new IllegalArgumentException("No getter available for this persistent property!");
+			throw new IllegalArgumentException(String.format("No getter available for persistent property %s!", this));
 		}
 
 		return getter;
@@ -107,7 +107,7 @@ default Method getRequiredSetter() {
 		Method setter = getSetter();
 
 		if (setter == null) {
-			throw new IllegalArgumentException("No setter available for this persistent property!");
+			throw new IllegalArgumentException(String.format("No setter available for persistent property %s!", this));
 		}
 
 		return setter;
@@ -145,7 +145,7 @@ default Method getRequiredWither() {
 		Method wither = getWither();
 
 		if (wither == null) {
-			throw new IllegalArgumentException("No wither available for this persistent property!");
+			throw new IllegalArgumentException(String.format("No wither available for persistent property %s!", this));
 		}
 
 		return wither;
@@ -159,7 +159,7 @@ default Field getRequiredField() {
 		Field field = getField();
 
 		if (field == null) {
-			throw new IllegalArgumentException("No field backing this persistent property!");
+			throw new IllegalArgumentException(String.format("No field backing persistent property %s!", this));
 		}
 
 		return field;

src/main/java/org/springframework/data/mapping/model/Property.java

@@ -67,7 +67,8 @@ private Property(TypeInformation<?> type, Optional<Field> field, Optional<Proper
 		);
 		this.hashCode = Lazy.of(() -> withFieldOrDescriptor(Object::hashCode));
 		this.name = Lazy.of(() -> withFieldOrDescriptor(Field::getName, FeatureDescriptor::getName));
-		this.toString = Lazy.of(() -> withFieldOrDescriptor(Object::toString));
+		this.toString = Lazy.of(() -> withFieldOrDescriptor(Object::toString,
+				it -> String.format("%s.%s", type.getType().getName(), it.getDisplayName())));
 
 		this.getter = descriptor.map(PropertyDescriptor::getReadMethod)//
 				.filter(it -> getType() != null)//

src/test/java/org/springframework/data/mapping/model/AnnotationBasedPersistentPropertyUnitTests.java

@@ -249,6 +249,50 @@ public void detectsUltimateAssociationTargetClass() {
 		});
 	}
 
+	@Test // DATACMNS-1359
+	public void missingRequiredGetterThrowsException() {
+
+		SamplePersistentProperty property = getProperty(Sample.class, "field");
+
+		assertThatExceptionOfType(IllegalArgumentException.class) //
+				.isThrownBy(() -> property.getRequiredGetter()) //
+				.withMessageContaining("field") //
+				.withMessageContaining(Sample.class.getName());
+	}
+
+	@Test // DATACMNS-1359
+	public void missingRequiredSetterThrowsException() {
+
+		SamplePersistentProperty property = getProperty(Sample.class, "field");
+
+		assertThatExceptionOfType(IllegalArgumentException.class) //
+				.isThrownBy(() -> property.getRequiredSetter()) //
+				.withMessageContaining("field") //
+				.withMessageContaining(Sample.class.getName());
+	}
+
+	@Test // DATACMNS-1359
+	public void missingRequiredWitherThrowsException() {
+
+		SamplePersistentProperty property = getProperty(Sample.class, "field");
+
+		assertThatExceptionOfType(IllegalArgumentException.class) //
+				.isThrownBy(() -> property.getRequiredWither()) //
+				.withMessageContaining("field") //
+				.withMessageContaining(Sample.class.getName());
+	}
+
+	@Test
+	public void missingRequiredFieldThrowsException() {
+
+		SamplePersistentProperty property = getProperty(NoField.class, "firstname");
+
+		assertThatExceptionOfType(IllegalArgumentException.class) //
+				.isThrownBy(() -> property.getRequiredField()) //
+				.withMessageContaining("firstname") //
+				.withMessageContaining(NoField.class.getName());
+	}
+
 	@SuppressWarnings("unchecked")
 	private Map<Class<? extends Annotation>, Annotation> getAnnotationCache(SamplePersistentProperty property) {
 		return (Map<Class<? extends Annotation>, Annotation>) ReflectionTestUtils.getField(property, "annotationCache");
@@ -428,4 +472,9 @@ static class WithReferences {
 		@Reference Sample sample;
 		Sample withoutAnnotation;
 	}
+
+	interface NoField {
+
+		String getFirstname();
+	}
 }