Skip to content

Commit 480522b

Browse files
Polishing.
Add issue reference and additional test for dot path resolution. Original Pull Request: #2650
1 parent 9e94e11 commit 480522b

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/test/java/org/springframework/data/querydsl/binding/QuerydslPredicateBuilderUnitTests.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ void leavesCommaSeparatedArgumentUntouchedWhenTargetIsNotAnArray() {
182182
assertThat(constant.getConstant()).isEqualTo("rivers,two");
183183
}
184184

185-
@Test
185+
@Test // GH-2649
186186
void resolvesCommaSeparatedArgumentToListCorrectly() {
187187

188188
values.add("nickNames", "Walt,Heisenberg");
@@ -194,6 +194,17 @@ void resolvesCommaSeparatedArgumentToListCorrectly() {
194194
assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg"));
195195
}
196196

197+
@Test // GH-2649
198+
void resolvesCommaSeparatedArgumentToListCorrectlyForNestedPath() {
199+
200+
values.add("user.nickNames", "Walt,Heisenberg");
201+
202+
var predicate = builder.getPredicate(TypeInformation.of(UserWrapper.class), values, DEFAULT_BINDINGS);
203+
var constant = (Constant<Object>) ((List<?>) getField(getField(predicate, "mixin"), "args")).get(0);
204+
205+
assertThat(constant.getConstant()).isEqualTo(Arrays.asList("Walt", "Heisenberg"));
206+
}
207+
197208
@Test // DATACMNS-883
198209
void automaticallyInsertsAnyStepInCollectionReference() {
199210

0 commit comments

Comments
 (0)