DATACMNS-563 - Added unit tests to verify enabling one-indexed parameters are considered correctly when resolving Pageables.

Author: odrotbohm

src/test/java/org/springframework/data/web/HateoasPageableHandlerMethodArgumentResolverUnitTests.java

@@ -106,6 +106,25 @@ public void returnsCustomizedTemplateVariables() {
 		assertThat(variables, is("{?foo,size,sort}"));
 	}
 
+	/**
+	 * @see DATACMNS-563
+	 */
+	@Test
+	public void enablingOneIndexedParameterReturnsOneForFirstPage() {
+
+		HateoasPageableHandlerMethodArgumentResolver resolver = getResolver();
+		resolver.setOneIndexedParameters(true);
+
+		UriComponentsBuilder builder = UriComponentsBuilder.fromPath("/");
+
+		resolver.enhance(builder, null, new PageRequest(0, 10));
+
+		MultiValueMap<String, String> params = builder.build().getQueryParams();
+
+		assertThat(params.containsKey(resolver.getPageParameterName()), is(true));
+		assertThat(params.getFirst(resolver.getPageParameterName()), is("1"));
+	}
+
 	@Override
 	protected HateoasPageableHandlerMethodArgumentResolver getResolver() {
 

src/test/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverUnitTests.java

@@ -200,6 +200,22 @@ public void returnsNullIfFallbackIsNullAndOnlySizeIsGiven() throws Exception {
 				is(nullValue()));
 	}
 
+	/**
+	 * @see DATACMNS-563
+	 */
+	@Test
+	public void considersOneIndexedParametersSetting() {
+
+		PageableHandlerMethodArgumentResolver resolver = getResolver();
+		resolver.setOneIndexedParameters(true);
+
+		MockHttpServletRequest request = new MockHttpServletRequest();
+		request.addParameter("page", "1");
+
+		assertThat(resolver.resolveArgument(supportedMethodParameter, null, new ServletWebRequest(request), null)
+				.getPageNumber(), is(0));
+	}
+
 	@Override
 	protected PageableHandlerMethodArgumentResolver getResolver() {
 		PageableHandlerMethodArgumentResolver resolver = new PageableHandlerMethodArgumentResolver();