Skip to content

Fix use of java11 in springci/spring-boot-jdk11-ci-image #15179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix use of java11 in springci/spring-boot-jdk11-ci-image #15179

wants to merge 2 commits into from

Conversation

making
Copy link
Member

@making making commented Nov 15, 2018

This commit reverts to use Java 11 in springci/spring-boot-jdk11-ci-image image that is now accidentally using java10 by e923228

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 15, 2018
@wilkinsona
Copy link
Member

Well spotted, @making. Thank you!

@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 15, 2018
@wilkinsona wilkinsona added this to the 2.0.x milestone Nov 15, 2018
@philwebb philwebb changed the title Revert to use java11 in springci/spring-boot-jdk11-ci-image Fix use of java11 in springci/spring-boot-jdk11-ci-image Nov 15, 2018
@philwebb philwebb modified the milestones: 2.0.x, 2.0.7 Nov 15, 2018
philwebb added a commit that referenced this pull request Nov 15, 2018
* pr/15179:
  Fix CI Java 11 references
@philwebb philwebb closed this in dd2ed72 Nov 15, 2018
@making making deleted the patch-1 branch November 15, 2018 18:34
@making
Copy link
Member Author

making commented Nov 15, 2018

@philwebb

springci/spring-boot-jdk11-ci-image seems still wrong

$ docker run --rm springci/spring-boot-jdk11-ci-image:master "cat /opt/openjdk/release"

IMPLEMENTOR="N/A"
JAVA_VERSION="10.0.2"
JAVA_VERSION_DATE="2018-07-17"
MODULES="java.base java.datatransfer java.logging java.activation java.compiler java.xml java.prefs java.desktop java.security.sasl java.naming java.rmi java.transaction jdk.unsupported java.corba java.instrument java.management java.management.rmi java.scripting java.security.jgss java.sql java.sql.rowset java.xml.crypto java.se java.xml.bind java.xml.ws.annotation jdk.httpserver java.xml.ws java.se.ee java.smartcardio jdk.accessibility jdk.internal.vm.ci jdk.management jdk.internal.vm.compiler jdk.aot jdk.internal.jvmstat jdk.attach jdk.charsets jdk.compiler jdk.crypto.ec jdk.crypto.cryptoki jdk.dynalink jdk.internal.ed jdk.editpad jdk.hotspot.agent jdk.incubator.httpclient jdk.internal.le jdk.internal.opt jdk.internal.vm.compiler.management jdk.jartool jdk.javadoc jdk.jcmd jdk.management.agent jdk.jconsole jdk.jdeps jdk.jdwp.agent jdk.jdi jdk.jlink jdk.jshell jdk.jsobject jdk.jstatd jdk.localedata jdk.naming.dns jdk.naming.rmi jdk.net jdk.pack jdk.rmic jdk.scripting.nashorn jdk.scripting.nashorn.shell jdk.sctp jdk.security.auth jdk.security.jgss jdk.xml.bind jdk.xml.dom jdk.xml.ws jdk.zipfs"
OS_ARCH="x86_64"
OS_NAME="Linux"
SOURCE=""

philwebb added a commit that referenced this pull request Nov 15, 2018
@philwebb
Copy link
Member

@making I messed up the merge commit. I had a local change I forgot to push. It's all good now:

docker run --rm springci/spring-boot-jdk11-ci-image:master "cat /opt/openjdk/release"
IMPLEMENTOR="AdoptOpenJDK"
IMPLEMENTOR_VERSION="AdoptOpenJDK"
JAVA_VERSION="11.0.1"
JAVA_VERSION_DATE="2018-10-16"
MODULES="java.base java.compiler java.datatransfer java.xml java.prefs java.desktop java.instrument java.logging java.management java.security.sasl java.naming java.rmi java.management.rmi java.net.http java.scripting java.security.jgss java.transaction.xa java.sql java.sql.rowset java.xml.crypto java.se java.smartcardio jdk.accessibility jdk.internal.vm.ci jdk.management jdk.unsupported jdk.internal.vm.compiler jdk.aot jdk.internal.jvmstat jdk.attach jdk.charsets jdk.compiler jdk.crypto.ec jdk.crypto.cryptoki jdk.dynalink jdk.internal.ed jdk.editpad jdk.hotspot.agent jdk.httpserver jdk.internal.le jdk.internal.opt jdk.internal.vm.compiler.management jdk.jartool jdk.javadoc jdk.jcmd jdk.management.agent jdk.jconsole jdk.jdeps jdk.jdwp.agent jdk.jdi jdk.jfr jdk.jlink jdk.jshell jdk.jsobject jdk.jstatd jdk.localedata jdk.management.jfr jdk.naming.dns jdk.naming.rmi jdk.net jdk.pack jdk.rmic jdk.scripting.nashorn jdk.scripting.nashorn.shell jdk.sctp jdk.security.auth jdk.security.jgss jdk.unsupported.desktop jdk.xml.dom jdk.zipfs"
OS_ARCH="x86_64"
OS_NAME="Linux"
SOURCE=""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants