Skip to content

Commit f1cf41f

Browse files
committed
Merge pull request #13818 from Johnny Lim
* gh-13818: Add null guards for getBeanDefinition() in BeanTypeRegistry
2 parents 9c5330f + 0fd4e40 commit f1cf41f

File tree

1 file changed

+11
-6
lines changed
  • spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition

1 file changed

+11
-6
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/BeanTypeRegistry.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,10 @@ else if (!this.beanFactory.isAlias(name)) {
159159
}
160160

161161
private void addBeanTypeForNonAliasDefinition(String name) {
162-
addBeanTypeForNonAliasDefinition(name, getBeanDefinition(name));
162+
RootBeanDefinition beanDefinition = getBeanDefinition(name);
163+
if (beanDefinition != null) {
164+
addBeanTypeForNonAliasDefinition(name, beanDefinition);
165+
}
163166
}
164167

165168
private RootBeanDefinition getBeanDefinition(String name) {
@@ -219,11 +222,13 @@ private void updateTypesIfNecessary() {
219222
if (!this.beanFactory.isAlias(name)
220223
&& !this.beanFactory.containsSingleton(name)) {
221224
RootBeanDefinition beanDefinition = getBeanDefinition(name);
222-
RootBeanDefinition existingDefinition = this.beanDefinitions.put(name,
223-
beanDefinition);
224-
if (existingDefinition != null
225-
&& !beanDefinition.equals(existingDefinition)) {
226-
addBeanTypeForNonAliasDefinition(name, beanDefinition);
225+
if (beanDefinition != null) {
226+
RootBeanDefinition existingDefinition = this.beanDefinitions
227+
.put(name, beanDefinition);
228+
if (existingDefinition != null
229+
&& !beanDefinition.equals(existingDefinition)) {
230+
addBeanTypeForNonAliasDefinition(name, beanDefinition);
231+
}
227232
}
228233
}
229234
}

0 commit comments

Comments
 (0)