Skip to content

Commit ec8d2c5

Browse files
committed
Merge branch '2.2.x'
Closes gh-20616
2 parents 4cdb968 + 39b965e commit ec8d2c5

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/kafka/KafkaAnnotationDrivenConfiguration.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2019 the original author or authors.
2+
* Copyright 2012-2020 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -26,6 +26,7 @@
2626
import org.springframework.kafka.config.ConcurrentKafkaListenerContainerFactory;
2727
import org.springframework.kafka.config.KafkaListenerConfigUtils;
2828
import org.springframework.kafka.core.ConsumerFactory;
29+
import org.springframework.kafka.core.DefaultKafkaConsumerFactory;
2930
import org.springframework.kafka.core.KafkaTemplate;
3031
import org.springframework.kafka.listener.AfterRollbackProcessor;
3132
import org.springframework.kafka.listener.BatchErrorHandler;
@@ -112,9 +113,10 @@ ConcurrentKafkaListenerContainerFactoryConfigurer kafkaListenerContainerFactoryC
112113
@ConditionalOnMissingBean(name = "kafkaListenerContainerFactory")
113114
ConcurrentKafkaListenerContainerFactory<?, ?> kafkaListenerContainerFactory(
114115
ConcurrentKafkaListenerContainerFactoryConfigurer configurer,
115-
ConsumerFactory<Object, Object> kafkaConsumerFactory) {
116+
ObjectProvider<ConsumerFactory<Object, Object>> kafkaConsumerFactory) {
116117
ConcurrentKafkaListenerContainerFactory<Object, Object> factory = new ConcurrentKafkaListenerContainerFactory<>();
117-
configurer.configure(factory, kafkaConsumerFactory);
118+
configurer.configure(factory, kafkaConsumerFactory
119+
.getIfAvailable(() -> new DefaultKafkaConsumerFactory<>(this.properties.buildConsumerProperties())));
118120
return factory;
119121
}
120122

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/kafka/KafkaAutoConfigurationTests.java

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
import org.springframework.kafka.config.KafkaListenerContainerFactory;
5252
import org.springframework.kafka.config.KafkaStreamsConfiguration;
5353
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
54+
import org.springframework.kafka.core.ConsumerFactory;
5455
import org.springframework.kafka.core.DefaultKafkaConsumerFactory;
5556
import org.springframework.kafka.core.DefaultKafkaProducerFactory;
5657
import org.springframework.kafka.core.KafkaAdmin;
@@ -575,6 +576,16 @@ void testConcurrentKafkaListenerContainerFactoryWithKafkaTemplate() {
575576
});
576577
}
577578

579+
@Test
580+
void testConcurrentKafkaListenerContainerFactoryWithCustomConsumerFactory() {
581+
this.contextRunner.withUserConfiguration(ConsumerFactoryConfiguration.class).run((context) -> {
582+
ConcurrentKafkaListenerContainerFactory<?, ?> kafkaListenerContainerFactory = context
583+
.getBean(ConcurrentKafkaListenerContainerFactory.class);
584+
assertThat(kafkaListenerContainerFactory.getConsumerFactory())
585+
.isNotSameAs(context.getBean(ConsumerFactoryConfiguration.class).consumerFactory);
586+
});
587+
}
588+
578589
@Test
579590
void specificSecurityProtocolOverridesCommonSecurityProtocol() {
580591
this.contextRunner.withPropertyValues("spring.kafka.security.protocol=SSL",
@@ -653,6 +664,18 @@ AfterRollbackProcessor<Object, Object> afterRollbackProcessor() {
653664

654665
}
655666

667+
@Configuration(proxyBeanMethods = false)
668+
static class ConsumerFactoryConfiguration {
669+
670+
private final ConsumerFactory<String, Object> consumerFactory = mock(ConsumerFactory.class);
671+
672+
@Bean
673+
ConsumerFactory<String, Object> myConsumerFactory() {
674+
return this.consumerFactory;
675+
}
676+
677+
}
678+
656679
@Configuration(proxyBeanMethods = false)
657680
static class RecordInterceptorConfiguration {
658681

0 commit comments

Comments
 (0)