Skip to content

Commit dfa5480

Browse files
committed
Remove useless @RegisterExtension on CliTester
Closes gh-17266
1 parent 45d2f1d commit dfa5480

File tree

6 files changed

+6
-18
lines changed

6 files changed

+6
-18
lines changed

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/ClassLoaderIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import org.junit.jupiter.api.Test;
2020
import org.junit.jupiter.api.extension.ExtendWith;
21-
import org.junit.jupiter.api.extension.RegisterExtension;
2221

2322
import org.springframework.boot.test.system.CapturedOutput;
2423
import org.springframework.boot.test.system.OutputCaptureExtension;
@@ -33,8 +32,7 @@
3332
@ExtendWith(OutputCaptureExtension.class)
3433
class ClassLoaderIntegrationTests {
3534

36-
@RegisterExtension
37-
private CliTester cli;
35+
private final CliTester cli;
3836

3937
ClassLoaderIntegrationTests(CapturedOutput capturedOutput) {
4038
this.cli = new CliTester("src/test/resources/", capturedOutput);

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/DirectorySourcesIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import org.junit.jupiter.api.Test;
2020
import org.junit.jupiter.api.extension.ExtendWith;
21-
import org.junit.jupiter.api.extension.RegisterExtension;
2221

2322
import org.springframework.boot.test.system.CapturedOutput;
2423
import org.springframework.boot.test.system.OutputCaptureExtension;
@@ -33,8 +32,7 @@
3332
@ExtendWith(OutputCaptureExtension.class)
3433
class DirectorySourcesIntegrationTests {
3534

36-
@RegisterExtension
37-
private CliTester cli;
35+
private final CliTester cli;
3836

3937
DirectorySourcesIntegrationTests(CapturedOutput capturedOutput) {
4038
this.cli = new CliTester("src/test/resources/dir-sample/", capturedOutput);

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/GrabCommandIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.junit.jupiter.api.BeforeEach;
2323
import org.junit.jupiter.api.Test;
2424
import org.junit.jupiter.api.extension.ExtendWith;
25-
import org.junit.jupiter.api.extension.RegisterExtension;
2625

2726
import org.springframework.boot.cli.command.grab.GrabCommand;
2827
import org.springframework.boot.test.system.CapturedOutput;
@@ -41,8 +40,7 @@
4140
@ExtendWith(OutputCaptureExtension.class)
4241
class GrabCommandIntegrationTests {
4342

44-
@RegisterExtension
45-
private CliTester cli;
43+
private final CliTester cli;
4644

4745
GrabCommandIntegrationTests(CapturedOutput capturedOutput) {
4846
this.cli = new CliTester("src/test/resources/grab-samples/", capturedOutput);

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/ReproIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import org.junit.jupiter.api.Test;
2222
import org.junit.jupiter.api.extension.ExtendWith;
23-
import org.junit.jupiter.api.extension.RegisterExtension;
2423

2524
import org.springframework.boot.test.system.CapturedOutput;
2625
import org.springframework.boot.test.system.OutputCaptureExtension;
@@ -38,8 +37,7 @@
3837
@ExtendWith(OutputCaptureExtension.class)
3938
class ReproIntegrationTests {
4039

41-
@RegisterExtension
42-
private CliTester cli;
40+
private final CliTester cli;
4341

4442
ReproIntegrationTests(CapturedOutput capturedOutput) {
4543
this.cli = new CliTester("src/test/resources/repro-samples/", capturedOutput);

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/RunCommandIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.junit.jupiter.api.BeforeEach;
2323
import org.junit.jupiter.api.Test;
2424
import org.junit.jupiter.api.extension.ExtendWith;
25-
import org.junit.jupiter.api.extension.RegisterExtension;
2625

2726
import org.springframework.boot.cli.command.run.RunCommand;
2827
import org.springframework.boot.test.system.CapturedOutput;
@@ -38,8 +37,7 @@
3837
@ExtendWith(OutputCaptureExtension.class)
3938
class RunCommandIntegrationTests {
4039

41-
@RegisterExtension
42-
private CliTester cli;
40+
private final CliTester cli;
4341

4442
RunCommandIntegrationTests(CapturedOutput capturedOutput) {
4543
this.cli = new CliTester("src/it/resources/run-command/", capturedOutput);

spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/SampleIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.junit.jupiter.api.Disabled;
2323
import org.junit.jupiter.api.Test;
2424
import org.junit.jupiter.api.extension.ExtendWith;
25-
import org.junit.jupiter.api.extension.RegisterExtension;
2625

2726
import org.springframework.boot.test.system.CapturedOutput;
2827
import org.springframework.boot.test.system.OutputCaptureExtension;
@@ -40,8 +39,7 @@
4039
@ExtendWith(OutputCaptureExtension.class)
4140
class SampleIntegrationTests {
4241

43-
@RegisterExtension
44-
private CliTester cli;
42+
private final CliTester cli;
4543

4644
SampleIntegrationTests(CapturedOutput capturedOutput) {
4745
this.cli = new CliTester("samples/", capturedOutput);

0 commit comments

Comments
 (0)