Skip to content

Commit ca71656

Browse files
committed
Update deployment test exclusions after web starter validation changes
The changes made in a6c1668 mean that the web starter no longer depends on spring-boot-starter-validation. Instead, it depends directly on hibernate-validator. This means that the exclusion of the validation starter in the TomEE deployment test app no longer matches anything and hibernate-validator is packaged in the war. This breaks the application as TomEE ships with Bean Validation 2.0 and the version of Hibernate Validator being used requires 2.1. This commit updates the exclusions in the TomEE deployment app so that hibernate-validator is excluded once again. This allows the app to use TomEE's bundled Bean Validation implementation. The stale spring-boot-starter-validation exclusion has been removed from the Wildfly deployment test app. It is redundant as Wildfly ships with Bean Validation 2.1. This brings this test app into line with the Glassfish test app. Closes gh-5454
1 parent 539d575 commit ca71656

File tree

2 files changed

+2
-6
lines changed
  • spring-boot-deployment-tests
    • spring-boot-deployment-test-tomee
    • spring-boot-deployment-test-wildfly

2 files changed

+2
-6
lines changed

spring-boot-deployment-tests/spring-boot-deployment-test-tomee/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
<artifactId>spring-boot-starter-tomcat</artifactId>
3434
</exclusion>
3535
<exclusion>
36-
<groupId>org.springframework.boot</groupId>
37-
<artifactId>spring-boot-starter-validation</artifactId>
36+
<groupId>org.hibernate</groupId>
37+
<artifactId>hibernate-validator</artifactId>
3838
</exclusion>
3939
</exclusions>
4040
</dependency>

spring-boot-deployment-tests/spring-boot-deployment-test-wildfly/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@
3131
<groupId>org.springframework.boot</groupId>
3232
<artifactId>spring-boot-starter-tomcat</artifactId>
3333
</exclusion>
34-
<exclusion>
35-
<groupId>org.springframework.boot</groupId>
36-
<artifactId>spring-boot-starter-validation</artifactId>
37-
</exclusion>
3834
</exclusions>
3935
</dependency>
4036
<dependency>

0 commit comments

Comments
 (0)