Skip to content

Commit c5d8eec

Browse files
wilkinsonawilkinsona
committed
Verify that starters do not pull in duplicate classes and resources
Closes gh-6163
1 parent 82c0f5d commit c5d8eec

File tree

15 files changed

+351
-0
lines changed
  • spring-boot-starters

15 files changed

+351
-0
lines changed

‎spring-boot-starters/pom.xml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,23 @@
143143
<skip>true</skip>
144144
</configuration>
145145
</plugin>
146+
<plugin>
147+
<groupId>org.basepom.maven</groupId>
148+
<artifactId>duplicate-finder-maven-plugin</artifactId>
149+
<version>1.2.1</version>
150+
<executions>
151+
<execution>
152+
<id>duplicate-dependencies</id>
153+
<phase>validate</phase>
154+
<goals>
155+
<goal>check</goal>
156+
</goals>
157+
<configuration>
158+
<failBuildInCaseOfConflict>true</failBuildInCaseOfConflict>
159+
</configuration>
160+
</execution>
161+
</executions>
162+
</plugin>
146163
</plugins>
147164
</build>
148165
</project>

‎spring-boot-starters/spring-boot-starter-batch/pom.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,37 @@
3535
<artifactId>spring-batch-core</artifactId>
3636
</dependency>
3737
</dependencies>
38+
<build>
39+
<plugins>
40+
<plugin>
41+
<groupId>org.basepom.maven</groupId>
42+
<artifactId>duplicate-finder-maven-plugin</artifactId>
43+
<executions>
44+
<execution>
45+
<id>duplicate-dependencies</id>
46+
<phase>validate</phase>
47+
<goals>
48+
<goal>check</goal>
49+
</goals>
50+
<configuration>
51+
<exceptions>
52+
<exception>
53+
<conflictingDependencies>
54+
<dependency>
55+
<groupId>xpp3</groupId>
56+
<artifactId>xpp3_min</artifactId>
57+
</dependency>
58+
<dependency>
59+
<groupId>xmlpull</groupId>
60+
<artifactId>xmlpull</artifactId>
61+
</dependency>
62+
</conflictingDependencies>
63+
</exception>
64+
</exceptions>
65+
</configuration>
66+
</execution>
67+
</executions>
68+
</plugin>
69+
</plugins>
70+
</build>
3871
</project>

‎spring-boot-starters/spring-boot-starter-data-couchbase/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,26 @@
3030
<artifactId>spring-data-couchbase</artifactId>
3131
</dependency>
3232
</dependencies>
33+
<build>
34+
<plugins>
35+
<plugin>
36+
<groupId>org.basepom.maven</groupId>
37+
<artifactId>duplicate-finder-maven-plugin</artifactId>
38+
<executions>
39+
<execution>
40+
<id>duplicate-dependencies</id>
41+
<phase>validate</phase>
42+
<goals>
43+
<goal>check</goal>
44+
</goals>
45+
<configuration>
46+
<ignoredResourcePatterns>
47+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
48+
</ignoredResourcePatterns>
49+
</configuration>
50+
</execution>
51+
</executions>
52+
</plugin>
53+
</plugins>
54+
</build>
3355
</project>

‎spring-boot-starters/spring-boot-starter-data-elasticsearch/pom.xml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,29 @@
2828
<artifactId>spring-data-elasticsearch</artifactId>
2929
</dependency>
3030
</dependencies>
31+
<build>
32+
<plugins>
33+
<plugin>
34+
<groupId>org.basepom.maven</groupId>
35+
<artifactId>duplicate-finder-maven-plugin</artifactId>
36+
<executions>
37+
<execution>
38+
<id>duplicate-dependencies</id>
39+
<phase>validate</phase>
40+
<goals>
41+
<goal>check</goal>
42+
</goals>
43+
<configuration>
44+
<ignoredClassPatterns>
45+
<ignoredClassPattern>org.joda.time.base.BaseDateTime</ignoredClassPattern>
46+
</ignoredClassPatterns>
47+
<ignoredResourcePatterns>
48+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
49+
</ignoredResourcePatterns>
50+
</configuration>
51+
</execution>
52+
</executions>
53+
</plugin>
54+
</plugins>
55+
</build>
3156
</project>

‎spring-boot-starters/spring-boot-starter-data-gemfire/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,26 @@
4646
</snapshots>
4747
</repository>
4848
</repositories>
49+
<build>
50+
<plugins>
51+
<plugin>
52+
<groupId>org.basepom.maven</groupId>
53+
<artifactId>duplicate-finder-maven-plugin</artifactId>
54+
<executions>
55+
<execution>
56+
<id>duplicate-dependencies</id>
57+
<phase>validate</phase>
58+
<goals>
59+
<goal>check</goal>
60+
</goals>
61+
<configuration>
62+
<ignoredResourcePatterns>
63+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
64+
</ignoredResourcePatterns>
65+
</configuration>
66+
</execution>
67+
</executions>
68+
</plugin>
69+
</plugins>
70+
</build>
4971
</project>

‎spring-boot-starters/spring-boot-starter-data-jpa/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,26 @@
5959
<artifactId>spring-aspects</artifactId>
6060
</dependency>
6161
</dependencies>
62+
<build>
63+
<plugins>
64+
<plugin>
65+
<groupId>org.basepom.maven</groupId>
66+
<artifactId>duplicate-finder-maven-plugin</artifactId>
67+
<executions>
68+
<execution>
69+
<id>duplicate-dependencies</id>
70+
<phase>validate</phase>
71+
<goals>
72+
<goal>check</goal>
73+
</goals>
74+
<configuration>
75+
<ignoredResourcePatterns>
76+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
77+
</ignoredResourcePatterns>
78+
</configuration>
79+
</execution>
80+
</executions>
81+
</plugin>
82+
</plugins>
83+
</build>
6284
</project>

‎spring-boot-starters/spring-boot-starter-data-redis/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,26 @@
3232
<artifactId>jedis</artifactId>
3333
</dependency>
3434
</dependencies>
35+
<build>
36+
<plugins>
37+
<plugin>
38+
<groupId>org.basepom.maven</groupId>
39+
<artifactId>duplicate-finder-maven-plugin</artifactId>
40+
<executions>
41+
<execution>
42+
<id>duplicate-dependencies</id>
43+
<phase>validate</phase>
44+
<goals>
45+
<goal>check</goal>
46+
</goals>
47+
<configuration>
48+
<ignoredResourcePatterns>
49+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
50+
</ignoredResourcePatterns>
51+
</configuration>
52+
</execution>
53+
</executions>
54+
</plugin>
55+
</plugins>
56+
</build>
3557
</project>

‎spring-boot-starters/spring-boot-starter-data-rest/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,26 @@
4040
<artifactId>spring-data-rest-webmvc</artifactId>
4141
</dependency>
4242
</dependencies>
43+
<build>
44+
<plugins>
45+
<plugin>
46+
<groupId>org.basepom.maven</groupId>
47+
<artifactId>duplicate-finder-maven-plugin</artifactId>
48+
<executions>
49+
<execution>
50+
<id>duplicate-dependencies</id>
51+
<phase>validate</phase>
52+
<goals>
53+
<goal>check</goal>
54+
</goals>
55+
<configuration>
56+
<ignoredResourcePatterns>
57+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
58+
</ignoredResourcePatterns>
59+
</configuration>
60+
</execution>
61+
</executions>
62+
</plugin>
63+
</plugins>
64+
</build>
4365
</project>

‎spring-boot-starters/spring-boot-starter-data-solr/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,26 @@
4242
<artifactId>httpmime</artifactId>
4343
</dependency>
4444
</dependencies>
45+
<build>
46+
<plugins>
47+
<plugin>
48+
<groupId>org.basepom.maven</groupId>
49+
<artifactId>duplicate-finder-maven-plugin</artifactId>
50+
<executions>
51+
<execution>
52+
<id>duplicate-dependencies</id>
53+
<phase>validate</phase>
54+
<goals>
55+
<goal>check</goal>
56+
</goals>
57+
<configuration>
58+
<ignoredResourcePatterns>
59+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
60+
</ignoredResourcePatterns>
61+
</configuration>
62+
</execution>
63+
</executions>
64+
</plugin>
65+
</plugins>
66+
</build>
4567
</project>

‎spring-boot-starters/spring-boot-starter-hornetq/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,26 @@
3232
<artifactId>hornetq-jms-client</artifactId>
3333
</dependency>
3434
</dependencies>
35+
<build>
36+
<plugins>
37+
<plugin>
38+
<groupId>org.basepom.maven</groupId>
39+
<artifactId>duplicate-finder-maven-plugin</artifactId>
40+
<executions>
41+
<execution>
42+
<id>duplicate-dependencies</id>
43+
<phase>validate</phase>
44+
<goals>
45+
<goal>check</goal>
46+
</goals>
47+
<configuration>
48+
<ignoredResourcePatterns>
49+
<ignoredResourcePattern>org/hornetq/utils.HornetQUtil(Bundle|Logger).i18n.properties</ignoredResourcePattern>
50+
</ignoredResourcePatterns>
51+
</configuration>
52+
</execution>
53+
</executions>
54+
</plugin>
55+
</plugins>
56+
</build>
3557
</project>

‎spring-boot-starters/spring-boot-starter-jersey/pom.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,27 @@
8080
<artifactId>jersey-media-json-jackson</artifactId>
8181
</dependency>
8282
</dependencies>
83+
<build>
84+
<plugins>
85+
<plugin>
86+
<groupId>org.basepom.maven</groupId>
87+
<artifactId>duplicate-finder-maven-plugin</artifactId>
88+
<executions>
89+
<execution>
90+
<id>duplicate-dependencies</id>
91+
<phase>validate</phase>
92+
<goals>
93+
<goal>check</goal>
94+
</goals>
95+
<configuration>
96+
<ignoredClassPatterns>
97+
<ignoredClassPattern>org.aopalliance.*</ignoredClassPattern>
98+
<ignoredClassPattern>javax.annotation.*</ignoredClassPattern>
99+
</ignoredClassPatterns>
100+
</configuration>
101+
</execution>
102+
</executions>
103+
</plugin>
104+
</plugins>
105+
</build>
83106
</project>

‎spring-boot-starters/spring-boot-starter-jetty/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,26 @@
4242
</exclusions>
4343
</dependency>
4444
</dependencies>
45+
<build>
46+
<plugins>
47+
<plugin>
48+
<groupId>org.basepom.maven</groupId>
49+
<artifactId>duplicate-finder-maven-plugin</artifactId>
50+
<executions>
51+
<execution>
52+
<id>duplicate-dependencies</id>
53+
<phase>validate</phase>
54+
<goals>
55+
<goal>check</goal>
56+
</goals>
57+
<configuration>
58+
<ignoredResourcePatterns>
59+
<ignoredResourcePattern>about.html</ignoredResourcePattern>
60+
</ignoredResourcePatterns>
61+
</configuration>
62+
</execution>
63+
</executions>
64+
</plugin>
65+
</plugins>
66+
</build>
4567
</project>

‎spring-boot-starters/spring-boot-starter-redis/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,26 @@
3232
<artifactId>jedis</artifactId>
3333
</dependency>
3434
</dependencies>
35+
<build>
36+
<plugins>
37+
<plugin>
38+
<groupId>org.basepom.maven</groupId>
39+
<artifactId>duplicate-finder-maven-plugin</artifactId>
40+
<executions>
41+
<execution>
42+
<id>duplicate-dependencies</id>
43+
<phase>validate</phase>
44+
<goals>
45+
<goal>check</goal>
46+
</goals>
47+
<configuration>
48+
<ignoredResourcePatterns>
49+
<ignoredResourcePattern>changelog.txt</ignoredResourcePattern>
50+
</ignoredResourcePatterns>
51+
</configuration>
52+
</execution>
53+
</executions>
54+
</plugin>
55+
</plugins>
56+
</build>
3557
</project>

‎spring-boot-starters/spring-boot-starter-remote-shell/pom.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,26 @@
117117
<artifactId>javax.mail</artifactId>
118118
</dependency>
119119
</dependencies>
120+
<build>
121+
<plugins>
122+
<plugin>
123+
<groupId>org.basepom.maven</groupId>
124+
<artifactId>duplicate-finder-maven-plugin</artifactId>
125+
<executions>
126+
<execution>
127+
<id>duplicate-dependencies</id>
128+
<phase>validate</phase>
129+
<goals>
130+
<goal>check</goal>
131+
</goals>
132+
<configuration>
133+
<ignoredResourcePatterns>
134+
<ignoredResourcePattern>crash/crash.properties</ignoredResourcePattern>
135+
</ignoredResourcePatterns>
136+
</configuration>
137+
</execution>
138+
</executions>
139+
</plugin>
140+
</plugins>
141+
</build>
120142
</project>

0 commit comments

Comments
 (0)